From: Borislav Petkov <bp@alien8.de>
To: "Shenhar, Talel" <talel@amazon.com>
Cc: mchehab@kernel.org, james.morse@arm.com, davem@davemloft.net,
gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will@kernel.org,
linux-edac@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, hhhawa@amazon.com,
ronenk@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
eitan@amazon.com
Subject: Re: [PATCH v9 2/2] EDAC: al-mc-edac: Introduce Amazon's Annapurna Labs Memory Controller EDAC
Date: Sun, 16 Aug 2020 13:22:44 +0200 [thread overview]
Message-ID: <20200816112244.GG21914@zn.tnic> (raw)
In-Reply-To: <5d516c64-ecd8-6f36-5f95-6708fe0f3fd5@amazon.com>
On Sun, Aug 16, 2020 at 12:17:31PM +0300, Shenhar, Talel wrote:
> Let me know what you think.
Well, devm_al_mc_edac_free() devm_al_mc_edac_del() look like useless
wrappers to me and can be removed and you can use edac_mc_del_mc() and
edac_mc_free() directly. But then you need to cast them in an ugly way
so that it builds:
ret = devm_add_action(&pdev->dev, (void (*)(void *data))edac_mc_free, mci);
I guess we can leave them as is and then lift them into the EDAC core if
someone else wants to do the same devm_* thing.
al_mc_edac_get_scrub_mode() doesn't need a prefix because it is used
only once and the compiler is simply inlining it so you can forget the
stack trace visibility:
$ readelf -s drivers/edac/al_mc_edac.ko | grep scrub
$
The others are fine, I guess, since they're function pointers and cannot be
inlined as such so you want them prefixed:
$ readelf -s drivers/edac/al_mc_edac.ko | grep al_mc_edac
23: 00000000 0 FILE LOCAL DEFAULT ABS al_mc_edac.c
25: 00000000 4 FUNC LOCAL DEFAULT 1 devm_al_mc_edac_free
27: 00000004 4 FUNC LOCAL DEFAULT 1 devm_al_mc_edac_del
31: 00000124 24 FUNC LOCAL DEFAULT 1 al_mc_edac_irq_handler_ce
35: 00000260 24 FUNC LOCAL DEFAULT 1 al_mc_edac_irq_handler_ue
36: 00000278 56 FUNC LOCAL DEFAULT 1 al_mc_edac_check
37: 000002b0 680 FUNC LOCAL DEFAULT 1 al_mc_edac_probe
47: 00000000 20 FUNC LOCAL DEFAULT 3 al_mc_edac_driver_init
51: 00000000 12 FUNC LOCAL DEFAULT 5 al_mc_edac_driver_exit
53: 00000000 392 OBJECT LOCAL DEFAULT 16 al_mc_edac_of_match
59: 00000000 104 OBJECT LOCAL DEFAULT 20 al_mc_edac_driver
61: 00000000 0 FILE LOCAL DEFAULT ABS al_mc_edac.mod.c
88: 00000000 392 OBJECT GLOBAL DEFAULT 16 __mod_of__al_mc_edac_of_m
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-08-16 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 9:51 [PATCH v9 0/2] Amazon's Annapurna Labs Memory Controller EDAC Talel Shenhar
2020-07-28 9:51 ` [PATCH v9 1/2] dt-bindings: edac: al-mc-edac: " Talel Shenhar
2020-07-28 9:51 ` [PATCH v9 2/2] EDAC: al-mc-edac: Introduce " Talel Shenhar
2020-08-15 18:33 ` Borislav Petkov
2020-08-16 9:17 ` Shenhar, Talel
2020-08-16 11:22 ` Borislav Petkov [this message]
2020-08-16 11:35 ` Shenhar, Talel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816112244.GG21914@zn.tnic \
--to=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eitan@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).