* [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR
@ 2023-01-29 16:50 Jonathan Neuschäfer
2023-03-19 19:20 ` Borislav Petkov
2023-03-28 13:42 ` Borislav Petkov
0 siblings, 2 replies; 5+ messages in thread
From: Jonathan Neuschäfer @ 2023-01-29 16:50 UTC (permalink / raw)
To: linux-edac
Cc: Jonathan Neuschäfer, Borislav Petkov, Tony Luck,
James Morse, Mauro Carvalho Chehab, Robert Richter, linux-kernel
MODULE_AUTHOR strings don't usually include a newline character.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
drivers/edac/amd8111_edac.c | 2 +-
drivers/edac/amd8131_edac.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c
index 7508aa416ddbd..ca718f63fcbcd 100644
--- a/drivers/edac/amd8111_edac.c
+++ b/drivers/edac/amd8111_edac.c
@@ -593,5 +593,5 @@ module_init(amd8111_edac_init);
module_exit(amd8111_edac_exit);
MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n");
+MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>");
MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module");
diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
index 1693537109826..28610ba514f4d 100644
--- a/drivers/edac/amd8131_edac.c
+++ b/drivers/edac/amd8131_edac.c
@@ -354,5 +354,5 @@ module_init(amd8131_edac_init);
module_exit(amd8131_edac_exit);
MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n");
+MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>");
MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module");
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR
2023-01-29 16:50 [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR Jonathan Neuschäfer
@ 2023-03-19 19:20 ` Borislav Petkov
2023-03-28 19:26 ` Jonathan Neuschäfer
2023-03-28 13:42 ` Borislav Petkov
1 sibling, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2023-03-19 19:20 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: linux-edac, Tony Luck, James Morse, Mauro Carvalho Chehab,
Robert Richter, linux-kernel
On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote:
> MODULE_AUTHOR strings don't usually include a newline character.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> drivers/edac/amd8111_edac.c | 2 +-
> drivers/edac/amd8131_edac.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c
> index 7508aa416ddbd..ca718f63fcbcd 100644
> --- a/drivers/edac/amd8111_edac.c
> +++ b/drivers/edac/amd8111_edac.c
> @@ -593,5 +593,5 @@ module_init(amd8111_edac_init);
> module_exit(amd8111_edac_exit);
>
> MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n");
> +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>");
> MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module");
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 1693537109826..28610ba514f4d 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -354,5 +354,5 @@ module_init(amd8131_edac_init);
> module_exit(amd8131_edac_exit);
>
> MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n");
> +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>");
> MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module");
> --
Wanna fix the other two in the EDAC tree:
drivers/edac/e752x_edac.c:1465:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Tom Zimmerman\n");
drivers/edac/e7xxx_edac.c:599:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Thayne Harbaugh et al\n"
?
That macro takes:
/*
* Author(s), use "Name <email>" or just "Name", for multiple
* authors use multiple MODULE_AUTHOR() statements/lines.
*/
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
and not prose.
You can move the prose to the top comment in the respective file, if it
doesn't contain it yet.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR
2023-03-19 19:20 ` Borislav Petkov
@ 2023-03-28 19:26 ` Jonathan Neuschäfer
2023-03-28 19:40 ` Borislav Petkov
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Neuschäfer @ 2023-03-28 19:26 UTC (permalink / raw)
To: Borislav Petkov
Cc: Jonathan Neuschäfer, linux-edac, Tony Luck, James Morse,
Mauro Carvalho Chehab, Robert Richter, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Sun, Mar 19, 2023 at 08:20:11PM +0100, Borislav Petkov wrote:
> On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote:
[...]
> Wanna fix the other two in the EDAC tree:
>
> drivers/edac/e752x_edac.c:1465:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Tom Zimmerman\n");
> drivers/edac/e7xxx_edac.c:599:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Thayne Harbaugh et al\n"
>
> ?
>
> That macro takes:
>
> /*
> * Author(s), use "Name <email>" or just "Name", for multiple
> * authors use multiple MODULE_AUTHOR() statements/lines.
> */
> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
>
> and not prose.
>
> You can move the prose to the top comment in the respective file, if it
> doesn't contain it yet.
>
> Thx.
Sorry for the late reply. I'm replying now because I saw that you
applied the patch.
I might fix the above if/when I get around to it, but there's currently
no guarantee of that.
Best regards,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR
2023-03-28 19:26 ` Jonathan Neuschäfer
@ 2023-03-28 19:40 ` Borislav Petkov
0 siblings, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2023-03-28 19:40 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: linux-edac, Tony Luck, James Morse, Mauro Carvalho Chehab,
Robert Richter, linux-kernel
On Tue, Mar 28, 2023 at 09:26:37PM +0200, Jonathan Neuschäfer wrote:
> I might fix the above if/when I get around to it, but there's currently
> no guarantee of that.
No need, already took care of them all, while at it.
Thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR
2023-01-29 16:50 [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR Jonathan Neuschäfer
2023-03-19 19:20 ` Borislav Petkov
@ 2023-03-28 13:42 ` Borislav Petkov
1 sibling, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2023-03-28 13:42 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: linux-edac, Tony Luck, James Morse, Mauro Carvalho Chehab,
Robert Richter, linux-kernel
On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote:
> MODULE_AUTHOR strings don't usually include a newline character.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> drivers/edac/amd8111_edac.c | 2 +-
> drivers/edac/amd8131_edac.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c
> index 7508aa416ddbd..ca718f63fcbcd 100644
> --- a/drivers/edac/amd8111_edac.c
> +++ b/drivers/edac/amd8111_edac.c
> @@ -593,5 +593,5 @@ module_init(amd8111_edac_init);
> module_exit(amd8111_edac_exit);
>
> MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n");
> +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>");
> MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module");
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 1693537109826..28610ba514f4d 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -354,5 +354,5 @@ module_init(amd8131_edac_init);
> module_exit(amd8131_edac_exit);
>
> MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n");
> +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>");
> MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module");
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-28 19:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 16:50 [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR Jonathan Neuschäfer
2023-03-19 19:20 ` Borislav Petkov
2023-03-28 19:26 ` Jonathan Neuschäfer
2023-03-28 19:40 ` Borislav Petkov
2023-03-28 13:42 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).