From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, bp@alien8.de,
tony.luck@intel.com
Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, james.morse@arm.com,
mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org,
quic_ppareek@quicinc.com, luca.weiss@fairphone.com,
ahalaney@redhat.com, steev@kali.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
stable@vger.kernel.org
Subject: [PATCH v8 14/14] soc: qcom: llcc: Do not create EDAC platform device on SDM845
Date: Tue, 14 Mar 2023 13:34:43 +0530 [thread overview]
Message-ID: <20230314080443.64635-15-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20230314080443.64635-1-manivannan.sadhasivam@linaro.org>
The platforms based on SDM845 SoC locks the access to EDAC registers in the
bootloader. So probing the EDAC driver will result in a crash. Hence,
disable the creation of EDAC platform device on all SDM845 devices.
The issue has been observed on Lenovo Yoga C630 and DB845c.
While at it, also sort the members of `struct qcom_llcc_config` to avoid
any holes in-between.
Cc: <stable@vger.kernel.org> # 5.10
Reported-by: Steev Klimaszewski <steev@kali.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/soc/qcom/llcc-qcom.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 7b7c5a38bac6..a5140f19f200 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -120,10 +120,11 @@ struct llcc_slice_config {
struct qcom_llcc_config {
const struct llcc_slice_config *sct_data;
- int size;
- bool need_llcc_cfg;
const u32 *reg_offset;
const struct llcc_edac_reg_offset *edac_reg_offset;
+ int size;
+ bool need_llcc_cfg;
+ bool no_edac;
};
enum llcc_reg_offset {
@@ -452,6 +453,7 @@ static const struct qcom_llcc_config sdm845_cfg = {
.need_llcc_cfg = false,
.reg_offset = llcc_v1_reg_offset,
.edac_reg_offset = &llcc_v1_edac_reg_offset,
+ .no_edac = true,
};
static const struct qcom_llcc_config sm6350_cfg = {
@@ -1012,11 +1014,19 @@ static int qcom_llcc_probe(struct platform_device *pdev)
drv_data->ecc_irq = platform_get_irq_optional(pdev, 0);
- llcc_edac = platform_device_register_data(&pdev->dev,
- "qcom_llcc_edac", -1, drv_data,
- sizeof(*drv_data));
- if (IS_ERR(llcc_edac))
- dev_err(dev, "Failed to register llcc edac driver\n");
+ /*
+ * On some platforms, the access to EDAC registers will be locked by
+ * the bootloader. So probing the EDAC driver will result in a crash.
+ * Hence, disable the creation of EDAC platform device for the
+ * problematic platforms.
+ */
+ if (!cfg->no_edac) {
+ llcc_edac = platform_device_register_data(&pdev->dev,
+ "qcom_llcc_edac", -1, drv_data,
+ sizeof(*drv_data));
+ if (IS_ERR(llcc_edac))
+ dev_err(dev, "Failed to register llcc edac driver\n");
+ }
return 0;
err:
--
2.25.1
next prev parent reply other threads:[~2023-03-14 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 8:04 [PATCH v8 00/14] Qcom: LLCC/EDAC: Fix base address used for LLCC banks Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 01/14] dt-bindings: arm: msm: Update the maintainers for LLCC Manivannan Sadhasivam
2023-03-19 12:46 ` Krzysztof Kozlowski
2023-03-14 8:04 ` [PATCH v8 02/14] dt-bindings: arm: msm: Fix register regions used for LLCC banks Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 03/14] arm64: dts: qcom: sdm845: Fix the base addresses of " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 04/14] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 05/14] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 06/14] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 07/14] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 08/14] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 09/14] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 10/14] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 11/14] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 12/14] qcom: llcc/edac: Fix the base address used for accessing " Manivannan Sadhasivam
2023-03-14 8:04 ` [PATCH v8 13/14] qcom: llcc/edac: Support polling mode for ECC handling Manivannan Sadhasivam
2023-03-14 8:04 ` Manivannan Sadhasivam [this message]
2023-03-15 23:35 ` (subset) [PATCH v8 00/14] Qcom: LLCC/EDAC: Fix base address used for LLCC banks Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314080443.64635-15-manivannan.sadhasivam@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=quic_ppareek@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=stable@vger.kernel.org \
--cc=steev@kali.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).