From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: "Limonciello, Mario" <mario.limonciello@amd.com>,
linux-edac@vger.kernel.org, hdegoede@redhat.com,
markgross@kernel.org, platform-driver-x86@vger.kernel.org, "Luck,
Tony" <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, avadhut.naik@amd.com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library
Date: Tue, 8 Aug 2023 16:20:07 +0200 [thread overview]
Message-ID: <20230808142007.GCZNJPFy8PqTJgTAN5@fat_crate.local> (raw)
In-Reply-To: <f989cd56-a066-409a-8d82-40d0bc6ff89b@amd.com>
On Tue, Aug 08, 2023 at 10:07:19AM -0400, Yazen Ghannam wrote:
> But just because there's existing vendor-specific code in arch/x86 doesn't
> necessarily mean we should keep adding to it. So is this okay?
I'd say since it is not so close to the arch/ part, drivers/ras/ is more
fitting IMO. Just like mce_amd is in drivers/edac/.
Which reminds me: why aren't you adding it to
drivers/edac/mce_amd.c
?
That is an MCE decoder *already*.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-08-08 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 18:55 [PATCH 0/2] AMD Address Translation Library Yazen Ghannam
2023-08-02 18:55 ` [PATCH 1/2] platform/x86/amd: Introduce " Yazen Ghannam
2023-08-07 20:44 ` Yazen Ghannam
2023-08-08 3:17 ` Limonciello, Mario
2023-08-08 12:10 ` Borislav Petkov
2023-08-08 14:07 ` Yazen Ghannam
2023-08-08 14:20 ` Borislav Petkov [this message]
2023-08-08 14:28 ` Yazen Ghannam
2023-08-08 14:37 ` Borislav Petkov
2023-08-08 15:18 ` Yazen Ghannam
2023-08-08 15:58 ` Borislav Petkov
2023-08-08 16:24 ` Yazen Ghannam
2023-08-09 14:38 ` Hans de Goede
2023-08-09 15:05 ` Yazen Ghannam
2023-08-02 18:55 ` [PATCH 2/2] EDAC/amd64: Use new " Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808142007.GCZNJPFy8PqTJgTAN5@fat_crate.local \
--to=bp@alien8.de \
--cc=avadhut.naik@amd.com \
--cc=hdegoede@redhat.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).