linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>,
	"Limonciello, Mario" <mario.limonciello@amd.com>,
	linux-edac@vger.kernel.org, hdegoede@redhat.com,
	markgross@kernel.org, platform-driver-x86@vger.kernel.org, "Luck,
	Tony" <tony.luck@intel.com>
Cc: yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
	avadhut.naik@amd.com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library
Date: Tue, 8 Aug 2023 10:07:19 -0400	[thread overview]
Message-ID: <f989cd56-a066-409a-8d82-40d0bc6ff89b@amd.com> (raw)
In-Reply-To: <B3BE6B56-FBAB-4878-A45D-E95AFAC86AB1@alien8.de>

On 8/8/2023 8:10 AM, Borislav Petkov wrote:
> On August 8, 2023 5:17:33 AM GMT+02:00, "Limonciello, Mario" <mario.limonciello@amd.com> wrote:
>> Given it's 'library code' to be used by a bunch of things and also want to be able to use a module, what about putting it in lib/?  There's plenty of library code there as tristate.
> 
> It is x86-specific so not in there. Also, it might be used by multiple things so you want it as a separate "translation" service which is called by other modules.
> 

There are modules in arch/x86, so I guess that's not an issue (not sure 
what I was thinking).

This code is AMD-specific, and there's vendor-specific code in arch/x86 
already. So it may be fine to have this in arch/x86/ras.

But just because there's existing vendor-specific code in arch/x86 
doesn't necessarily mean we should keep adding to it. So is this okay?

Thanks,
Yazen


  reply	other threads:[~2023-08-08 16:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 18:55 [PATCH 0/2] AMD Address Translation Library Yazen Ghannam
2023-08-02 18:55 ` [PATCH 1/2] platform/x86/amd: Introduce " Yazen Ghannam
2023-08-07 20:44   ` Yazen Ghannam
2023-08-08  3:17     ` Limonciello, Mario
2023-08-08 12:10       ` Borislav Petkov
2023-08-08 14:07         ` Yazen Ghannam [this message]
2023-08-08 14:20           ` Borislav Petkov
2023-08-08 14:28             ` Yazen Ghannam
2023-08-08 14:37               ` Borislav Petkov
2023-08-08 15:18                 ` Yazen Ghannam
2023-08-08 15:58                   ` Borislav Petkov
2023-08-08 16:24                     ` Yazen Ghannam
2023-08-09 14:38           ` Hans de Goede
2023-08-09 15:05             ` Yazen Ghannam
2023-08-02 18:55 ` [PATCH 2/2] EDAC/amd64: Use new " Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f989cd56-a066-409a-8d82-40d0bc6ff89b@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avadhut.naik@amd.com \
    --cc=bp@alien8.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).