From: Borislav Petkov <bp@alien8.de>
To: Shravan Ramani <shravankr@nvidia.com>
Cc: James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access
Date: Fri, 1 Sep 2023 09:38:23 +0200 [thread overview]
Message-ID: <20230901073823.GAZPGU75L6YEPGopLb@fat_crate.local> (raw)
In-Reply-To: <DM4PR12MB5136B7483D9E76625B2BDCA1C0E5A@DM4PR12MB5136.namprd12.prod.outlook.com>
On Thu, Aug 31, 2023 at 04:31:23AM +0000, Shravan Ramani wrote:
> SMC is needed by the driver to access certain HW blocks/registers which
> can be accessed only from secure state. Whether a certain block requires
> these secure calls or not is encoded in the ACPI table entry and passed
> on to the driver.
This sounds like a good start towards explaining why this patch is
needed. Here's an example commit message structure:
1. Prepare the context for the explanation briefly.
2. Explain the problem at hand.
3. "It happens because of <...>"
4. "Fix it by doing X"
5. "(Potentially do Y)."
For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".
Do not talk about what your patch does - that should (hopefully) be
visible from the diff itself. Rather, talk about *why* you're doing what
you're doing.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-09-01 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 10:56 [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access Shravan Kumar Ramani
2023-08-30 11:34 ` Borislav Petkov
2023-08-31 4:31 ` Shravan Ramani
2023-09-01 7:38 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901073823.GAZPGU75L6YEPGopLb@fat_crate.local \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=shravankr@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).