From: Shravan Ramani <shravankr@nvidia.com>
To: Borislav Petkov <bp@alien8.de>
Cc: James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access
Date: Thu, 31 Aug 2023 04:31:23 +0000 [thread overview]
Message-ID: <DM4PR12MB5136B7483D9E76625B2BDCA1C0E5A@DM4PR12MB5136.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230830113421.GBZO8pPUILVoBUVlki@fat_crate.local>
>> Add secure read/write calls (arm_smccc_smc) to bluefield_edac.
>> The ACPI table entry decides whether SMC is need for accessing
>
> SMC? Self-Modifying Code?
SMC stands for Secure Monitor Call. ARM documentation can be found
here: https://developer.arm.com/documentation/den0028/latest/
SMC is needed by the driver to access certain HW blocks/registers which
can be accessed only from secure state. Whether a certain block requires
these secure calls or not is encoded in the ACPI table entry and passed
on to the driver.
>
>> +static int edac_readl(void __iomem *addr, uint32_t *result,
>
> No "edac_" previxes to driver-local functions. They belong to the EDAC
> subsystem.
Ack, will change the prefixes in v2.
Thanks,
Shravan
next prev parent reply other threads:[~2023-08-31 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 10:56 [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access Shravan Kumar Ramani
2023-08-30 11:34 ` Borislav Petkov
2023-08-31 4:31 ` Shravan Ramani [this message]
2023-09-01 7:38 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5136B7483D9E76625B2BDCA1C0E5A@DM4PR12MB5136.namprd12.prod.outlook.com \
--to=shravankr@nvidia.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).