* [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word "error" for message "Failed to register device with error %d"
@ 2020-03-20 8:26 she90122 .
2020-03-20 8:52 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: she90122 . @ 2020-03-20 8:26 UTC (permalink / raw)
To: she90122
Cc: Tony Luck, Borislav Petkov, Mauro Carvalho Chehab, James Morse,
Robert Richter, linux-edac, linux-kernel, Amy.Shih, Oakley.Ding
From: Amy Shih <amy.shih@advantech.com.tw>
Fix the log level from "KERN_ERR" to "KERN_INFO" and remove the word
"error" for message "Failed to register device with error %d", since
it is not the error message but the information to notice the user.
Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
---
Changes in v2:
- Remove the word "error" from output message.
---
drivers/edac/pnd2_edac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index
933f772..399da3e 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
rc = pnd2_probe();
if (rc < 0) {
- pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+ pnd2_printk(KERN_INFO,
+ "Failed to register device - %d.\n", rc);
return rc;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word "error" for message "Failed to register device with error %d"
2020-03-20 8:26 [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word "error" for message "Failed to register device with error %d" she90122 .
@ 2020-03-20 8:52 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-03-20 8:52 UTC (permalink / raw)
To: she90122 .
Cc: Tony Luck, Borislav Petkov, Mauro Carvalho Chehab, James Morse,
Robert Richter, linux-edac, linux-kernel, Amy.Shih, Oakley.Ding
On Fri, 2020-03-20 at 16:26 +0800, she90122 . wrote:
> From: Amy Shih <amy.shih@advantech.com.tw>
>
> Fix the log level from "KERN_ERR" to "KERN_INFO" and remove the word
> "error" for message "Failed to register device with error %d", since
> it is not the error message but the information to notice the user.
>
> Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
> ---
> Changes in v2:
> - Remove the word "error" from output message.
> ---
> drivers/edac/pnd2_edac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index
> 933f772..399da3e 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
>
> rc = pnd2_probe();
> if (rc < 0) {
> - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
> + pnd2_printk(KERN_INFO,
> + "Failed to register device - %d.\n", rc);
> return rc;
> }
This will not apply as it's whitespace damaged.
Another possibility would be to use the new %pe extension.
---
drivers/edac/pnd2_edac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 933f77..370f219 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
rc = pnd2_probe();
if (rc < 0) {
- pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+ pnd2_printk(KERN_INFO, "Failed to register device - %pe\n",
+ ERR_PTR(rc));
return rc;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-20 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 8:26 [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word "error" for message "Failed to register device with error %d" she90122 .
2020-03-20 8:52 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).