linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Muralidhara M K <muralimk@amd.com>,
	linux-edac@vger.kernel.org, x86@kernel.org
Cc: yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
	bp@alien8.de, mingo@redhat.com, mchehab@kernel.org,
	nchatrad@amd.com, Muralidhara M K <muralidhara.mk@amd.com>
Subject: Re: [PATCH 1/7] x86/amd_nb: Add AMD Family 19h Models(80h-80fh) and (90h-9fh) PCI IDs
Date: Fri, 21 Jul 2023 10:44:43 -0400	[thread overview]
Message-ID: <6bce6a44-890e-9d50-dd10-e621b4d2a735@amd.com> (raw)
In-Reply-To: <20230720125425.3735538-2-muralimk@amd.com>

On 7/20/2023 8:54 AM, Muralidhara M K wrote:
> From: Muralidhara M K <muralidhara.mk@amd.com>
> 
> Add new Root, Device 18h Function 3, and Function 4 PCI IDS
> for x86 AMD family 19h, Models 80h-80fh and 90h-9fh.
> 

$SUBJECT and commit message reference Family/Models, but the patch uses 
the code name MI300.

I suggest using MI300 in the $SUBJECT. And highlight in the message that 
both groups of MI300 use the same IDs. You can clarify that Models 
80h-8Fh are MI300C and 90h-9Fh are MI300A.

Thanks,
Yazen

  reply	other threads:[~2023-07-21 14:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 12:54 [PATCH 0/7] AMD Family 19h Models 90h-9fh EDAC Support Muralidhara M K
2023-07-20 12:54 ` [PATCH 1/7] x86/amd_nb: Add AMD Family 19h Models(80h-80fh) and (90h-9fh) PCI IDs Muralidhara M K
2023-07-21 14:44   ` Yazen Ghannam [this message]
2023-07-20 12:54 ` [PATCH 2/7] EDAC/mce_amd: Remove SMCA Extended Error code descriptions Muralidhara M K
2023-07-20 13:59   ` Borislav Petkov
2023-07-20 15:25     ` M K, Muralidhara
2023-07-20 15:55       ` Borislav Petkov
2023-07-21 14:45         ` Yazen Ghannam
2023-10-24  6:18           ` M K, Muralidhara
2023-07-20 12:54 ` [PATCH 3/7] x86/MCE/AMD: Add new MA_LLC, USR_DP, and USR_CP bank types Muralidhara M K
2023-07-22  8:20   ` Borislav Petkov
2023-07-20 12:54 ` [PATCH 4/7] EDAC/mc: Add new HBM3 memory type Muralidhara M K
2023-08-03 10:27   ` Borislav Petkov
2023-07-20 12:54 ` [PATCH 5/7] EDAC/amd64: Add Fam19h Model 90h ~ 9fh enumeration support Muralidhara M K
2023-08-05 10:10   ` Borislav Petkov
2023-07-20 12:54 ` [PATCH 6/7] EDAC/amd64: Add error instance get_err_info() to pvt->ops Muralidhara M K
2023-07-21 14:47   ` Yazen Ghannam
2023-07-20 12:54 ` [PATCH 7/7] EDAC/amd64: Add Error address conversion for UMC Muralidhara M K
2023-07-21 14:49   ` Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bce6a44-890e-9d50-dd10-e621b4d2a735@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=muralidhara.mk@amd.com \
    --cc=muralimk@amd.com \
    --cc=nchatrad@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).