From: Paul Marks <paul@pmarks.net>
To: Jason Baron <jbaron@akamai.com>
Cc: linux-edac@vger.kernel.org, bp@alien8.de
Subject: Re: ie31200_edac missing PCI ID for i3-4370
Date: Tue, 9 Feb 2021 15:58:03 -0800 [thread overview]
Message-ID: <CAHq9+ShvTowrZusjxFV+yGzM=gCmG_mFJAsKwaHQ=qi_OknKCA@mail.gmail.com> (raw)
In-Reply-To: <77c3f46c-3519-d791-7bfe-97186d6893bb@akamai.com>
On Tue, Feb 9, 2021 at 2:25 PM Jason Baron <jbaron@akamai.com> wrote:
>
> On 2/4/21 6:22 PM, Paul Marks wrote:
> > On Thu, Feb 4, 2021 at 2:59 PM Jason Baron <jbaron@akamai.com> wrote:
> >>
> >> On 1/31/21 7:07 PM, Paul Marks wrote:
> >>> I have an ASRock C226M WS with an i3-4370 CPU.
> >>>
> >>> # lspci -vnn
> >>> 00:00.0 Host bridge [0600]: Intel Corporation 4th Gen Core Processor
> >>> DRAM Controller [8086:0c00] (rev 06)
> >>> Subsystem: ASRock Incorporation 4th Gen Core Processor
> >>> DRAM Controller [1849:0c00]
> >>> Flags: bus master, fast devsel, latency 0
> >>> Capabilities: [e0] Vendor Specific Information: Len=0c <?>
> >>> Kernel driver in use: hsw_uncore
> >>>
> >>> But edac-util doesn't work:
> >>>
> >>> # edac-util -v
> >>> edac-util: Fatal: Unable to get EDAC data: Unable to find EDAC data in sysfs
> >>>
> >>> I tried this ham-fisted patch:
> >>>
> >>> # diff -u ./drivers/edac/ie31200_edac.c{.old,}
> >>> --- ./drivers/edac/ie31200_edac.c.old
> >>> +++ ./drivers/edac/ie31200_edac.c
> >>> @@ -58,7 +58,7 @@
> >>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_3 0x0150
> >>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_4 0x0158
> >>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_5 0x015c
> >>> -#define PCI_DEVICE_ID_INTEL_IE31200_HB_6 0x0c04
> >>> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_6 0x0c00
> >>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_7 0x0c08
> >>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_8 0x1918
> >>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_9 0x5918
> >>
> >> just curious why you removed here and didn't just add?
> >
> > This is not a serious patch, just a one-liner to demonstrate the problem.
>
> Ok. Any chance you can find the datasheet that shows that this
> driver is using the appropriate registers for this hw? I didn't
> find it quickly looking...
>
I wouldn't know where to begin. Do you have an example of a similar
datasheet from one of the known-good devices?
I left "memtester" running on this machine, because it might increase
the odds of generating an ECC error someday.
next prev parent reply other threads:[~2021-02-10 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 0:07 ie31200_edac missing PCI ID for i3-4370 Paul Marks
2021-02-04 22:59 ` Jason Baron
2021-02-04 23:22 ` Paul Marks
2021-02-09 22:25 ` Jason Baron
2021-02-09 23:58 ` Paul Marks [this message]
2021-02-10 3:27 ` Jason Baron
2021-02-10 15:31 ` Jason Baron
[not found] <CAC0EBY-QL5LP+POpyjjt-8rc7d5r2YC+2gzf-SShrJ6DQoyWqw@mail.gmail.com>
[not found] ` <CAC0EBY8piMhd=wTKb94_cEP9FHWax_79V+MTt4_cY7jZYdoRkg@mail.gmail.com>
2021-05-15 11:10 ` Rick Moritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHq9+ShvTowrZusjxFV+yGzM=gCmG_mFJAsKwaHQ=qi_OknKCA@mail.gmail.com' \
--to=paul@pmarks.net \
--cc=bp@alien8.de \
--cc=jbaron@akamai.com \
--cc=linux-edac@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).