[PATCH] EDAC/mce_amd: Print !SMCA processor warning for 0x19 family

[PATCH] EDAC/mce_amd: Print !SMCA processor warning for 0x19 family

[Kaige Fu]

KVM doesn't enable SMCA for 0x19 family AMD processors.
Consequently, a warning as following will be print when load
edac_mce_amd.ko in a virtual machine.

"Huh? What family is it: 0x19?!"

To make the log more clear, this patch prints !SMCA processor
warning for 0x19 family.

Signed-off-by: Kaige Fu <kaige.fu@linux.alibaba.com>
Cc: Shannon Zhao <shannon.zhao@linux.alibaba.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: James Morse <james.morse@arm.com>
Cc: Robert Richter <rrichter@marvell.com>
Cc: linux-edac@vger.kernel.org
---
 drivers/edac/mce_amd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index 5dd905a3f30c..0602082c1ef0 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -1229,6 +1229,7 @@ static int __init mce_amd_init(void)
 
 	case 0x17:
 	case 0x18:
+	case 0x19:
 		pr_warn_once("Decoding supported only on Scalable MCA processors.\n");
 		return -EINVAL;
 
-- 
1.8.3.1

Re: [PATCH] EDAC/mce_amd: Print !SMCA processor warning for 0x19 family

[Borislav Petkov]

On Wed, Apr 28, 2021 at 11:15:06AM +0800, Kaige Fu wrote:
> KVM doesn't enable SMCA for 0x19 family AMD processors.
> Consequently, a warning as following will be print when load
> edac_mce_amd.ko in a virtual machine.
> 
> "Huh? What family is it: 0x19?!"
> 
> To make the log more clear, this patch prints !SMCA processor
> warning for 0x19 family.

This doesn't make it more clear - it replaces one incorrect statement
with another.

You can simply ignore it or not load that module in a guest at all.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/mce_amd: Print !SMCA processor warning for 0x19 family

[Kaige Fu]

Hi Borislav, thanks for your comment.


在 2021/4/28 下午5:06, Borislav Petkov 写道:
> On Wed, Apr 28, 2021 at 11:15:06AM +0800, Kaige Fu wrote:
>> KVM doesn't enable SMCA for 0x19 family AMD processors.
>> Consequently, a warning as following will be print when load
>> edac_mce_amd.ko in a virtual machine.
>>
>> "Huh? What family is it: 0x19?!"
>>
>> To make the log more clear, this patch prints !SMCA processor
>> warning for 0x19 family.
> 
> This doesn't make it more clear - it replaces one incorrect statement
> with another.
> 
> You can simply ignore it or not load that module in a guest at all.
>