* [PATCH] EDAC/amd64: fix typo in a comment
@ 2021-12-12 3:26 Jason Wang
2021-12-12 11:48 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2021-12-12 3:26 UTC (permalink / raw)
To: bp
Cc: yazen.ghannam, mchehab, tony.luck, james.morse, rric, linux-edac,
linux-kernel, Jason Wang
The double `reads' in the comment in line 126 is repeated. Remove one
of them from the comment.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/edac/amd64_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index ca0c67bc25c6..dff6469e9f67 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -123,7 +123,7 @@ static inline int amd64_read_dct_pci_cfg(struct amd64_pvt *pvt, u8 dct,
if (dct) {
/*
* Note: If ganging is enabled, barring the regs
- * F2x[1,0]98 and F2x[1,0]9C; reads reads to F2x1xx
+ * F2x[1,0]98 and F2x[1,0]9C; reads to F2x1xx
* return 0. (cf. Section 2.8.1 F10h BKDG)
*/
if (dct_ganging_enabled(pvt))
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC/amd64: fix typo in a comment
2021-12-12 3:26 [PATCH] EDAC/amd64: fix typo in a comment Jason Wang
@ 2021-12-12 11:48 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2021-12-12 11:48 UTC (permalink / raw)
To: Jason Wang
Cc: yazen.ghannam, mchehab, tony.luck, james.morse, rric, linux-edac,
linux-kernel
On Sun, Dec 12, 2021 at 11:26:53AM +0800, Jason Wang wrote:
> The double `reads' in the comment in line 126 is repeated. Remove one
> of them from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/edac/amd64_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
If you're going to waste your time fixing comments, then please fix your
commit message like I did for your previous patch:
https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=b011a57e41ccbd402ecdcb53514ba76b898ec22e
And then I'd strongly suggest you try fixing real bugs - there's no
shortage of those - instead of wasting your and others' time with
comments fixes. Those can be addressed when someone is changing the code
in that area too.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-12 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-12 3:26 [PATCH] EDAC/amd64: fix typo in a comment Jason Wang
2021-12-12 11:48 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).