From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Troy Lee" <troy_lee@aspeedtech.com>, "Joel Stanley" <joel@jms.id.au>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, "Tony Luck" <tony.luck@intel.com>,
"Ryan Chen" <ryan_chen@aspeedtech.com>,
"James Morse" <james.morse@arm.com>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Robert Richter" <rrichter@marvell.com>,
"leetroy@gmail.com" <leetroy@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Stefan M Schaeckeler" <sschaeck@cisco.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver
Date: Thu, 03 Dec 2020 01:32:44 +1030 [thread overview]
Message-ID: <b6dd3a91-abe7-4e9d-b801-6e54e4c88827@www.fastmail.com> (raw)
In-Reply-To: <PS1PR06MB26008E4BCB805553EDEC45038AF30@PS1PR06MB2600.apcprd06.prod.outlook.com>
On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote:
> Hi Joel,
>
> Thanks for the suggestion, I'll fix the review and create an new patch
> against
> latest Linux branch. Those exported function will be referenced in
> other driver yet
> to be upstream, so should I move those exported functions out of this
> patch?
>
Yes, let's leave the exports out of this patch, and add them in when you send
the patch that depends on them.
Andrew
next prev parent reply other threads:[~2020-12-02 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 6:36 [PATCH v2 1/3] dt-bindings: edac: aspeed-sdram-edac: Add ast2400/ast2600 support Troy Lee
2020-12-02 6:36 ` [PATCH v2 2/3] ARM: dts: aspeed: Add AST2600 edac into common devicetree Troy Lee
2020-12-02 7:02 ` Joel Stanley
2020-12-02 6:36 ` [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver Troy Lee
2020-12-02 7:01 ` Joel Stanley
2020-12-02 8:41 ` Troy Lee
2020-12-02 15:02 ` Andrew Jeffery [this message]
2020-12-02 18:23 ` Borislav Petkov
2020-12-03 1:27 ` Troy Lee
2020-12-03 7:20 ` Borislav Petkov
2020-12-02 6:40 ` [PATCH v2 1/3] dt-bindings: edac: aspeed-sdram-edac: Add ast2400/ast2600 support Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6dd3a91-abe7-4e9d-b801-6e54e4c88827@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rrichter@marvell.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sschaeck@cisco.com \
--cc=tony.luck@intel.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).