linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next v2] staging: comedi: Remove unused variable ‘min_full_scale’ and function 'get_min_full_scales'
@ 2021-05-14  4:35 Bixuan Cui
  2021-05-14  7:01 ` Borislav Petkov
  0 siblings, 1 reply; 3+ messages in thread
From: Bixuan Cui @ 2021-05-14  4:35 UTC (permalink / raw)
  To: bp; +Cc: kristo, mchehab, tony.luck, linux-edac, kernel-janitors

The variable ‘min_full_scale’ and function 'get_min_full_scales' are
not used, So delete them.

Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
Changes from v2:
* Delete function 'get_min_full_scales'

 drivers/comedi/drivers/jr3_pci.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/comedi/drivers/jr3_pci.c b/drivers/comedi/drivers/jr3_pci.c
index 7a02c4fa3cda..f963080dd61f 100644
--- a/drivers/comedi/drivers/jr3_pci.c
+++ b/drivers/comedi/drivers/jr3_pci.c
@@ -186,19 +186,6 @@ static void set_full_scales(struct jr3_sensor __iomem *sensor,
 	set_s16(&sensor->command_word0, 0x0a00);
 }
 
-static struct six_axis_t get_min_full_scales(struct jr3_sensor __iomem *sensor)
-{
-	struct six_axis_t result;
-
-	result.fx = get_s16(&sensor->min_full_scale.fx);
-	result.fy = get_s16(&sensor->min_full_scale.fy);
-	result.fz = get_s16(&sensor->min_full_scale.fz);
-	result.mx = get_s16(&sensor->min_full_scale.mx);
-	result.my = get_s16(&sensor->min_full_scale.my);
-	result.mz = get_s16(&sensor->min_full_scale.mz);
-	return result;
-}
-
 static struct six_axis_t get_max_full_scales(struct jr3_sensor __iomem *sensor)
 {
 	struct six_axis_t result;
@@ -504,10 +491,8 @@ jr3_pci_poll_subdevice(struct comedi_subdevice *s)
 			result = poll_delay_min_max(20, 100);
 		} else {
 			/* Set full scale */
-			struct six_axis_t min_full_scale;
 			struct six_axis_t max_full_scale;
 
-			min_full_scale = get_min_full_scales(sensor);
 			max_full_scale = get_max_full_scales(sensor);
 			set_full_scales(sensor, max_full_scale);
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next v2] staging: comedi: Remove unused variable ‘min_full_scale’ and function 'get_min_full_scales'
  2021-05-14  4:35 [PATCH -next v2] staging: comedi: Remove unused variable ‘min_full_scale’ and function 'get_min_full_scales' Bixuan Cui
@ 2021-05-14  7:01 ` Borislav Petkov
  2021-05-14  7:27   ` Bixuan Cui
  0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-05-14  7:01 UTC (permalink / raw)
  To: Bixuan Cui; +Cc: kristo, mchehab, tony.luck, linux-edac, kernel-janitors

On Fri, May 14, 2021 at 12:35:39PM +0800, Bixuan Cui wrote:
> The variable ‘min_full_scale’ and function 'get_min_full_scales' are
> not used, So delete them.
> 
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> Changes from v2:
> * Delete function 'get_min_full_scales'
> 
>  drivers/comedi/drivers/jr3_pci.c | 15 ---------------

You shouldn't wonder when you don't get a proper reply with that Cc
list:

./scripts/get_maintainer.pl -f drivers/comedi/drivers/jr3_pci.c
Ian Abbott <abbotti@mev.co.uk> (odd fixer:COMEDI DRIVERS)
H Hartley Sweeten <hsweeten@visionengravers.com> (odd fixer:COMEDI DRIVERS)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:2/2=100%,authored:1/2=50%)
"Alexander A. Klimov" <grandmaster@al2klimov.de> (commit_signer:1/2=50%,authored:1/2=50%)
linux-kernel@vger.kernel.org (open list)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next v2] staging: comedi: Remove unused variable ‘min_full_scale’ and function 'get_min_full_scales'
  2021-05-14  7:01 ` Borislav Petkov
@ 2021-05-14  7:27   ` Bixuan Cui
  0 siblings, 0 replies; 3+ messages in thread
From: Bixuan Cui @ 2021-05-14  7:27 UTC (permalink / raw)
  To: Borislav Petkov; +Cc: kristo, mchehab, tony.luck, linux-edac, kernel-janitors



On 2021/5/14 15:01, Borislav Petkov wrote:
> You shouldn't wonder when you don't get a proper reply with that Cc
> list:
> 
> ./scripts/get_maintainer.pl -f drivers/comedi/drivers/jr3_pci.c
> Ian Abbott <abbotti@mev.co.uk> (odd fixer:COMEDI DRIVERS)
> H Hartley Sweeten <hsweeten@visionengravers.com> (odd fixer:COMEDI DRIVERS)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:2/2=100%,authored:1/2=50%)
> "Alexander A. Klimov" <grandmaster@al2klimov.de> (commit_signer:1/2=50%,authored:1/2=50%)
> linux-kernel@vger.kernel.org (open list)

Thank you for your reminder, this is my mistake :-(

Thanks
Bixuan Cui

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-14  7:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14  4:35 [PATCH -next v2] staging: comedi: Remove unused variable ‘min_full_scale’ and function 'get_min_full_scales' Bixuan Cui
2021-05-14  7:01 ` Borislav Petkov
2021-05-14  7:27   ` Bixuan Cui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).