* [GIT PULL 0/5] EFI urgent fixes @ 2016-02-12 11:27 Matt Fleming 2016-02-12 11:27 ` [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version Matt Fleming ` (4 more replies) 0 siblings, 5 replies; 15+ messages in thread From: Matt Fleming @ 2016-02-12 11:27 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Matt Fleming, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Lee, Chun-Yi, Matthew Garrett, Peter Jones Folks, Please pull the following EFI patches from Peter that prevent accidental deletion of EFI variables through efivarfs which can lead to bricked machines. These obviously need backporting to stable, so I'll take care of sending the backports separately because we don't need to send the entire 5 patch series. The following changes since commit 59fd1214561921343305a0e9dc218bf3d40068f3: x86/mm/numa: Fix 32-bit memblock range truncation bug on 32-bit NUMA kernels (2016-02-08 12:10:03 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-urgent for you to fetch changes up to ed8b0de5a33d2a2557dce7f9429dca8cb5bc5879: efi: Make efivarfs entries immutable by default (2016-02-10 16:25:52 +0000) ---------------------------------------------------------------- * Prevent accidental deletion of EFI variables through efivarfs that may brick machines. We use a whitelist of known-safe variables to allow things like installing distributions to work out of the box, and instead restrict vendor-specific variable deletion by making non-whitelist variables immutable - Peter Jones ---------------------------------------------------------------- Peter Jones (5): lib/ucs2_string: Add ucs2 -> utf8 helper functions efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version efi: Do variable name validation tests in utf8 efi: Make our variable validation list include the guid efi: Make efivarfs entries immutable by default Documentation/filesystems/efivarfs.txt | 7 ++ drivers/firmware/efi/efivars.c | 35 +++--- drivers/firmware/efi/vars.c | 143 ++++++++++++++++++------- fs/efivarfs/file.c | 70 ++++++++++++ fs/efivarfs/inode.c | 30 ++++-- fs/efivarfs/internal.h | 3 +- fs/efivarfs/super.c | 16 +-- include/linux/efi.h | 5 +- include/linux/ucs2_string.h | 4 + lib/ucs2_string.c | 62 +++++++++++ tools/testing/selftests/efivarfs/efivarfs.sh | 19 +++- tools/testing/selftests/efivarfs/open-unlink.c | 72 ++++++++++++- 12 files changed, 383 insertions(+), 83 deletions(-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version 2016-02-12 11:27 [GIT PULL 0/5] EFI urgent fixes Matt Fleming @ 2016-02-12 11:27 ` Matt Fleming [not found] ` <1455276432-9931-3-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> [not found] ` <1455276432-9931-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> ` (3 subsequent siblings) 4 siblings, 1 reply; 15+ messages in thread From: Matt Fleming @ 2016-02-12 11:27 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Peter Jones, linux-kernel, linux-efi, Matt Fleming, Lee, Chun-Yi, Matthew Garrett From: Peter Jones <pjones@redhat.com> Translate EFI's UCS-2 variable names to UTF-8 instead of just assuming all variable names fit in ASCII. Signed-off-by: Peter Jones <pjones@redhat.com> Acked-by: Matthew Garrett <mjg59@coreos.com> Tested-by: "Lee, Chun-Yi" <jlee@suse.com> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> --- drivers/firmware/efi/efivars.c | 30 +++++++++++------------------- fs/efivarfs/super.c | 7 +++---- 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c index 756eca8c4cf8..f4ff8abc5f3e 100644 --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -540,38 +540,30 @@ static ssize_t efivar_delete(struct file *filp, struct kobject *kobj, static int efivar_create_sysfs_entry(struct efivar_entry *new_var) { - int i, short_name_size; + int short_name_size; char *short_name; - unsigned long variable_name_size; - efi_char16_t *variable_name; + unsigned long utf8_name_size; + efi_char16_t *variable_name = new_var->var.VariableName; int ret; - variable_name = new_var->var.VariableName; - variable_name_size = ucs2_strlen(variable_name) * sizeof(efi_char16_t); - /* - * Length of the variable bytes in ASCII, plus the '-' separator, + * Length of the variable bytes in UTF8, plus the '-' separator, * plus the GUID, plus trailing NUL */ - short_name_size = variable_name_size / sizeof(efi_char16_t) - + 1 + EFI_VARIABLE_GUID_LEN + 1; - - short_name = kzalloc(short_name_size, GFP_KERNEL); + utf8_name_size = ucs2_utf8size(variable_name); + short_name_size = utf8_name_size + 1 + EFI_VARIABLE_GUID_LEN + 1; + short_name = kmalloc(short_name_size, GFP_KERNEL); if (!short_name) return -ENOMEM; - /* Convert Unicode to normal chars (assume top bits are 0), - ala UTF-8 */ - for (i=0; i < (int)(variable_name_size / sizeof(efi_char16_t)); i++) { - short_name[i] = variable_name[i] & 0xFF; - } + ucs2_as_utf8(short_name, variable_name, short_name_size); + /* This is ugly, but necessary to separate one vendor's private variables from another's. */ - - *(short_name + strlen(short_name)) = '-'; + short_name[utf8_name_size] = '-'; efi_guid_to_str(&new_var->var.VendorGuid, - short_name + strlen(short_name)); + short_name + utf8_name_size + 1); new_var->kobj.kset = efivars_kset; diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c index b8a564f29107..8651ac28ec0d 100644 --- a/fs/efivarfs/super.c +++ b/fs/efivarfs/super.c @@ -118,7 +118,7 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor, struct dentry *dentry, *root = sb->s_root; unsigned long size = 0; char *name; - int len, i; + int len; int err = -ENOMEM; entry = kzalloc(sizeof(*entry), GFP_KERNEL); @@ -128,15 +128,14 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor, memcpy(entry->var.VariableName, name16, name_size); memcpy(&(entry->var.VendorGuid), &vendor, sizeof(efi_guid_t)); - len = ucs2_strlen(entry->var.VariableName); + len = ucs2_utf8size(entry->var.VariableName); /* name, plus '-', plus GUID, plus NUL*/ name = kmalloc(len + 1 + EFI_VARIABLE_GUID_LEN + 1, GFP_KERNEL); if (!name) goto fail; - for (i = 0; i < len; i++) - name[i] = entry->var.VariableName[i] & 0xFF; + ucs2_as_utf8(name, entry->var.VariableName, len); name[len] = '-'; -- 2.6.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1455276432-9931-3-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]
* Re: [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version [not found] ` <1455276432-9931-3-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> @ 2016-02-18 5:34 ` H. Peter Anvin [not found] ` <12473B1F-5227-4E83-BAF9-06B69CF74D77-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: H. Peter Anvin @ 2016-02-18 5:34 UTC (permalink / raw) To: Matt Fleming, Ingo Molnar, Thomas Gleixner Cc: Ard Biesheuvel, Peter Jones, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Lee, Chun-Yi, Matthew Garrett On February 12, 2016 3:27:09 AM PST, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote: >From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > >Translate EFI's UCS-2 variable names to UTF-8 instead of just assuming >all variable names fit in ASCII. > >Signed-off-by: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >Acked-by: Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> >Tested-by: "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org> >Signed-off-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> >--- > drivers/firmware/efi/efivars.c | 30 +++++++++++------------------- > fs/efivarfs/super.c | 7 +++---- > 2 files changed, 14 insertions(+), 23 deletions(-) > >diff --git a/drivers/firmware/efi/efivars.c >b/drivers/firmware/efi/efivars.c >index 756eca8c4cf8..f4ff8abc5f3e 100644 >--- a/drivers/firmware/efi/efivars.c >+++ b/drivers/firmware/efi/efivars.c >@@ -540,38 +540,30 @@ static ssize_t efivar_delete(struct file *filp, >struct kobject *kobj, > static int > efivar_create_sysfs_entry(struct efivar_entry *new_var) > { >- int i, short_name_size; >+ int short_name_size; > char *short_name; >- unsigned long variable_name_size; >- efi_char16_t *variable_name; >+ unsigned long utf8_name_size; >+ efi_char16_t *variable_name = new_var->var.VariableName; > int ret; > >- variable_name = new_var->var.VariableName; >- variable_name_size = ucs2_strlen(variable_name) * >sizeof(efi_char16_t); >- > /* >- * Length of the variable bytes in ASCII, plus the '-' separator, >+ * Length of the variable bytes in UTF8, plus the '-' separator, > * plus the GUID, plus trailing NUL > */ >- short_name_size = variable_name_size / sizeof(efi_char16_t) >- + 1 + EFI_VARIABLE_GUID_LEN + 1; >- >- short_name = kzalloc(short_name_size, GFP_KERNEL); >+ utf8_name_size = ucs2_utf8size(variable_name); >+ short_name_size = utf8_name_size + 1 + EFI_VARIABLE_GUID_LEN + 1; > >+ short_name = kmalloc(short_name_size, GFP_KERNEL); > if (!short_name) > return -ENOMEM; > >- /* Convert Unicode to normal chars (assume top bits are 0), >- ala UTF-8 */ >- for (i=0; i < (int)(variable_name_size / sizeof(efi_char16_t)); i++) >{ >- short_name[i] = variable_name[i] & 0xFF; >- } >+ ucs2_as_utf8(short_name, variable_name, short_name_size); >+ > /* This is ugly, but necessary to separate one vendor's > private variables from another's. */ >- >- *(short_name + strlen(short_name)) = '-'; >+ short_name[utf8_name_size] = '-'; > efi_guid_to_str(&new_var->var.VendorGuid, >- short_name + strlen(short_name)); >+ short_name + utf8_name_size + 1); > > new_var->kobj.kset = efivars_kset; > >diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c >index b8a564f29107..8651ac28ec0d 100644 >--- a/fs/efivarfs/super.c >+++ b/fs/efivarfs/super.c >@@ -118,7 +118,7 @@ static int efivarfs_callback(efi_char16_t *name16, >efi_guid_t vendor, > struct dentry *dentry, *root = sb->s_root; > unsigned long size = 0; > char *name; >- int len, i; >+ int len; > int err = -ENOMEM; > > entry = kzalloc(sizeof(*entry), GFP_KERNEL); >@@ -128,15 +128,14 @@ static int efivarfs_callback(efi_char16_t >*name16, efi_guid_t vendor, > memcpy(entry->var.VariableName, name16, name_size); > memcpy(&(entry->var.VendorGuid), &vendor, sizeof(efi_guid_t)); > >- len = ucs2_strlen(entry->var.VariableName); >+ len = ucs2_utf8size(entry->var.VariableName); > > /* name, plus '-', plus GUID, plus NUL*/ > name = kmalloc(len + 1 + EFI_VARIABLE_GUID_LEN + 1, GFP_KERNEL); > if (!name) > goto fail; > >- for (i = 0; i < len; i++) >- name[i] = entry->var.VariableName[i] & 0xFF; >+ ucs2_as_utf8(name, entry->var.VariableName, len); > > name[len] = '-'; > However, I think we should treat this "ucs2" as utf16, because sooner or later someone will enter utf16 characters. -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting. ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <12473B1F-5227-4E83-BAF9-06B69CF74D77-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version [not found] ` <12473B1F-5227-4E83-BAF9-06B69CF74D77-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> @ 2016-02-18 6:09 ` Matthew Garrett [not found] ` <CAPeXnHuoQgrz1-_zkBKcskNE24jK2L5DSyWjbBoU+ceVzGZe0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Matthew Garrett @ 2016-02-18 6:09 UTC (permalink / raw) To: H. Peter Anvin Cc: Matt Fleming, Ingo Molnar, Thomas Gleixner, Ard Biesheuvel, Peter Jones, linux-efi-u79uwXL29TY76Z2rM5mHXA, Lee, Chun-Yi If we're worried about UTF-16, the appropriate thing for us to do is error on seeing a surrogate pair. On Wed, Feb 17, 2016 at 9:34 PM, H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> wrote: > On February 12, 2016 3:27:09 AM PST, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote: >>From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >> >>Translate EFI's UCS-2 variable names to UTF-8 instead of just assuming >>all variable names fit in ASCII. >> >>Signed-off-by: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>Acked-by: Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> >>Tested-by: "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org> >>Signed-off-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> >>--- >> drivers/firmware/efi/efivars.c | 30 +++++++++++------------------- >> fs/efivarfs/super.c | 7 +++---- >> 2 files changed, 14 insertions(+), 23 deletions(-) >> >>diff --git a/drivers/firmware/efi/efivars.c >>b/drivers/firmware/efi/efivars.c >>index 756eca8c4cf8..f4ff8abc5f3e 100644 >>--- a/drivers/firmware/efi/efivars.c >>+++ b/drivers/firmware/efi/efivars.c >>@@ -540,38 +540,30 @@ static ssize_t efivar_delete(struct file *filp, >>struct kobject *kobj, >> static int >> efivar_create_sysfs_entry(struct efivar_entry *new_var) >> { >>- int i, short_name_size; >>+ int short_name_size; >> char *short_name; >>- unsigned long variable_name_size; >>- efi_char16_t *variable_name; >>+ unsigned long utf8_name_size; >>+ efi_char16_t *variable_name = new_var->var.VariableName; >> int ret; >> >>- variable_name = new_var->var.VariableName; >>- variable_name_size = ucs2_strlen(variable_name) * >>sizeof(efi_char16_t); >>- >> /* >>- * Length of the variable bytes in ASCII, plus the '-' separator, >>+ * Length of the variable bytes in UTF8, plus the '-' separator, >> * plus the GUID, plus trailing NUL >> */ >>- short_name_size = variable_name_size / sizeof(efi_char16_t) >>- + 1 + EFI_VARIABLE_GUID_LEN + 1; >>- >>- short_name = kzalloc(short_name_size, GFP_KERNEL); >>+ utf8_name_size = ucs2_utf8size(variable_name); >>+ short_name_size = utf8_name_size + 1 + EFI_VARIABLE_GUID_LEN + 1; >> >>+ short_name = kmalloc(short_name_size, GFP_KERNEL); >> if (!short_name) >> return -ENOMEM; >> >>- /* Convert Unicode to normal chars (assume top bits are 0), >>- ala UTF-8 */ >>- for (i=0; i < (int)(variable_name_size / sizeof(efi_char16_t)); i++) >>{ >>- short_name[i] = variable_name[i] & 0xFF; >>- } >>+ ucs2_as_utf8(short_name, variable_name, short_name_size); >>+ >> /* This is ugly, but necessary to separate one vendor's >> private variables from another's. */ >>- >>- *(short_name + strlen(short_name)) = '-'; >>+ short_name[utf8_name_size] = '-'; >> efi_guid_to_str(&new_var->var.VendorGuid, >>- short_name + strlen(short_name)); >>+ short_name + utf8_name_size + 1); >> >> new_var->kobj.kset = efivars_kset; >> >>diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c >>index b8a564f29107..8651ac28ec0d 100644 >>--- a/fs/efivarfs/super.c >>+++ b/fs/efivarfs/super.c >>@@ -118,7 +118,7 @@ static int efivarfs_callback(efi_char16_t *name16, >>efi_guid_t vendor, >> struct dentry *dentry, *root = sb->s_root; >> unsigned long size = 0; >> char *name; >>- int len, i; >>+ int len; >> int err = -ENOMEM; >> >> entry = kzalloc(sizeof(*entry), GFP_KERNEL); >>@@ -128,15 +128,14 @@ static int efivarfs_callback(efi_char16_t >>*name16, efi_guid_t vendor, >> memcpy(entry->var.VariableName, name16, name_size); >> memcpy(&(entry->var.VendorGuid), &vendor, sizeof(efi_guid_t)); >> >>- len = ucs2_strlen(entry->var.VariableName); >>+ len = ucs2_utf8size(entry->var.VariableName); >> >> /* name, plus '-', plus GUID, plus NUL*/ >> name = kmalloc(len + 1 + EFI_VARIABLE_GUID_LEN + 1, GFP_KERNEL); >> if (!name) >> goto fail; >> >>- for (i = 0; i < len; i++) >>- name[i] = entry->var.VariableName[i] & 0xFF; >>+ ucs2_as_utf8(name, entry->var.VariableName, len); >> >> name[len] = '-'; >> > > However, I think we should treat this "ucs2" as utf16, because sooner or later someone will enter utf16 characters. > -- > Sent from my Android device with K-9 Mail. Please excuse brevity and formatting. ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <CAPeXnHuoQgrz1-_zkBKcskNE24jK2L5DSyWjbBoU+ceVzGZe0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version [not found] ` <CAPeXnHuoQgrz1-_zkBKcskNE24jK2L5DSyWjbBoU+ceVzGZe0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-02-18 9:36 ` H. Peter Anvin 0 siblings, 0 replies; 15+ messages in thread From: H. Peter Anvin @ 2016-02-18 9:36 UTC (permalink / raw) To: Matthew Garrett Cc: Matt Fleming, Ingo Molnar, Thomas Gleixner, Ard Biesheuvel, Peter Jones, linux-efi-u79uwXL29TY76Z2rM5mHXA, Lee, Chun-Yi On February 17, 2016 10:09:29 PM PST, Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> wrote: >If we're worried about UTF-16, the appropriate thing for us to do is >error on seeing a surrogate pair. > >On Wed, Feb 17, 2016 at 9:34 PM, H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> wrote: >> On February 12, 2016 3:27:09 AM PST, Matt Fleming ><matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote: >>>From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>> >>>Translate EFI's UCS-2 variable names to UTF-8 instead of just >assuming >>>all variable names fit in ASCII. >>> >>>Signed-off-by: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>>Acked-by: Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> >>>Tested-by: "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org> >>>Signed-off-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> >>>--- >>> drivers/firmware/efi/efivars.c | 30 +++++++++++------------------- >>> fs/efivarfs/super.c | 7 +++---- >>> 2 files changed, 14 insertions(+), 23 deletions(-) >>> >>>diff --git a/drivers/firmware/efi/efivars.c >>>b/drivers/firmware/efi/efivars.c >>>index 756eca8c4cf8..f4ff8abc5f3e 100644 >>>--- a/drivers/firmware/efi/efivars.c >>>+++ b/drivers/firmware/efi/efivars.c >>>@@ -540,38 +540,30 @@ static ssize_t efivar_delete(struct file *filp, >>>struct kobject *kobj, >>> static int >>> efivar_create_sysfs_entry(struct efivar_entry *new_var) >>> { >>>- int i, short_name_size; >>>+ int short_name_size; >>> char *short_name; >>>- unsigned long variable_name_size; >>>- efi_char16_t *variable_name; >>>+ unsigned long utf8_name_size; >>>+ efi_char16_t *variable_name = new_var->var.VariableName; >>> int ret; >>> >>>- variable_name = new_var->var.VariableName; >>>- variable_name_size = ucs2_strlen(variable_name) * >>>sizeof(efi_char16_t); >>>- >>> /* >>>- * Length of the variable bytes in ASCII, plus the '-' >separator, >>>+ * Length of the variable bytes in UTF8, plus the '-' >separator, >>> * plus the GUID, plus trailing NUL >>> */ >>>- short_name_size = variable_name_size / sizeof(efi_char16_t) >>>- + 1 + EFI_VARIABLE_GUID_LEN + 1; >>>- >>>- short_name = kzalloc(short_name_size, GFP_KERNEL); >>>+ utf8_name_size = ucs2_utf8size(variable_name); >>>+ short_name_size = utf8_name_size + 1 + EFI_VARIABLE_GUID_LEN + >1; >>> >>>+ short_name = kmalloc(short_name_size, GFP_KERNEL); >>> if (!short_name) >>> return -ENOMEM; >>> >>>- /* Convert Unicode to normal chars (assume top bits are 0), >>>- ala UTF-8 */ >>>- for (i=0; i < (int)(variable_name_size / >sizeof(efi_char16_t)); i++) >>>{ >>>- short_name[i] = variable_name[i] & 0xFF; >>>- } >>>+ ucs2_as_utf8(short_name, variable_name, short_name_size); >>>+ >>> /* This is ugly, but necessary to separate one vendor's >>> private variables from another's. */ >>>- >>>- *(short_name + strlen(short_name)) = '-'; >>>+ short_name[utf8_name_size] = '-'; >>> efi_guid_to_str(&new_var->var.VendorGuid, >>>- short_name + strlen(short_name)); >>>+ short_name + utf8_name_size + 1); >>> >>> new_var->kobj.kset = efivars_kset; >>> >>>diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c >>>index b8a564f29107..8651ac28ec0d 100644 >>>--- a/fs/efivarfs/super.c >>>+++ b/fs/efivarfs/super.c >>>@@ -118,7 +118,7 @@ static int efivarfs_callback(efi_char16_t >*name16, >>>efi_guid_t vendor, >>> struct dentry *dentry, *root = sb->s_root; >>> unsigned long size = 0; >>> char *name; >>>- int len, i; >>>+ int len; >>> int err = -ENOMEM; >>> >>> entry = kzalloc(sizeof(*entry), GFP_KERNEL); >>>@@ -128,15 +128,14 @@ static int efivarfs_callback(efi_char16_t >>>*name16, efi_guid_t vendor, >>> memcpy(entry->var.VariableName, name16, name_size); >>> memcpy(&(entry->var.VendorGuid), &vendor, sizeof(efi_guid_t)); >>> >>>- len = ucs2_strlen(entry->var.VariableName); >>>+ len = ucs2_utf8size(entry->var.VariableName); >>> >>> /* name, plus '-', plus GUID, plus NUL*/ >>> name = kmalloc(len + 1 + EFI_VARIABLE_GUID_LEN + 1, >GFP_KERNEL); >>> if (!name) >>> goto fail; >>> >>>- for (i = 0; i < len; i++) >>>- name[i] = entry->var.VariableName[i] & 0xFF; >>>+ ucs2_as_utf8(name, entry->var.VariableName, len); >>> >>> name[len] = '-'; >>> >> >> However, I think we should treat this "ucs2" as utf16, because sooner >or later someone will enter utf16 characters. >> -- >> Sent from my Android device with K-9 Mail. Please excuse brevity and >formatting. Error how? Now you're making something in EFI memory inaccessible for no good reason. Most likely utf16 works just fine except when being displayed on the EFI console. -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting. ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <1455276432-9931-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]
* [PATCH 1/5] lib/ucs2_string: Add ucs2 -> utf8 helper functions [not found] ` <1455276432-9931-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> @ 2016-02-12 11:27 ` Matt Fleming 2016-02-12 11:27 ` [PATCH 3/5] efi: Do variable name validation tests in utf8 Matt Fleming 1 sibling, 0 replies; 15+ messages in thread From: Matt Fleming @ 2016-02-12 11:27 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Peter Jones, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Matt Fleming, Lee, Chun-Yi, Matthew Garrett From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> This adds ucs2_utf8size(), which tells us how big our ucs2 string is in bytes, and ucs2_as_utf8, which translates from ucs2 to utf8.. Signed-off-by: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Tested-by: "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org> Acked-by: Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> Signed-off-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> --- include/linux/ucs2_string.h | 4 +++ lib/ucs2_string.c | 62 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+) diff --git a/include/linux/ucs2_string.h b/include/linux/ucs2_string.h index cbb20afdbc01..bb679b48f408 100644 --- a/include/linux/ucs2_string.h +++ b/include/linux/ucs2_string.h @@ -11,4 +11,8 @@ unsigned long ucs2_strlen(const ucs2_char_t *s); unsigned long ucs2_strsize(const ucs2_char_t *data, unsigned long maxlength); int ucs2_strncmp(const ucs2_char_t *a, const ucs2_char_t *b, size_t len); +unsigned long ucs2_utf8size(const ucs2_char_t *src); +unsigned long ucs2_as_utf8(u8 *dest, const ucs2_char_t *src, + unsigned long maxlength); + #endif /* _LINUX_UCS2_STRING_H_ */ diff --git a/lib/ucs2_string.c b/lib/ucs2_string.c index 6f500ef2301d..17dd74e21ef9 100644 --- a/lib/ucs2_string.c +++ b/lib/ucs2_string.c @@ -49,3 +49,65 @@ ucs2_strncmp(const ucs2_char_t *a, const ucs2_char_t *b, size_t len) } } EXPORT_SYMBOL(ucs2_strncmp); + +unsigned long +ucs2_utf8size(const ucs2_char_t *src) +{ + unsigned long i; + unsigned long j = 0; + + for (i = 0; i < ucs2_strlen(src); i++) { + u16 c = src[i]; + + if (c > 0x800) + j += 3; + else if (c > 0x80) + j += 2; + else + j += 1; + } + + return j; +} +EXPORT_SYMBOL(ucs2_utf8size); + +/* + * copy at most maxlength bytes of whole utf8 characters to dest from the + * ucs2 string src. + * + * The return value is the number of characters copied, not including the + * final NUL character. + */ +unsigned long +ucs2_as_utf8(u8 *dest, const ucs2_char_t *src, unsigned long maxlength) +{ + unsigned int i; + unsigned long j = 0; + unsigned long limit = ucs2_strnlen(src, maxlength); + + for (i = 0; maxlength && i < limit; i++) { + u16 c = src[i]; + + if (c > 0x800) { + if (maxlength < 3) + break; + maxlength -= 3; + dest[j++] = 0xe0 | (c & 0xf000) >> 12; + dest[j++] = 0x80 | (c & 0x0fc0) >> 8; + dest[j++] = 0x80 | (c & 0x003f); + } else if (c > 0x80) { + if (maxlength < 2) + break; + maxlength -= 2; + dest[j++] = 0xc0 | (c & 0xfe0) >> 5; + dest[j++] = 0x80 | (c & 0x01f); + } else { + maxlength -= 1; + dest[j++] = c & 0x7f; + } + } + if (maxlength) + dest[j] = '\0'; + return j; +} +EXPORT_SYMBOL(ucs2_as_utf8); -- 2.6.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/5] efi: Do variable name validation tests in utf8 [not found] ` <1455276432-9931-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 2016-02-12 11:27 ` [PATCH 1/5] lib/ucs2_string: Add ucs2 -> utf8 helper functions Matt Fleming @ 2016-02-12 11:27 ` Matt Fleming 1 sibling, 0 replies; 15+ messages in thread From: Matt Fleming @ 2016-02-12 11:27 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Peter Jones, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Matt Fleming, Lee, Chun-Yi, Matthew Garrett From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Actually translate from ucs2 to utf8 before doing the test, and then test against our other utf8 data, instead of fudging it. Signed-off-by: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Acked-by: Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> Tested-by: "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org> Signed-off-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> --- drivers/firmware/efi/vars.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c index 70a0fb10517f..5c5fde3e6c37 100644 --- a/drivers/firmware/efi/vars.c +++ b/drivers/firmware/efi/vars.c @@ -189,10 +189,19 @@ static const struct variable_validate variable_validate[] = { }; bool -efivar_validate(efi_char16_t *var_name, u8 *data, unsigned long len) +efivar_validate(efi_char16_t *var_name, u8 *data, unsigned long data_size) { int i; - u16 *unicode_name = var_name; + unsigned long utf8_size; + u8 *utf8_name; + + utf8_size = ucs2_utf8size(var_name); + utf8_name = kmalloc(utf8_size + 1, GFP_KERNEL); + if (!utf8_name) + return false; + + ucs2_as_utf8(utf8_name, var_name, utf8_size); + utf8_name[utf8_size] = '\0'; for (i = 0; variable_validate[i].validate != NULL; i++) { const char *name = variable_validate[i].name; @@ -200,28 +209,29 @@ efivar_validate(efi_char16_t *var_name, u8 *data, unsigned long len) for (match = 0; ; match++) { char c = name[match]; - u16 u = unicode_name[match]; - - /* All special variables are plain ascii */ - if (u > 127) - return true; + char u = utf8_name[match]; /* Wildcard in the matching name means we've matched */ - if (c == '*') + if (c == '*') { + kfree(utf8_name); return variable_validate[i].validate(var_name, - match, data, len); + match, data, data_size); + } /* Case sensitive match */ if (c != u) break; /* Reached the end of the string while matching */ - if (!c) + if (!c) { + kfree(utf8_name); return variable_validate[i].validate(var_name, - match, data, len); + match, data, data_size); + } } } + kfree(utf8_name); return true; } EXPORT_SYMBOL_GPL(efivar_validate); -- 2.6.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/5] efi: Make our variable validation list include the guid 2016-02-12 11:27 [GIT PULL 0/5] EFI urgent fixes Matt Fleming 2016-02-12 11:27 ` [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version Matt Fleming [not found] ` <1455276432-9931-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> @ 2016-02-12 11:27 ` Matt Fleming 2016-02-12 11:27 ` [PATCH 5/5] efi: Make efivarfs entries immutable by default Matt Fleming 2016-02-16 12:15 ` [GIT PULL 0/5] EFI urgent fixes Ingo Molnar 4 siblings, 0 replies; 15+ messages in thread From: Matt Fleming @ 2016-02-12 11:27 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Peter Jones, linux-kernel, linux-efi, Matt Fleming, Lee, Chun-Yi, Matthew Garrett From: Peter Jones <pjones@redhat.com> All the variables in this list so far are defined to be in the global namespace in the UEFI spec, so this just further ensures we're validating the variables we think we are. Including the guid for entries will become more important in future patches when we decide whether or not to allow deletion of variables based on presence in this list. Signed-off-by: Peter Jones <pjones@redhat.com> Tested-by: "Lee, Chun-Yi" <jlee@suse.com> Acked-by: Matthew Garrett <mjg59@coreos.com> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> --- drivers/firmware/efi/efivars.c | 5 ++-- drivers/firmware/efi/vars.c | 52 +++++++++++++++++++++++++++--------------- include/linux/efi.h | 3 ++- 3 files changed, 38 insertions(+), 22 deletions(-) diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c index f4ff8abc5f3e..10e6774ab2a2 100644 --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -221,7 +221,7 @@ sanity_check(struct efi_variable *var, efi_char16_t *name, efi_guid_t vendor, } if ((attributes & ~EFI_VARIABLE_MASK) != 0 || - efivar_validate(name, data, size) == false) { + efivar_validate(vendor, name, data, size) == false) { printk(KERN_ERR "efivars: Malformed variable content\n"); return -EINVAL; } @@ -447,7 +447,8 @@ static ssize_t efivar_create(struct file *filp, struct kobject *kobj, } if ((attributes & ~EFI_VARIABLE_MASK) != 0 || - efivar_validate(name, data, size) == false) { + efivar_validate(new_var->VendorGuid, name, data, + size) == false) { printk(KERN_ERR "efivars: Malformed variable content\n"); return -EINVAL; } diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c index 5c5fde3e6c37..9a53da21e7b6 100644 --- a/drivers/firmware/efi/vars.c +++ b/drivers/firmware/efi/vars.c @@ -165,31 +165,42 @@ validate_ascii_string(efi_char16_t *var_name, int match, u8 *buffer, } struct variable_validate { + efi_guid_t vendor; char *name; bool (*validate)(efi_char16_t *var_name, int match, u8 *data, unsigned long len); }; +/* + * This is the list of variables we need to validate. + * + * If it has a validate() method that's not NULL, it'll go into the + * validation routine. If not, it is assumed valid. + * + * Note that it's sorted by {vendor,name}, but globbed names must come after + * any other name with the same prefix. + */ static const struct variable_validate variable_validate[] = { - { "BootNext", validate_uint16 }, - { "BootOrder", validate_boot_order }, - { "DriverOrder", validate_boot_order }, - { "Boot*", validate_load_option }, - { "Driver*", validate_load_option }, - { "ConIn", validate_device_path }, - { "ConInDev", validate_device_path }, - { "ConOut", validate_device_path }, - { "ConOutDev", validate_device_path }, - { "ErrOut", validate_device_path }, - { "ErrOutDev", validate_device_path }, - { "Timeout", validate_uint16 }, - { "Lang", validate_ascii_string }, - { "PlatformLang", validate_ascii_string }, - { "", NULL }, + { EFI_GLOBAL_VARIABLE_GUID, "BootNext", validate_uint16 }, + { EFI_GLOBAL_VARIABLE_GUID, "BootOrder", validate_boot_order }, + { EFI_GLOBAL_VARIABLE_GUID, "Boot*", validate_load_option }, + { EFI_GLOBAL_VARIABLE_GUID, "DriverOrder", validate_boot_order }, + { EFI_GLOBAL_VARIABLE_GUID, "Driver*", validate_load_option }, + { EFI_GLOBAL_VARIABLE_GUID, "ConIn", validate_device_path }, + { EFI_GLOBAL_VARIABLE_GUID, "ConInDev", validate_device_path }, + { EFI_GLOBAL_VARIABLE_GUID, "ConOut", validate_device_path }, + { EFI_GLOBAL_VARIABLE_GUID, "ConOutDev", validate_device_path }, + { EFI_GLOBAL_VARIABLE_GUID, "ErrOut", validate_device_path }, + { EFI_GLOBAL_VARIABLE_GUID, "ErrOutDev", validate_device_path }, + { EFI_GLOBAL_VARIABLE_GUID, "Lang", validate_ascii_string }, + { EFI_GLOBAL_VARIABLE_GUID, "PlatformLang", validate_ascii_string }, + { EFI_GLOBAL_VARIABLE_GUID, "Timeout", validate_uint16 }, + { NULL_GUID, "", NULL }, }; bool -efivar_validate(efi_char16_t *var_name, u8 *data, unsigned long data_size) +efivar_validate(efi_guid_t vendor, efi_char16_t *var_name, u8 *data, + unsigned long data_size) { int i; unsigned long utf8_size; @@ -203,9 +214,12 @@ efivar_validate(efi_char16_t *var_name, u8 *data, unsigned long data_size) ucs2_as_utf8(utf8_name, var_name, utf8_size); utf8_name[utf8_size] = '\0'; - for (i = 0; variable_validate[i].validate != NULL; i++) { + for (i = 0; variable_validate[i].name[0] != '\0'; i++) { const char *name = variable_validate[i].name; - int match; + int match = 0; + + if (efi_guidcmp(vendor, variable_validate[i].vendor)) + continue; for (match = 0; ; match++) { char c = name[match]; @@ -862,7 +876,7 @@ int efivar_entry_set_get_size(struct efivar_entry *entry, u32 attributes, *set = false; - if (efivar_validate(name, data, *size) == false) + if (efivar_validate(*vendor, name, data, *size) == false) return -EINVAL; /* diff --git a/include/linux/efi.h b/include/linux/efi.h index 569b5a866bb1..16ca611aabc8 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -1199,7 +1199,8 @@ int efivar_entry_iter(int (*func)(struct efivar_entry *, void *), struct efivar_entry *efivar_entry_find(efi_char16_t *name, efi_guid_t guid, struct list_head *head, bool remove); -bool efivar_validate(efi_char16_t *var_name, u8 *data, unsigned long len); +bool efivar_validate(efi_guid_t vendor, efi_char16_t *var_name, u8 *data, + unsigned long data_size); extern struct work_struct efivar_work; void efivar_run_worker(void); -- 2.6.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/5] efi: Make efivarfs entries immutable by default 2016-02-12 11:27 [GIT PULL 0/5] EFI urgent fixes Matt Fleming ` (2 preceding siblings ...) 2016-02-12 11:27 ` [PATCH 4/5] efi: Make our variable validation list include the guid Matt Fleming @ 2016-02-12 11:27 ` Matt Fleming [not found] ` <1455276432-9931-6-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 2016-02-16 12:15 ` [GIT PULL 0/5] EFI urgent fixes Ingo Molnar 4 siblings, 1 reply; 15+ messages in thread From: Matt Fleming @ 2016-02-12 11:27 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Peter Jones, linux-kernel, linux-efi, Matt Fleming, Lee, Chun-Yi, Matthew Garrett From: Peter Jones <pjones@redhat.com> "rm -rf" is bricking some peoples' laptops because of variables being used to store non-reinitializable firmware driver data that's required to POST the hardware. These are 100% bugs, and they need to be fixed, but in the mean time it shouldn't be easy to *accidentally* brick machines. We have to have delete working, and picking which variables do and don't work for deletion is quite intractable, so instead make everything immutable by default (except for a whitelist), and make tools that aren't quite so broad-spectrum unset the immutable flag. Signed-off-by: Peter Jones <pjones@redhat.com> Tested-by: "Lee, Chun-Yi" <jlee@suse.com> Acked-by: Matthew Garrett <mjg59@coreos.com> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> --- Documentation/filesystems/efivarfs.txt | 7 +++ drivers/firmware/efi/vars.c | 87 +++++++++++++++++++------- fs/efivarfs/file.c | 70 +++++++++++++++++++++ fs/efivarfs/inode.c | 30 +++++---- fs/efivarfs/internal.h | 3 +- fs/efivarfs/super.c | 9 ++- include/linux/efi.h | 2 + tools/testing/selftests/efivarfs/efivarfs.sh | 19 +++++- tools/testing/selftests/efivarfs/open-unlink.c | 72 ++++++++++++++++++++- 9 files changed, 258 insertions(+), 41 deletions(-) diff --git a/Documentation/filesystems/efivarfs.txt b/Documentation/filesystems/efivarfs.txt index c477af086e65..686a64bba775 100644 --- a/Documentation/filesystems/efivarfs.txt +++ b/Documentation/filesystems/efivarfs.txt @@ -14,3 +14,10 @@ filesystem. efivarfs is typically mounted like this, mount -t efivarfs none /sys/firmware/efi/efivars + +Due to the presence of numerous firmware bugs where removing non-standard +UEFI variables causes the system firmware to fail to POST, efivarfs +files that are not well-known standardized variables are created +as immutable files. This doesn't prevent removal - "chattr -i" will work - +but it does prevent this kind of failure from being accomplished +accidentally. diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c index 9a53da21e7b6..50f10bad2604 100644 --- a/drivers/firmware/efi/vars.c +++ b/drivers/firmware/efi/vars.c @@ -172,10 +172,12 @@ struct variable_validate { }; /* - * This is the list of variables we need to validate. + * This is the list of variables we need to validate, as well as the + * whitelist for what we think is safe not to default to immutable. * * If it has a validate() method that's not NULL, it'll go into the - * validation routine. If not, it is assumed valid. + * validation routine. If not, it is assumed valid, but still used for + * whitelisting. * * Note that it's sorted by {vendor,name}, but globbed names must come after * any other name with the same prefix. @@ -193,11 +195,37 @@ static const struct variable_validate variable_validate[] = { { EFI_GLOBAL_VARIABLE_GUID, "ErrOut", validate_device_path }, { EFI_GLOBAL_VARIABLE_GUID, "ErrOutDev", validate_device_path }, { EFI_GLOBAL_VARIABLE_GUID, "Lang", validate_ascii_string }, + { EFI_GLOBAL_VARIABLE_GUID, "OsIndications", NULL }, { EFI_GLOBAL_VARIABLE_GUID, "PlatformLang", validate_ascii_string }, { EFI_GLOBAL_VARIABLE_GUID, "Timeout", validate_uint16 }, { NULL_GUID, "", NULL }, }; +static bool +variable_matches(const char *var_name, size_t len, const char *match_name, + int *match) +{ + for (*match = 0; ; (*match)++) { + char c = match_name[*match]; + char u = var_name[*match]; + + /* Wildcard in the matching name means we've matched */ + if (c == '*') + return true; + + /* Case sensitive match */ + if (!c && *match == len) + return true; + + if (c != u) + return false; + + if (!c) + return true; + } + return true; +} + bool efivar_validate(efi_guid_t vendor, efi_char16_t *var_name, u8 *data, unsigned long data_size) @@ -221,35 +249,48 @@ efivar_validate(efi_guid_t vendor, efi_char16_t *var_name, u8 *data, if (efi_guidcmp(vendor, variable_validate[i].vendor)) continue; - for (match = 0; ; match++) { - char c = name[match]; - char u = utf8_name[match]; - - /* Wildcard in the matching name means we've matched */ - if (c == '*') { - kfree(utf8_name); - return variable_validate[i].validate(var_name, - match, data, data_size); - } - - /* Case sensitive match */ - if (c != u) + if (variable_matches(utf8_name, utf8_size+1, name, &match)) { + if (variable_validate[i].validate == NULL) break; - - /* Reached the end of the string while matching */ - if (!c) { - kfree(utf8_name); - return variable_validate[i].validate(var_name, - match, data, data_size); - } + kfree(utf8_name); + return variable_validate[i].validate(var_name, match, + data, data_size); } } - kfree(utf8_name); return true; } EXPORT_SYMBOL_GPL(efivar_validate); +bool +efivar_variable_is_removable(efi_guid_t vendor, const char *var_name, + size_t len) +{ + int i; + bool found = false; + int match = 0; + + /* + * Check if our variable is in the validated variables list + */ + for (i = 0; variable_validate[i].name[0] != '\0'; i++) { + if (efi_guidcmp(variable_validate[i].vendor, vendor)) + continue; + + if (variable_matches(var_name, len, + variable_validate[i].name, &match)) { + found = true; + break; + } + } + + /* + * If it's in our list, it is removable. + */ + return found; +} +EXPORT_SYMBOL_GPL(efivar_variable_is_removable); + static efi_status_t check_var_size(u32 attributes, unsigned long size) { diff --git a/fs/efivarfs/file.c b/fs/efivarfs/file.c index c424e4813ec8..d48e0d261d78 100644 --- a/fs/efivarfs/file.c +++ b/fs/efivarfs/file.c @@ -10,6 +10,7 @@ #include <linux/efi.h> #include <linux/fs.h> #include <linux/slab.h> +#include <linux/mount.h> #include "internal.h" @@ -103,9 +104,78 @@ out_free: return size; } +static int +efivarfs_ioc_getxflags(struct file *file, void __user *arg) +{ + struct inode *inode = file->f_mapping->host; + unsigned int i_flags; + unsigned int flags = 0; + + i_flags = inode->i_flags; + if (i_flags & S_IMMUTABLE) + flags |= FS_IMMUTABLE_FL; + + if (copy_to_user(arg, &flags, sizeof(flags))) + return -EFAULT; + return 0; +} + +static int +efivarfs_ioc_setxflags(struct file *file, void __user *arg) +{ + struct inode *inode = file->f_mapping->host; + unsigned int flags; + unsigned int i_flags = 0; + int error; + + if (!inode_owner_or_capable(inode)) + return -EACCES; + + if (copy_from_user(&flags, arg, sizeof(flags))) + return -EFAULT; + + if (flags & ~FS_IMMUTABLE_FL) + return -EOPNOTSUPP; + + if (!capable(CAP_LINUX_IMMUTABLE)) + return -EPERM; + + if (flags & FS_IMMUTABLE_FL) + i_flags |= S_IMMUTABLE; + + + error = mnt_want_write_file(file); + if (error) + return error; + + inode_lock(inode); + inode_set_flags(inode, i_flags, S_IMMUTABLE); + inode_unlock(inode); + + mnt_drop_write_file(file); + + return 0; +} + +long +efivarfs_file_ioctl(struct file *file, unsigned int cmd, unsigned long p) +{ + void __user *arg = (void __user *)p; + + switch (cmd) { + case FS_IOC_GETFLAGS: + return efivarfs_ioc_getxflags(file, arg); + case FS_IOC_SETFLAGS: + return efivarfs_ioc_setxflags(file, arg); + } + + return -ENOTTY; +} + const struct file_operations efivarfs_file_operations = { .open = simple_open, .read = efivarfs_file_read, .write = efivarfs_file_write, .llseek = no_llseek, + .unlocked_ioctl = efivarfs_file_ioctl, }; diff --git a/fs/efivarfs/inode.c b/fs/efivarfs/inode.c index 3381b9da9ee6..e2ab6d0497f2 100644 --- a/fs/efivarfs/inode.c +++ b/fs/efivarfs/inode.c @@ -15,7 +15,8 @@ #include "internal.h" struct inode *efivarfs_get_inode(struct super_block *sb, - const struct inode *dir, int mode, dev_t dev) + const struct inode *dir, int mode, + dev_t dev, bool is_removable) { struct inode *inode = new_inode(sb); @@ -23,6 +24,7 @@ struct inode *efivarfs_get_inode(struct super_block *sb, inode->i_ino = get_next_ino(); inode->i_mode = mode; inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; + inode->i_flags = is_removable ? 0 : S_IMMUTABLE; switch (mode & S_IFMT) { case S_IFREG: inode->i_fop = &efivarfs_file_operations; @@ -102,22 +104,17 @@ static void efivarfs_hex_to_guid(const char *str, efi_guid_t *guid) static int efivarfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, bool excl) { - struct inode *inode; + struct inode *inode = NULL; struct efivar_entry *var; int namelen, i = 0, err = 0; + bool is_removable = false; if (!efivarfs_valid_name(dentry->d_name.name, dentry->d_name.len)) return -EINVAL; - inode = efivarfs_get_inode(dir->i_sb, dir, mode, 0); - if (!inode) - return -ENOMEM; - var = kzalloc(sizeof(struct efivar_entry), GFP_KERNEL); - if (!var) { - err = -ENOMEM; - goto out; - } + if (!var) + return -ENOMEM; /* length of the variable name itself: remove GUID and separator */ namelen = dentry->d_name.len - EFI_VARIABLE_GUID_LEN - 1; @@ -125,6 +122,16 @@ static int efivarfs_create(struct inode *dir, struct dentry *dentry, efivarfs_hex_to_guid(dentry->d_name.name + namelen + 1, &var->var.VendorGuid); + if (efivar_variable_is_removable(var->var.VendorGuid, + dentry->d_name.name, namelen)) + is_removable = true; + + inode = efivarfs_get_inode(dir->i_sb, dir, mode, 0, is_removable); + if (!inode) { + err = -ENOMEM; + goto out; + } + for (i = 0; i < namelen; i++) var->var.VariableName[i] = dentry->d_name.name[i]; @@ -138,7 +145,8 @@ static int efivarfs_create(struct inode *dir, struct dentry *dentry, out: if (err) { kfree(var); - iput(inode); + if (inode) + iput(inode); } return err; } diff --git a/fs/efivarfs/internal.h b/fs/efivarfs/internal.h index b5ff16addb7c..b4505188e799 100644 --- a/fs/efivarfs/internal.h +++ b/fs/efivarfs/internal.h @@ -15,7 +15,8 @@ extern const struct file_operations efivarfs_file_operations; extern const struct inode_operations efivarfs_dir_inode_operations; extern bool efivarfs_valid_name(const char *str, int len); extern struct inode *efivarfs_get_inode(struct super_block *sb, - const struct inode *dir, int mode, dev_t dev); + const struct inode *dir, int mode, dev_t dev, + bool is_removable); extern struct list_head efivarfs_list; diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c index 8651ac28ec0d..dd029d13ea61 100644 --- a/fs/efivarfs/super.c +++ b/fs/efivarfs/super.c @@ -120,6 +120,7 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor, char *name; int len; int err = -ENOMEM; + bool is_removable = false; entry = kzalloc(sizeof(*entry), GFP_KERNEL); if (!entry) @@ -137,13 +138,17 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor, ucs2_as_utf8(name, entry->var.VariableName, len); + if (efivar_variable_is_removable(entry->var.VendorGuid, name, len)) + is_removable = true; + name[len] = '-'; efi_guid_to_str(&entry->var.VendorGuid, name + len + 1); name[len + EFI_VARIABLE_GUID_LEN+1] = '\0'; - inode = efivarfs_get_inode(sb, d_inode(root), S_IFREG | 0644, 0); + inode = efivarfs_get_inode(sb, d_inode(root), S_IFREG | 0644, 0, + is_removable); if (!inode) goto fail_name; @@ -199,7 +204,7 @@ static int efivarfs_fill_super(struct super_block *sb, void *data, int silent) sb->s_d_op = &efivarfs_d_ops; sb->s_time_gran = 1; - inode = efivarfs_get_inode(sb, NULL, S_IFDIR | 0755, 0); + inode = efivarfs_get_inode(sb, NULL, S_IFDIR | 0755, 0, true); if (!inode) return -ENOMEM; inode->i_op = &efivarfs_dir_inode_operations; diff --git a/include/linux/efi.h b/include/linux/efi.h index 16ca611aabc8..47be3ad7d3e5 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -1201,6 +1201,8 @@ struct efivar_entry *efivar_entry_find(efi_char16_t *name, efi_guid_t guid, bool efivar_validate(efi_guid_t vendor, efi_char16_t *var_name, u8 *data, unsigned long data_size); +bool efivar_variable_is_removable(efi_guid_t vendor, const char *name, + size_t len); extern struct work_struct efivar_work; void efivar_run_worker(void); diff --git a/tools/testing/selftests/efivarfs/efivarfs.sh b/tools/testing/selftests/efivarfs/efivarfs.sh index 77edcdcc016b..057278448515 100755 --- a/tools/testing/selftests/efivarfs/efivarfs.sh +++ b/tools/testing/selftests/efivarfs/efivarfs.sh @@ -88,7 +88,11 @@ test_delete() exit 1 fi - rm $file + rm $file 2>/dev/null + if [ $? -ne 0 ]; then + chattr -i $file + rm $file + fi if [ -e $file ]; then echo "$file couldn't be deleted" >&2 @@ -111,6 +115,7 @@ test_zero_size_delete() exit 1 fi + chattr -i $file printf "$attrs" > $file if [ -e $file ]; then @@ -141,7 +146,11 @@ test_valid_filenames() echo "$file could not be created" >&2 ret=1 else - rm $file + rm $file 2>/dev/null + if [ $? -ne 0 ]; then + chattr -i $file + rm $file + fi fi done @@ -174,7 +183,11 @@ test_invalid_filenames() if [ -e $file ]; then echo "Creating $file should have failed" >&2 - rm $file + rm $file 2>/dev/null + if [ $? -ne 0 ]; then + chattr -i $file + rm $file + fi ret=1 fi done diff --git a/tools/testing/selftests/efivarfs/open-unlink.c b/tools/testing/selftests/efivarfs/open-unlink.c index 8c0764407b3c..4af74f733036 100644 --- a/tools/testing/selftests/efivarfs/open-unlink.c +++ b/tools/testing/selftests/efivarfs/open-unlink.c @@ -1,10 +1,68 @@ +#include <errno.h> #include <stdio.h> #include <stdint.h> #include <stdlib.h> #include <unistd.h> +#include <sys/ioctl.h> #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> +#include <linux/fs.h> + +static int set_immutable(const char *path, int immutable) +{ + unsigned int flags; + int fd; + int rc; + int error; + + fd = open(path, O_RDONLY); + if (fd < 0) + return fd; + + rc = ioctl(fd, FS_IOC_GETFLAGS, &flags); + if (rc < 0) { + error = errno; + close(fd); + errno = error; + return rc; + } + + if (immutable) + flags |= FS_IMMUTABLE_FL; + else + flags &= ~FS_IMMUTABLE_FL; + + rc = ioctl(fd, FS_IOC_SETFLAGS, &flags); + error = errno; + close(fd); + errno = error; + return rc; +} + +static int get_immutable(const char *path) +{ + unsigned int flags; + int fd; + int rc; + int error; + + fd = open(path, O_RDONLY); + if (fd < 0) + return fd; + + rc = ioctl(fd, FS_IOC_GETFLAGS, &flags); + if (rc < 0) { + error = errno; + close(fd); + errno = error; + return rc; + } + close(fd); + if (flags & FS_IMMUTABLE_FL) + return 1; + return 0; +} int main(int argc, char **argv) { @@ -27,7 +85,7 @@ int main(int argc, char **argv) buf[4] = 0; /* create a test variable */ - fd = open(path, O_WRONLY | O_CREAT); + fd = open(path, O_WRONLY | O_CREAT, 0600); if (fd < 0) { perror("open(O_WRONLY)"); return EXIT_FAILURE; @@ -41,6 +99,18 @@ int main(int argc, char **argv) close(fd); + rc = get_immutable(path); + if (rc < 0) { + perror("ioctl(FS_IOC_GETFLAGS)"); + return EXIT_FAILURE; + } else if (rc) { + rc = set_immutable(path, 0); + if (rc < 0) { + perror("ioctl(FS_IOC_SETFLAGS)"); + return EXIT_FAILURE; + } + } + fd = open(path, O_RDONLY); if (fd < 0) { perror("open"); -- 2.6.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1455276432-9931-6-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]
* Re: [PATCH 5/5] efi: Make efivarfs entries immutable by default [not found] ` <1455276432-9931-6-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> @ 2016-02-15 10:50 ` Matt Fleming 0 siblings, 0 replies; 15+ messages in thread From: Matt Fleming @ 2016-02-15 10:50 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Ard Biesheuvel, Peter Jones, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Lee, Chun-Yi, Matthew Garrett, Laszlo Ersek On Fri, 12 Feb, at 11:27:12AM, Matt Fleming wrote: > From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > > "rm -rf" is bricking some peoples' laptops because of variables being > used to store non-reinitializable firmware driver data that's required > to POST the hardware. > > These are 100% bugs, and they need to be fixed, but in the mean time it > shouldn't be easy to *accidentally* brick machines. > > We have to have delete working, and picking which variables do and don't > work for deletion is quite intractable, so instead make everything > immutable by default (except for a whitelist), and make tools that > aren't quite so broad-spectrum unset the immutable flag. > > Signed-off-by: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > Tested-by: "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org> > Acked-by: Matthew Garrett <mjg59-JW9irJGTvgXQT0dZR+AlfA@public.gmane.org> > Signed-off-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> > --- > Documentation/filesystems/efivarfs.txt | 7 +++ > drivers/firmware/efi/vars.c | 87 +++++++++++++++++++------- > fs/efivarfs/file.c | 70 +++++++++++++++++++++ > fs/efivarfs/inode.c | 30 +++++---- > fs/efivarfs/internal.h | 3 +- > fs/efivarfs/super.c | 9 ++- > include/linux/efi.h | 2 + > tools/testing/selftests/efivarfs/efivarfs.sh | 19 +++++- > tools/testing/selftests/efivarfs/open-unlink.c | 72 ++++++++++++++++++++- > 9 files changed, 258 insertions(+), 41 deletions(-) Folks, please hold off on merging this patch as Laszlo has raised a good point about including the efi-pstore variables in the whitelist. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PULL 0/5] EFI urgent fixes 2016-02-12 11:27 [GIT PULL 0/5] EFI urgent fixes Matt Fleming ` (3 preceding siblings ...) 2016-02-12 11:27 ` [PATCH 5/5] efi: Make efivarfs entries immutable by default Matt Fleming @ 2016-02-16 12:15 ` Ingo Molnar 2016-02-16 12:52 ` Matt Fleming 4 siblings, 1 reply; 15+ messages in thread From: Ingo Molnar @ 2016-02-16 12:15 UTC (permalink / raw) To: Matt Fleming Cc: Thomas Gleixner, H . Peter Anvin, Ard Biesheuvel, linux-kernel, linux-efi, Lee, Chun-Yi, Matthew Garrett, Peter Jones, Linus Torvalds * Matt Fleming <matt@codeblueprint.co.uk> wrote: > Folks, > > Please pull the following EFI patches from Peter that prevent > accidental deletion of EFI variables through efivarfs which can lead > to bricked machines. > > These obviously need backporting to stable, so I'll take care of > sending the backports separately because we don't need to send the > entire 5 patch series. > > The following changes since commit 59fd1214561921343305a0e9dc218bf3d40068f3: > > x86/mm/numa: Fix 32-bit memblock range truncation bug on 32-bit NUMA kernels (2016-02-08 12:10:03 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-urgent > > for you to fetch changes up to ed8b0de5a33d2a2557dce7f9429dca8cb5bc5879: > > efi: Make efivarfs entries immutable by default (2016-02-10 16:25:52 +0000) > > ---------------------------------------------------------------- > * Prevent accidental deletion of EFI variables through efivarfs that > may brick machines. We use a whitelist of known-safe variables to > allow things like installing distributions to work out of the box, and > instead restrict vendor-specific variable deletion by making > non-whitelist variables immutable - Peter Jones > > ---------------------------------------------------------------- > Peter Jones (5): > lib/ucs2_string: Add ucs2 -> utf8 helper functions > efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version > efi: Do variable name validation tests in utf8 > efi: Make our variable validation list include the guid > efi: Make efivarfs entries immutable by default > > Documentation/filesystems/efivarfs.txt | 7 ++ > drivers/firmware/efi/efivars.c | 35 +++--- > drivers/firmware/efi/vars.c | 143 ++++++++++++++++++------- > fs/efivarfs/file.c | 70 ++++++++++++ > fs/efivarfs/inode.c | 30 ++++-- > fs/efivarfs/internal.h | 3 +- > fs/efivarfs/super.c | 16 +-- > include/linux/efi.h | 5 +- > include/linux/ucs2_string.h | 4 + > lib/ucs2_string.c | 62 +++++++++++ > tools/testing/selftests/efivarfs/efivarfs.sh | 19 +++- > tools/testing/selftests/efivarfs/open-unlink.c | 72 ++++++++++++- > 12 files changed, 383 insertions(+), 83 deletions(-) Pulled, thanks Matt! Ingo ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PULL 0/5] EFI urgent fixes 2016-02-16 12:15 ` [GIT PULL 0/5] EFI urgent fixes Ingo Molnar @ 2016-02-16 12:52 ` Matt Fleming [not found] ` <20160216125236.GB2769-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Matt Fleming @ 2016-02-16 12:52 UTC (permalink / raw) To: Ingo Molnar Cc: Thomas Gleixner, H . Peter Anvin, Ard Biesheuvel, linux-kernel, linux-efi, Lee, Chun-Yi, Matthew Garrett, Peter Jones, Linus Torvalds On Tue, 16 Feb, at 01:15:45PM, Ingo Molnar wrote: > > Pulled, thanks Matt! Thanks a lot Ingo. I've actually got a couple of stragglers that came before the weekend that fix bugs. It would be good to pick them up before you send a pull request to Linus. I'll send out a second pull request momentarily. ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20160216125236.GB2769-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]
* Re: [GIT PULL 0/5] EFI urgent fixes [not found] ` <20160216125236.GB2769-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> @ 2016-02-17 7:59 ` Ingo Molnar 2016-02-17 10:16 ` Matt Fleming 0 siblings, 1 reply; 15+ messages in thread From: Ingo Molnar @ 2016-02-17 7:59 UTC (permalink / raw) To: Matt Fleming Cc: Thomas Gleixner, H . Peter Anvin, Ard Biesheuvel, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Lee, Chun-Yi, Matthew Garrett, Peter Jones, Linus Torvalds * Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote: > On Tue, 16 Feb, at 01:15:45PM, Ingo Molnar wrote: > > > > Pulled, thanks Matt! > > Thanks a lot Ingo. > > I've actually got a couple of stragglers that came before the weekend > that fix bugs. It would be good to pick them up before you send a pull > request to Linus. > > I'll send out a second pull request momentarily. I've pulled it all, so tip:x86/urgent should have everything needed. Please let me know if anything is amiss - I intend to send the fixes to Linus tomorrow-ish. Thanks, Ingo ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PULL 0/5] EFI urgent fixes 2016-02-17 7:59 ` Ingo Molnar @ 2016-02-17 10:16 ` Matt Fleming 0 siblings, 0 replies; 15+ messages in thread From: Matt Fleming @ 2016-02-17 10:16 UTC (permalink / raw) To: Ingo Molnar Cc: Thomas Gleixner, H . Peter Anvin, Ard Biesheuvel, linux-kernel, linux-efi, Lee, Chun-Yi, Matthew Garrett, Peter Jones, Linus Torvalds On Wed, 17 Feb, at 08:59:18AM, Ingo Molnar wrote: > > I've pulled it all, so tip:x86/urgent should have everything needed. Please let me > know if anything is amiss - I intend to send the fixes to Linus tomorrow-ish. Looks good. Thanks Ingo. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [GIT PULL 0/5] EFI urgent fixes @ 2017-05-26 11:36 Matt Fleming 0 siblings, 0 replies; 15+ messages in thread From: Matt Fleming @ 2017-05-26 11:36 UTC (permalink / raw) To: Ingo Molnar, Thomas Gleixner, H . Peter Anvin Cc: Matt Fleming, Ard Biesheuvel, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-efi-u79uwXL29TY76Z2rM5mHXA, Arnd Bergmann, Baoquan He, Bhupesh Sharma, Borislav Petkov, Dave Young, David Howells, Frank Ramsay, Josh Boyer, Juergen Gross, Kees Cook, Lee Chun-Yi, Ravi Shankar, Ricardo Neri, Russ Anderson, Sabrina Dubroca, Sai Praneeth Prakhya, Thomas Garnier Hi folks, Please pull the following fixes. There are patches that resolve a few boot crashes and some minor build and boot log cleanups. The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git tags/efi-urgent for you to fetch changes up to 5d36982a80248b2dcce395e7fa4ba342e814ced1: efi/bgrt: Skip efi_bgrt_init in case of non-efi boot (2017-05-26 11:27:38 +0100) ---------------------------------------------------------------- - Make the boot console quiet when using Xen on EFI by deleting a pointless error message - Juergen Gross - Silence harmless warnings emitted with GCC 7 - Arnd Bergmann - Prevent a crash when booting kexec with the efi=old_map kernel command line parameter by disabling EFI runtime services - Sai Praneeth - Fix boot crash when using kaslr and efi=old_map. The crash is caused because of assumptions about PAGE_OFFSET alignment which are not true with kaslr enabled - Baoquan He - Fix boot regression when a machine has an ACPI BGRT table and is booted using BIOS, not EFI. - Dave Young ---------------------------------------------------------------- Arnd Bergmann (1): efi: Remove duplicate 'const' specifiers Baoquan He (1): x86/efi: Correct ident mapping of efi old_map when kalsr enabled Dave Young (1): efi/bgrt: Skip efi_bgrt_init in case of non-efi boot Juergen Gross (1): efi: Don't issue error message when booted under xen Sai Praneeth (1): x86/efi: Disable runtime services on kexec kernel if booted with efi=old_map arch/x86/platform/efi/efi.c | 6 ++- arch/x86/platform/efi/efi_64.c | 79 +++++++++++++++++++++++++++---- arch/x86/platform/efi/quirks.c | 3 ++ drivers/firmware/efi/efi-bgrt.c | 3 ++ drivers/firmware/efi/libstub/secureboot.c | 4 +- 5 files changed, 83 insertions(+), 12 deletions(-) ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-05-26 11:36 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-02-12 11:27 [GIT PULL 0/5] EFI urgent fixes Matt Fleming 2016-02-12 11:27 ` [PATCH 2/5] efi: Use ucs2_as_utf8 in efivarfs instead of open coding a bad version Matt Fleming [not found] ` <1455276432-9931-3-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 2016-02-18 5:34 ` H. Peter Anvin [not found] ` <12473B1F-5227-4E83-BAF9-06B69CF74D77-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> 2016-02-18 6:09 ` Matthew Garrett [not found] ` <CAPeXnHuoQgrz1-_zkBKcskNE24jK2L5DSyWjbBoU+ceVzGZe0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-02-18 9:36 ` H. Peter Anvin [not found] ` <1455276432-9931-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 2016-02-12 11:27 ` [PATCH 1/5] lib/ucs2_string: Add ucs2 -> utf8 helper functions Matt Fleming 2016-02-12 11:27 ` [PATCH 3/5] efi: Do variable name validation tests in utf8 Matt Fleming 2016-02-12 11:27 ` [PATCH 4/5] efi: Make our variable validation list include the guid Matt Fleming 2016-02-12 11:27 ` [PATCH 5/5] efi: Make efivarfs entries immutable by default Matt Fleming [not found] ` <1455276432-9931-6-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 2016-02-15 10:50 ` Matt Fleming 2016-02-16 12:15 ` [GIT PULL 0/5] EFI urgent fixes Ingo Molnar 2016-02-16 12:52 ` Matt Fleming [not found] ` <20160216125236.GB2769-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> 2016-02-17 7:59 ` Ingo Molnar 2016-02-17 10:16 ` Matt Fleming 2017-05-26 11:36 Matt Fleming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).