From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Kweh,
Hock Leong"
<hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Sam Protsenko
<semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Ming Lei <ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
"Ong,
Boon Leong"
<boon.leong.ong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface
Date: Fri, 13 Mar 2015 15:42:13 +0100 [thread overview]
Message-ID: <20150313144213.GA19009@kroah.com> (raw)
In-Reply-To: <20150312224754.GD24174-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
On Thu, Mar 12, 2015 at 10:47:54PM +0000, Matt Fleming wrote:
> On Tue, 10 Mar, at 08:51:59AM, Andy Lutomirski wrote:
> >
> > I'm not 100% happy with write(2) (which is all we have in sysfs) for
> > two reasons:
> >
> > 1. If we write a file name, eww. That's more complicated, requires
> > temporary files, has annoying mount namespace issues, etc.
> >
> > 2. If we write the full contents, we need to do it in a single call to
> > write. That means that we can't use cat, which mostly defeats the
> > purpose. In fact, using cat could be actively harmful.
>
> At this point I'd really like Greg to chime in.
>
> In principal, I'm not stricly opposed to using a simple char device
> provided that it's not essentially a copy and paste of code from
> drivers/base/firmware_class.c.
>
> Greg?
Yes, I don't want a character driver here for this if at all possible.
Just stick with the firmware download code, it's there and should work
"as-is" for your stuff.
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-13 14:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F54AEECA5E2B9541821D670476DAE19C2B8AC95C@PGSMSX102.gar.corp.intel.com>
[not found] ` <F54AEECA5E2B9541821D670476DAE19C2B8AC95C-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-24 12:49 ` Re: [PATCH v2 3/3] efi: Capsule update with user helper interface Kweh, Hock Leong
2015-02-25 11:47 ` Borislav Petkov
[not found] ` <20150225114747.GC3226-fF5Pk5pvG8Y@public.gmane.org>
2015-02-25 12:38 ` Kweh, Hock Leong
2015-02-25 12:49 ` Borislav Petkov
2015-02-26 15:30 ` Andy Lutomirski
[not found] ` <CALCETrVk8GJSzOyRu3Jr-72Tp79XzunGg9T-_70ngTPnG4YZqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-26 15:54 ` Borislav Petkov
2015-03-02 11:24 ` Matt Fleming
[not found] ` <F54AEECA5E2B9541821D670476DAE19C2B8AC9DD-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-06 21:39 ` Peter Jones
[not found] ` <20150306213912.GA8020-FS9oOTXHwv9t4tGkRPVz9tcb/sdHg95EuydrBrBl+0sAvxtiuMwx3w@public.gmane.org>
2015-03-06 21:49 ` Roy Franz
[not found] ` <CAFECyb8oD+tjmwaR11PRZ_0K6ddYW5TE9+L1tVnMFE2yHHCg0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-06 22:17 ` Peter Jones
2015-03-10 12:26 ` Matt Fleming
2015-03-10 15:21 ` Peter Jones
[not found] ` <20150310152155.GB1208-FS9oOTXHwv9t4tGkRPVz9tcb/sdHg95EuydrBrBl+0sAvxtiuMwx3w@public.gmane.org>
2015-03-10 15:26 ` Andy Lutomirski
[not found] ` <CALCETrXMvDqMvRf2yzRvpjHQB5pip5zNiihAccCc9Sm5UWGysg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 15:40 ` Peter Jones
2015-03-10 15:51 ` Andy Lutomirski
2015-03-10 17:26 ` Peter Jones
[not found] ` <20150310172603.GF1208-FS9oOTXHwv9t4tGkRPVz9tcb/sdHg95EuydrBrBl+0sAvxtiuMwx3w@public.gmane.org>
2015-03-10 17:31 ` Andy Lutomirski
[not found] ` <CALCETrUDuTt_BK1JSFU=_EEujpm1ekzmkte-c3vxuRW7hWPUPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-12 22:47 ` Matt Fleming
[not found] ` <20150312224754.GD24174-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-03-13 14:42 ` Greg Kroah-Hartman [this message]
2015-03-16 15:35 ` Andy Lutomirski
2015-03-02 10:59 Kweh, Hock Leong
[not found] ` <F54AEECA5E2B9541821D670476DAE19C2B8AD9CA-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-02 12:29 ` Matt Fleming
2015-03-03 5:56 ` Kweh, Hock Leong
2015-03-03 20:37 ` Andy Lutomirski
[not found] ` <CALCETrXfjbKcYSSRQXZbam7TgHU34LXM0BhvMuba_vYyCCPTig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-03 20:49 ` Borislav Petkov
2015-03-03 21:56 ` Andy Lutomirski
2015-03-05 9:18 ` Kweh, Hock Leong
[not found] ` <F54AEECA5E2B9541821D670476DAE19C2B8AF4F2-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-05 23:08 ` Andy Lutomirski
[not found] ` <CALCETrWKwQVe46gASNbb0miwcuHe+wirVSO-pQt6uF-Jd6e-bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-06 8:13 ` Borislav Petkov
2015-03-06 11:41 ` Kweh, Hock Leong
[not found] ` <F54AEECA5E2B9541821D670476DAE19C2B8AF844-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-06 14:47 ` Borislav Petkov
2015-03-06 12:20 ` Kweh, Hock Leong
2015-03-06 19:05 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313144213.GA19009@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=boon.leong.ong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).