* [PATCH] efi: make unexported efi_rci2_sysfs_init static
@ 2019-09-25 13:12 Ben Dooks
2019-09-25 15:20 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2019-09-25 13:12 UTC (permalink / raw)
To: Ard Biesheuvel, linux-efi, linux-kernel; +Cc: linux-kernel, Ben Dooks
The efi_rci2_sysfs_init() is not used outside of rci2-table.c so
make it static to silence the following sparse warning:
drivers/firmware/efi/rci2-table.c:79:12: warning: symbol 'efi_rci2_sysfs_init' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/firmware/efi/rci2-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/rci2-table.c b/drivers/firmware/efi/rci2-table.c
index 3e290f96620a..76b0c354a027 100644
--- a/drivers/firmware/efi/rci2-table.c
+++ b/drivers/firmware/efi/rci2-table.c
@@ -76,7 +76,7 @@ static u16 checksum(void)
return chksum;
}
-int __init efi_rci2_sysfs_init(void)
+static int __init efi_rci2_sysfs_init(void)
{
struct kobject *tables_kobj;
int ret = -ENOMEM;
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] efi: make unexported efi_rci2_sysfs_init static
2019-09-25 13:12 [PATCH] efi: make unexported efi_rci2_sysfs_init static Ben Dooks
@ 2019-09-25 15:20 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2019-09-25 15:20 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-efi, Linux Kernel Mailing List, linux-kernel
On Wed, 25 Sep 2019 at 15:12, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The efi_rci2_sysfs_init() is not used outside of rci2-table.c so
> make it static to silence the following sparse warning:
>
> drivers/firmware/efi/rci2-table.c:79:12: warning: symbol 'efi_rci2_sysfs_init' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/firmware/efi/rci2-table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/rci2-table.c b/drivers/firmware/efi/rci2-table.c
> index 3e290f96620a..76b0c354a027 100644
> --- a/drivers/firmware/efi/rci2-table.c
> +++ b/drivers/firmware/efi/rci2-table.c
> @@ -76,7 +76,7 @@ static u16 checksum(void)
> return chksum;
> }
>
> -int __init efi_rci2_sysfs_init(void)
> +static int __init efi_rci2_sysfs_init(void)
> {
> struct kobject *tables_kobj;
> int ret = -ENOMEM;
> --
> 2.23.0
>
Thanks Ben.
Queued in efi/urgent
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-25 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 13:12 [PATCH] efi: make unexported efi_rci2_sysfs_init static Ben Dooks
2019-09-25 15:20 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).