linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [efi:next 5/13] arch/x86/platform/efi/efi_64.c:77:7: sparse: sparse: symbol 'efi_old_memmap_phys_prolog' was not declared. Should it be static?
@ 2019-12-31 18:50 kbuild test robot
  2019-12-31 18:50 ` [RFC PATCH efi] efi/x86: efi_old_memmap_phys_prolog() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-12-31 18:50 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: kbuild-all, linux-efi

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
head:   3cf7227ba765babbcee59c572cd54bda019af183
commit: 68f6b351cf93faf6977a623ef5b2913a8064d67f [5/13] efi/x86: split off some old memmap handling into separate routines
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-129-g341daf20-dirty
        git checkout 68f6b351cf93faf6977a623ef5b2913a8064d67f
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> arch/x86/platform/efi/efi_64.c:77:7: sparse: sparse: symbol 'efi_old_memmap_phys_prolog' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH efi] efi/x86: efi_old_memmap_phys_prolog() can be static
  2019-12-31 18:50 [efi:next 5/13] arch/x86/platform/efi/efi_64.c:77:7: sparse: sparse: symbol 'efi_old_memmap_phys_prolog' was not declared. Should it be static? kbuild test robot
@ 2019-12-31 18:50 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-12-31 18:50 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: kbuild-all, linux-efi


Fixes: 68f6b351cf93 ("efi/x86: split off some old memmap handling into separate routines")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 efi_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index a72bbabbc5953..211899fb1ce2c 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -74,7 +74,7 @@ static void __init early_code_mapping_set_exec(int executable)
 
 void __init efi_old_memmap_phys_epilog(pgd_t *save_pgd);
 
-pgd_t * __init efi_old_memmap_phys_prolog(void)
+static pgd_t * __init efi_old_memmap_phys_prolog(void)
 {
 	unsigned long vaddr, addr_pgd, addr_p4d, addr_pud;
 	pgd_t *save_pgd, *pgd_k, *pgd_efi;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-31 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-31 18:50 [efi:next 5/13] arch/x86/platform/efi/efi_64.c:77:7: sparse: sparse: symbol 'efi_old_memmap_phys_prolog' was not declared. Should it be static? kbuild test robot
2019-12-31 18:50 ` [RFC PATCH efi] efi/x86: efi_old_memmap_phys_prolog() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).