From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH 0/3] efi/x86: Some mixed mode fixes
Date: Thu, 13 Feb 2020 11:20:59 +0100 [thread overview]
Message-ID: <20200213102102.30170-1-ardb@kernel.org> (raw)
Hans reports that v5.6-rc1 triggers a WARN() when booting in mixed mode,
which appears to be due to the fact that a GUID argument allocated on
the vmap'ed stack and passed by reference to the EFI runtime services
is no longer aligned to its size, which is what the mixed mode runtime
wrappers expect.
Let's fix this in a way that doesn't burden the caller, and copy the
GUID into a suitably aligned buffer in the runtime wrappers. (#1)
Then, patches #2 and #3 are additional cleanup and correctness fixes
for the mixed mode runtime wrappers.
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Andy Lutomirski <luto@amacapital.net>
Ard Biesheuvel (3):
efi/x86: align GUIDs to their size in the mixed mode runtime wrapper
efi/x86: remove support for EFI time and counter services in mixed
mode
efi/x86: Handle by-ref arguments covering multiple pages in mixed mode
arch/x86/platform/efi/efi_64.c | 151 +++++++-------------
1 file changed, 52 insertions(+), 99 deletions(-)
--
2.17.1
next reply other threads:[~2020-02-13 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 10:20 Ard Biesheuvel [this message]
2020-02-13 10:21 ` [PATCH 1/3] efi/x86: align GUIDs to their size in the mixed mode runtime wrapper Ard Biesheuvel
2020-02-14 12:55 ` Hans de Goede
2020-02-14 13:35 ` Ard Biesheuvel
2020-02-13 10:21 ` [PATCH 2/3] efi/x86: remove support for EFI time and counter services in mixed mode Ard Biesheuvel
2020-02-13 10:21 ` [PATCH 3/3] efi/x86: Handle by-ref arguments covering multiple pages " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213102102.30170-1-ardb@kernel.org \
--to=ardb@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nivedita@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).