[PATCH] x86/efi: Add a prototype for efi_arch_mem_reserve()

[PATCH] x86/efi: Add a prototype for efi_arch_mem_reserve()

[Benjamin Thiel]

... in order to fix a -Wmissing-ptototypes warning:

arch/x86/platform/efi/quirks.c:245:13: warning:
no previous prototype for ‘efi_arch_mem_reserve’ [-Wmissing-prototypes]
void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size)

Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
---
 include/linux/efi.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/efi.h b/include/linux/efi.h
index 7efd7072cca5..e4b28ae1ba61 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -1703,4 +1703,6 @@ struct linux_efi_memreserve {
 
 void efi_pci_disable_bridge_busmaster(void);
 
+void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size);
+
 #endif /* _LINUX_EFI_H */
-- 
2.17.1

Re: [PATCH] x86/efi: Add a prototype for efi_arch_mem_reserve()

[Ard Biesheuvel]

On Thu, 26 Mar 2020 at 14:50, Benjamin Thiel <b.thiel@posteo.de> wrote:
>
> ... in order to fix a -Wmissing-ptototypes warning:
>
> arch/x86/platform/efi/quirks.c:245:13: warning:
> no previous prototype for ‘efi_arch_mem_reserve’ [-Wmissing-prototypes]
> void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size)
>
> Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>

Thanks. I'll queue this as a fix.

> ---
>  include/linux/efi.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 7efd7072cca5..e4b28ae1ba61 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -1703,4 +1703,6 @@ struct linux_efi_memreserve {
>
>  void efi_pci_disable_bridge_busmaster(void);
>
> +void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size);
> +
>  #endif /* _LINUX_EFI_H */
> --
> 2.17.1
>

Re: [PATCH] x86/efi: Add a prototype for efi_arch_mem_reserve()

[Borislav Petkov]

On Wed, Apr 08, 2020 at 07:39:56PM +0200, Ard Biesheuvel wrote:
> On Thu, 26 Mar 2020 at 14:50, Benjamin Thiel <b.thiel@posteo.de> wrote:
> >
> > ... in order to fix a -Wmissing-ptototypes warning:
> >
> > arch/x86/platform/efi/quirks.c:245:13: warning:
> > no previous prototype for ‘efi_arch_mem_reserve’ [-Wmissing-prototypes]
> > void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size)
> >
> > Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
> 
> Thanks. I'll queue this as a fix.

I already took that one, see:

860f89e61824 ("x86/efi: Add a prototype for efi_arch_mem_reserve()")

but forgot to Cc: linux-efi@.

Sorry about that.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] x86/efi: Add a prototype for efi_arch_mem_reserve()

[Ard Biesheuvel]

On Wed, 8 Apr 2020 at 19:58, Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Apr 08, 2020 at 07:39:56PM +0200, Ard Biesheuvel wrote:
> > On Thu, 26 Mar 2020 at 14:50, Benjamin Thiel <b.thiel@posteo.de> wrote:
> > >
> > > ... in order to fix a -Wmissing-ptototypes warning:
> > >
> > > arch/x86/platform/efi/quirks.c:245:13: warning:
> > > no previous prototype for ‘efi_arch_mem_reserve’ [-Wmissing-prototypes]
> > > void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size)
> > >
> > > Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
> >
> > Thanks. I'll queue this as a fix.
>
> I already took that one, see:
>
> 860f89e61824 ("x86/efi: Add a prototype for efi_arch_mem_reserve()")
>
> but forgot to Cc: linux-efi@.
>
> Sorry about that.
>

No worries.