* [RFC] x86/mm: only allow memmap=XX!YY over existing RAM
@ 2016-06-19 12:49 Yigal Korman
[not found] ` <1466340570-2471502-1-git-send-email-yigal-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Yigal Korman @ 2016-06-19 12:49 UTC (permalink / raw)
To: matt-mF/unelCI9GS6iBeEJttW/XRex20P6io, linux-efi-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw
Before this patch, passing a range that is beyond the physical memory
range will succeed, the user will see a /dev/pmem0 and will be able to
access it. Reads will always return 0 and writes will be silently
ignored.
I've gotten more than one bug report about mkfs.{xfs,ext4} or nvml
failing that were eventually tracked down to be wrong values passed to
memmap.
This patch prevents the above issue by instead of adding a new memory
range, only update a RAM memory range with the PRAM type. This way,
passing the wrong memmap will either not give you a pmem at all or give
you a smaller one that actually has RAM behind it.
And if someone still needs to fake a pmem that doesn't have RAM behind
it, they can simply do memmap=XX@YY,XX!YY.
Signed-off-by: Yigal Korman <yigal-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org>
---
arch/x86/kernel/e820.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 569c1e4..bcd2ebb1 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -877,7 +877,7 @@ static int __init parse_memmap_one(char *p)
e820_add_region(start_at, mem_size, E820_RESERVED);
} else if (*p == '!') {
start_at = memparse(p+1, &p);
- e820_add_region(start_at, mem_size, E820_PRAM);
+ e820_update_range(start_at, mem_size, E820_RAM, E820_PRAM);
} else
e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] x86/mm: only allow memmap=XX!YY over existing RAM
[not found] ` <1466340570-2471502-1-git-send-email-yigal-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org>
@ 2016-06-19 16:40 ` Dan Williams
[not found] ` <CAPcyv4hiOwx5LM+80Hz7jWnidMrKVjY9V5B3zS7y_g7C1KLoYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2016-06-19 16:40 UTC (permalink / raw)
To: Yigal Korman
Cc: Matt Fleming, linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw, Elliott,
Robert (Persistent Memory),
jmoyer, Toshi Kani
On Sun, Jun 19, 2016 at 5:49 AM, Yigal Korman <yigal-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org> wrote:
> Before this patch, passing a range that is beyond the physical memory
> range will succeed, the user will see a /dev/pmem0 and will be able to
> access it. Reads will always return 0 and writes will be silently
> ignored.
>
> I've gotten more than one bug report about mkfs.{xfs,ext4} or nvml
> failing that were eventually tracked down to be wrong values passed to
> memmap.
>
> This patch prevents the above issue by instead of adding a new memory
> range, only update a RAM memory range with the PRAM type. This way,
> passing the wrong memmap will either not give you a pmem at all or give
> you a smaller one that actually has RAM behind it.
>
> And if someone still needs to fake a pmem that doesn't have RAM behind
> it, they can simply do memmap=XX@YY,XX!YY.
Thanks! I've debugged a report like this as well.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] x86/mm: only allow memmap=XX!YY over existing RAM
[not found] ` <CAPcyv4hiOwx5LM+80Hz7jWnidMrKVjY9V5B3zS7y_g7C1KLoYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-06-20 7:33 ` Yigal Korman
0 siblings, 0 replies; 3+ messages in thread
From: Yigal Korman @ 2016-06-20 7:33 UTC (permalink / raw)
To: Dan Williams
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw, Matt Fleming
Hi,
I've sent this to the wrong maintainer by mistake (sorry about that)
so I going to re-post it again in a moment.
FYI
Thanks,
Yigal
On Sun, Jun 19, 2016 at 7:40 PM, Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> On Sun, Jun 19, 2016 at 5:49 AM, Yigal Korman <yigal-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org> wrote:
>> Before this patch, passing a range that is beyond the physical memory
>> range will succeed, the user will see a /dev/pmem0 and will be able to
>> access it. Reads will always return 0 and writes will be silently
>> ignored.
>>
>> I've gotten more than one bug report about mkfs.{xfs,ext4} or nvml
>> failing that were eventually tracked down to be wrong values passed to
>> memmap.
>>
>> This patch prevents the above issue by instead of adding a new memory
>> range, only update a RAM memory range with the PRAM type. This way,
>> passing the wrong memmap will either not give you a pmem at all or give
>> you a smaller one that actually has RAM behind it.
>>
>> And if someone still needs to fake a pmem that doesn't have RAM behind
>> it, they can simply do memmap=XX@YY,XX!YY.
>
> Thanks! I've debugged a report like this as well.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-20 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-19 12:49 [RFC] x86/mm: only allow memmap=XX!YY over existing RAM Yigal Korman
[not found] ` <1466340570-2471502-1-git-send-email-yigal-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org>
2016-06-19 16:40 ` Dan Williams
[not found] ` <CAPcyv4hiOwx5LM+80Hz7jWnidMrKVjY9V5B3zS7y_g7C1KLoYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-20 7:33 ` Yigal Korman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).