Re: [PATCH] Revert "x86/mm/ASLR: Propagate base load address calculation"

From: Yinghai Lu <yinghai@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
	Matt Fleming <matt.fleming@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Kees Cook <keescook@chromium.org>, Baoquan He <bhe@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Junjie Mao <eternal.n08@gmail.com>
Subject: Re: [PATCH] Revert "x86/mm/ASLR: Propagate base load address calculation"
Date: Mon, 16 Mar 2015 12:15:27 -0700	[thread overview]
Message-ID: <CAE9FiQU4xD9Jafbu7X=NDyBzRWAXnLqM0F-aCuVMVYgkqFp6sw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1503161441280.25438@pobox.suse.cz>

On Mon, Mar 16, 2015 at 6:56 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Mon, 16 Mar 2015, Borislav Petkov wrote:
>> From: Borislav Petkov <bp@suse.de>
>> Date: Mon, 16 Mar 2015 10:57:56 +0100
>> Subject: [PATCH] Revert "x86/mm/ASLR: Propagate base load address calculation"
>>
>> This reverts commit f47233c2d34f243ecdaac179c3408a39ff9216a7.
...
>
> Agreed. Let's work on a better refresh for 4.1+. The fix attempts were
> quite chaotic.

Then what is the plan for 4.1+ ?

Are you still going to use kaslr_setup_data?
If if is YES, then we should have
patch1: https://lkml.org/lkml/2015/3/15/7
patch2:
f47233c2d34f243ecdaac179c3408a39ff9216a7 + fix from
https://lkml.org/lkml/2015/3/15/8

If you are not going to have setup_data and
f47233c2d34f243ecdaac179c3408a39ff9216a7
back, please let me know.
I may need to change patch in  https://lkml.org/lkml/2015/3/15/7,
So it only have ADDON_ZO_SIZE with pgtable only and
we can go on with kaslr on 64bit above 4G support.

Thanks

Yinghai