* [PATCH] efi/x86: Fix cast of image argument
@ 2020-03-05 14:36 Arvind Sankar
2020-03-05 14:56 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Sankar @ 2020-03-05 14:36 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-efi
handle_protocol expects void **, not void *.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
---
drivers/firmware/efi/libstub/x86-stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
index fbc4354f534c..95b29d8bf8e4 100644
--- a/drivers/firmware/efi/libstub/x86-stub.c
+++ b/drivers/firmware/efi/libstub/x86-stub.c
@@ -383,7 +383,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
if (sys_table->hdr.signature != EFI_SYSTEM_TABLE_SIGNATURE)
efi_exit(handle, EFI_INVALID_PARAMETER);
- status = efi_bs_call(handle_protocol, handle, &proto, (void *)&image);
+ status = efi_bs_call(handle_protocol, handle, &proto, (void **)&image);
if (status != EFI_SUCCESS) {
efi_printk("Failed to get handle for LOADED_IMAGE_PROTOCOL\n");
efi_exit(handle, status);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] efi/x86: Fix cast of image argument
2020-03-05 14:36 [PATCH] efi/x86: Fix cast of image argument Arvind Sankar
@ 2020-03-05 14:56 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-03-05 14:56 UTC (permalink / raw)
To: Arvind Sankar; +Cc: linux-efi
On Thu, 5 Mar 2020 at 15:36, Arvind Sankar <nivedita@alum.mit.edu> wrote:
>
> handle_protocol expects void **, not void *.
>
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Queued, thanks
> ---
> drivers/firmware/efi/libstub/x86-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
> index fbc4354f534c..95b29d8bf8e4 100644
> --- a/drivers/firmware/efi/libstub/x86-stub.c
> +++ b/drivers/firmware/efi/libstub/x86-stub.c
> @@ -383,7 +383,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
> if (sys_table->hdr.signature != EFI_SYSTEM_TABLE_SIGNATURE)
> efi_exit(handle, EFI_INVALID_PARAMETER);
>
> - status = efi_bs_call(handle_protocol, handle, &proto, (void *)&image);
> + status = efi_bs_call(handle_protocol, handle, &proto, (void **)&image);
> if (status != EFI_SUCCESS) {
> efi_printk("Failed to get handle for LOADED_IMAGE_PROTOCOL\n");
> efi_exit(handle, status);
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-05 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 14:36 [PATCH] efi/x86: Fix cast of image argument Arvind Sankar
2020-03-05 14:56 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).