Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Atish Patra <Atish.Patra@wdc.com>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"nivedita@alum.mit.edu" <nivedita@alum.mit.edu>,
	"lukas@wunner.de" <lukas@wunner.de>
Subject: Re: [PATCH 13/19] efi/libstub: Move get_dram_base() into arm-stub.c
Date: Thu, 27 Feb 2020 08:38:00 +0100
Message-ID: <CAKv+Gu_NZA8u4QU=KjwNgseWh4=hHWpxDwgn79S1ortj+cSB9g@mail.gmail.com> (raw)
In-Reply-To: <00a157796e420dbc8dee08ae2592daecde8bb07b.camel@wdc.com>

On Thu, 27 Feb 2020 at 00:35, Atish Patra <Atish.Patra@wdc.com> wrote:
>
> On Mon, 2020-02-17 at 09:37 +0100, Ard Biesheuvel wrote:
> > On Mon, 17 Feb 2020 at 02:17, Atish Patra <Atish.Patra@wdc.com>
> > wrote:
> > > On Mon, 2020-02-10 at 17:02 +0100, Ard Biesheuvel wrote:
> > > > get_dram_base() is only called from arm-stub.c so move it into
> > > > the same source file as its caller.
> > > >
> > >
> > > Just FYI: riscv efi stub port is also going to use get_dram_base().
> > > However, I have renamed arm-stub.c to generic efi-stub.c so that
> > > arm,
> > > arm64 and riscv can reuse it. Thus, Moving get_dram_base() into
> > > arm-
> > > stub.c works for riscv as well. I will rebase my patches on top of
> > > this
> > > series.
> > >
> >
> > Thanks Atish. I was hoping it would turn out like this, which is why
> > I
> > am pushing this series now.
> >
> > I haven't looked at your code yet, but please avoid using the command
> > line based initrd/dtb loading routines. I am proposing a cleaner way
> > to provide the initrd from firmware [0], and dtb loading by the stub
> > should not be done in the first place.
> >
> > [0]
> > https://lore.kernel.org/linux-efi/20200216141104.21477-1-ardb@kernel.org/
>
> Sorry I missed this email earlier. Yes I am not using initrd or dtb
> loading from U-Boot command line.
>

If you use arm-stub.c mostly unmodified, you will be using initrd=
command line loading, and it would be better to disable that, and only
enable it if there is a request for it (which I doubt will happen).

  reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 16:02 [PATCH 00/19] EFI stub early spring cleaning part 2 Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 01/19] efi/libstub/x86: Remove pointless zeroing of apm_bios_info Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 02/19] efi/libstub/x86: Avoid overflowing code32_start on PE entry Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 03/19] efi/libstub: Use hidden visiblity for all source files Ard Biesheuvel
2020-02-24 23:15   ` Atish Patra
2020-02-24 23:36     ` Ard Biesheuvel
2020-02-25 19:18       ` Atish Patra
2020-02-10 16:02 ` [PATCH 04/19] efi/libstub/arm: Relax FDT alignment requirement Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 05/19] efi/libstub: Move memory map handling and allocation routines to mem.c Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 06/19] efi/libstub: Simplify efi_high_alloc() and rename to efi_allocate_pages() Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 07/19] efi/libstub/x86: Incorporate eboot.c into libstub Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 08/19] efi/libstub: Use consistent type names for file I/O protocols Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 09/19] efi/libstub: Move stub specific declarations into efistub.h Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 10/19] efi/libstub/x86: Permit bootparams struct to be allocated above 4 GB Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 11/19] efi/libstub/x86: Permit cmdline data " Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 12/19] efi/libstub: Move efi_random_alloc() into separate source file Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 13/19] efi/libstub: Move get_dram_base() into arm-stub.c Ard Biesheuvel
2020-02-17  1:17   ` Atish Patra
2020-02-17  8:37     ` Ard Biesheuvel
2020-02-26 23:34       ` Atish Patra
2020-02-27  7:38         ` Ard Biesheuvel [this message]
2020-02-27  7:48           ` Atish Patra
2020-02-27  7:50             ` Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 14/19] efi/libstub: Move file I/O support code into separate file Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 15/19] efi/libstub: Rewrite file I/O routine Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 16/19] efi/libstub: Take soft and hard memory limits into account for initrd loading Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 17/19] efi/libstub: Clean up command line parsing routine Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 18/19] efi/libstub: Expose LocateDevicePath boot service Ard Biesheuvel
2020-02-10 16:02 ` [PATCH 19/19] efi/libstub: Make the LoadFile EFI protocol accessible Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_NZA8u4QU=KjwNgseWh4=hHWpxDwgn79S1ortj+cSB9g@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=Atish.Patra@wdc.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mingo@kernel.org \
    --cc=nivedita@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git