linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] efi/x86: Remove unused variables
@ 2020-06-18 19:10 Arvind Sankar
  2020-06-25 16:06 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Sankar @ 2020-06-18 19:10 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: linux-efi

Commit
  987053a30016 ("efi/x86: Move command-line initrd loading to efi_main")
made the ramdisk_addr/ramdisk_size variables in efi_pe_entry unused, but
neglected to delete them.

Delete these unused variables.

Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
---
 drivers/firmware/efi/libstub/x86-stub.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
index 5a48d996ed71..37e82bf397aa 100644
--- a/drivers/firmware/efi/libstub/x86-stub.c
+++ b/drivers/firmware/efi/libstub/x86-stub.c
@@ -361,8 +361,6 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
 	int options_size = 0;
 	efi_status_t status;
 	char *cmdline_ptr;
-	unsigned long ramdisk_addr;
-	unsigned long ramdisk_size;
 
 	efi_system_table = sys_table_arg;
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] efi/x86: Remove unused variables
  2020-06-18 19:10 [PATCH] efi/x86: Remove unused variables Arvind Sankar
@ 2020-06-25 16:06 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-06-25 16:06 UTC (permalink / raw)
  To: Arvind Sankar; +Cc: linux-efi

On Thu, 18 Jun 2020 at 21:11, Arvind Sankar <nivedita@alum.mit.edu> wrote:
>
> Commit
>   987053a30016 ("efi/x86: Move command-line initrd loading to efi_main")
> made the ramdisk_addr/ramdisk_size variables in efi_pe_entry unused, but
> neglected to delete them.
>
> Delete these unused variables.
>
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>

Queued as a fix, thanks.

> ---
>  drivers/firmware/efi/libstub/x86-stub.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
> index 5a48d996ed71..37e82bf397aa 100644
> --- a/drivers/firmware/efi/libstub/x86-stub.c
> +++ b/drivers/firmware/efi/libstub/x86-stub.c
> @@ -361,8 +361,6 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
>         int options_size = 0;
>         efi_status_t status;
>         char *cmdline_ptr;
> -       unsigned long ramdisk_addr;
> -       unsigned long ramdisk_size;
>
>         efi_system_table = sys_table_arg;
>
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-25 16:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 19:10 [PATCH] efi/x86: Remove unused variables Arvind Sankar
2020-06-25 16:06 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).