* [PATCH 1/1] efi/efivars: ConInDev, ConOutDev, ConErrDev are volatile
@ 2021-02-18 20:18 Heinrich Schuchardt
2021-02-20 14:50 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2021-02-18 20:18 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-efi, linux-kernel, Heinrich Schuchardt
UEFI variables ConInDev, ConOutDev, ConErrDev are volatile variables that
are set by the firmware on every reset. It does not make sense to set these
variables via the efivarfs filesystem.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/firmware/efi/vars.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c
index 41c1d00bf933..561e0a01093b 100644
--- a/drivers/firmware/efi/vars.c
+++ b/drivers/firmware/efi/vars.c
@@ -180,11 +180,8 @@ static const struct variable_validate variable_validate[] = {
{ EFI_GLOBAL_VARIABLE_GUID, "DriverOrder", validate_boot_order },
{ EFI_GLOBAL_VARIABLE_GUID, "Driver*", validate_load_option },
{ EFI_GLOBAL_VARIABLE_GUID, "ConIn", validate_device_path },
- { EFI_GLOBAL_VARIABLE_GUID, "ConInDev", validate_device_path },
{ EFI_GLOBAL_VARIABLE_GUID, "ConOut", validate_device_path },
- { EFI_GLOBAL_VARIABLE_GUID, "ConOutDev", validate_device_path },
{ EFI_GLOBAL_VARIABLE_GUID, "ErrOut", validate_device_path },
- { EFI_GLOBAL_VARIABLE_GUID, "ErrOutDev", validate_device_path },
{ EFI_GLOBAL_VARIABLE_GUID, "Lang", validate_ascii_string },
{ EFI_GLOBAL_VARIABLE_GUID, "OsIndications", NULL },
{ EFI_GLOBAL_VARIABLE_GUID, "PlatformLang", validate_ascii_string },
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] efi/efivars: ConInDev, ConOutDev, ConErrDev are volatile
2021-02-18 20:18 [PATCH 1/1] efi/efivars: ConInDev, ConOutDev, ConErrDev are volatile Heinrich Schuchardt
@ 2021-02-20 14:50 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2021-02-20 14:50 UTC (permalink / raw)
To: Heinrich Schuchardt, Peter Jones; +Cc: linux-efi, Linux Kernel Mailing List
(cc Peter)
On Thu, 18 Feb 2021 at 21:18, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> UEFI variables ConInDev, ConOutDev, ConErrDev are volatile variables that
> are set by the firmware on every reset. It does not make sense to set these
> variables via the efivarfs filesystem.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/firmware/efi/vars.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c
> index 41c1d00bf933..561e0a01093b 100644
> --- a/drivers/firmware/efi/vars.c
> +++ b/drivers/firmware/efi/vars.c
> @@ -180,11 +180,8 @@ static const struct variable_validate variable_validate[] = {
> { EFI_GLOBAL_VARIABLE_GUID, "DriverOrder", validate_boot_order },
> { EFI_GLOBAL_VARIABLE_GUID, "Driver*", validate_load_option },
> { EFI_GLOBAL_VARIABLE_GUID, "ConIn", validate_device_path },
> - { EFI_GLOBAL_VARIABLE_GUID, "ConInDev", validate_device_path },
> { EFI_GLOBAL_VARIABLE_GUID, "ConOut", validate_device_path },
> - { EFI_GLOBAL_VARIABLE_GUID, "ConOutDev", validate_device_path },
> { EFI_GLOBAL_VARIABLE_GUID, "ErrOut", validate_device_path },
> - { EFI_GLOBAL_VARIABLE_GUID, "ErrOutDev", validate_device_path },
> { EFI_GLOBAL_VARIABLE_GUID, "Lang", validate_ascii_string },
> { EFI_GLOBAL_VARIABLE_GUID, "OsIndications", NULL },
> { EFI_GLOBAL_VARIABLE_GUID, "PlatformLang", validate_ascii_string },
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-20 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 20:18 [PATCH 1/1] efi/efivars: ConInDev, ConOutDev, ConErrDev are volatile Heinrich Schuchardt
2021-02-20 14:50 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).