* [PATCH -next] efi/libstub/arm: Make install_memreserve_table static
@ 2020-04-23 12:08 Zou Wei
2020-04-23 12:16 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-04-23 12:08 UTC (permalink / raw)
To: ardb; +Cc: linux-efi, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/firmware/efi/libstub/arm-stub.c:68:6: warning:
symbol 'install_memreserve_table' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/firmware/efi/libstub/arm-stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/arm-stub.c b/drivers/firmware/efi/libstub/arm-stub.c
index 99a5cde..8a26cc1 100644
--- a/drivers/firmware/efi/libstub/arm-stub.c
+++ b/drivers/firmware/efi/libstub/arm-stub.c
@@ -65,7 +65,7 @@ static struct screen_info *setup_graphics(void)
return si;
}
-void install_memreserve_table(void)
+static void install_memreserve_table(void)
{
struct linux_efi_memreserve *rsv;
efi_guid_t memreserve_table_guid = LINUX_EFI_MEMRESERVE_TABLE_GUID;
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] efi/libstub/arm: Make install_memreserve_table static
2020-04-23 12:08 [PATCH -next] efi/libstub/arm: Make install_memreserve_table static Zou Wei
@ 2020-04-23 12:16 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-04-23 12:16 UTC (permalink / raw)
To: Zou Wei; +Cc: linux-efi, Linux Kernel Mailing List
On Thu, 23 Apr 2020 at 14:02, Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/firmware/efi/libstub/arm-stub.c:68:6: warning:
> symbol 'install_memreserve_table' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/firmware/efi/libstub/arm-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/arm-stub.c b/drivers/firmware/efi/libstub/arm-stub.c
> index 99a5cde..8a26cc1 100644
> --- a/drivers/firmware/efi/libstub/arm-stub.c
> +++ b/drivers/firmware/efi/libstub/arm-stub.c
> @@ -65,7 +65,7 @@ static struct screen_info *setup_graphics(void)
> return si;
> }
>
> -void install_memreserve_table(void)
> +static void install_memreserve_table(void)
> {
> struct linux_efi_memreserve *rsv;
> efi_guid_t memreserve_table_guid = LINUX_EFI_MEMRESERVE_TABLE_GUID;
> --
> 2.6.2
>
Applied to efi/next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-23 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 12:08 [PATCH -next] efi/libstub/arm: Make install_memreserve_table static Zou Wei
2020-04-23 12:16 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).