From: Ard Biesheuvel <ardb@kernel.org>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
wangle6@huawei.com
Subject: Re: [PATCH] efi:mokvar-table: fix build error
Date: Fri, 9 Oct 2020 10:52:31 +0200 [thread overview]
Message-ID: <CAMj1kXFfN-dFAu+veu_0j2KAqWisZ8hy-1f3S4Y88tHC7bxxHA@mail.gmail.com> (raw)
In-Reply-To: <20201009085106.125079-1-nixiaoming@huawei.com>
On Fri, 9 Oct 2020 at 10:51, Xiaoming Ni <nixiaoming@huawei.com> wrote:
>
> drivers/firmware/efi/mokvar-table.c:139:5: error: implicit declaration of
> function 'early_memunmap'; did you mean 'devm_memunmap'?
> [-Werror=implicit-function-declaration]
> drivers/firmware/efi/mokvar-table.c:148:9: error: implicit declaration of
> function 'early_memremap'; did you mean 'devm_memremap'?
> [-Werror=implicit-function-declaration]
>
> add #include <asm/early_ioremap.h> to fix this build error
>
> Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
Thank you Xiaoming. We already have a fix queued up for this issue.
> ---
> drivers/firmware/efi/mokvar-table.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/mokvar-table.c b/drivers/firmware/efi/mokvar-table.c
> index 72a9e1736fef..c23d3686f1c7 100644
> --- a/drivers/firmware/efi/mokvar-table.c
> +++ b/drivers/firmware/efi/mokvar-table.c
> @@ -39,6 +39,7 @@
> #include <linux/kobject.h>
> #include <linux/list.h>
> #include <linux/slab.h>
> +#include <asm/early_ioremap.h>
>
> /*
> * The LINUX_EFI_MOK_VARIABLE_TABLE_GUID config table is a packed
> --
> 2.27.0
>
prev parent reply other threads:[~2020-10-09 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 8:51 [PATCH] efi:mokvar-table: fix build error Xiaoming Ni
2020-10-09 8:52 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFfN-dFAu+veu_0j2KAqWisZ8hy-1f3S4Y88tHC7bxxHA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=wangle6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).