From: Hans de Goede <hdegoede@redhat.com>
To: Wolfram Sang <wsa@the-dreams.de>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Sebastian Reichel <sre@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Ard Biesheuvel <ardb@kernel.org>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Yauhen Kharuzhy <jekhor@gmail.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org
Subject: Re: [PATCH v2 15/20] i2c: cht-wc: Make charger i2c-client instantiation board/device-model specific
Date: Sun, 28 Nov 2021 15:04:17 +0100 [thread overview]
Message-ID: <af5c448d-0552-abb7-eaf3-8c95116d7733@redhat.com> (raw)
In-Reply-To: <YZylRkOQsj9LpG5U@kunai>
Hi,
On 11/23/21 09:24, Wolfram Sang wrote:
> On Sun, Nov 14, 2021 at 06:03:30PM +0100, Hans de Goede wrote:
>> The i2c-controller on the Cherry Trail - Whiskey Cove PMIC is special
>> in that it is always connected to the I2C charger IC of the board on
>> which the PMIC is used; and the charger IC is not described in ACPI,
>> so the i2c-cht-wc code needs to instantiate an i2c-client for it itself.
>>
>> So far this was hardcoded to instantiate an i2c-client for the
>> bq24292i, with all properties, etc. set to match how this charger
>> is used on the GPD win and GPD pcoket devices.
>>
>> There is a rudimentary check to make sure the ACPI tables are at least
>> somewhat as expected, but this is far from accurate, leading to
>> a wrong i2c-client being instantiated for the charger on some boards.
>>
>> Switch to the new DMI based intel_cht_wc_get_model() helper which is
>> exported by the MFD driver for the CHT Whiskey Cove PMIC to help PMIC
>> cell drivers like the i2c-cht-wc code reliably detect which board
>> they are running on.
>>
>> And add board_info for the charger ICs as found on the other 2 known
>> boards with a Whisky Cove PMIC.
>>
>> This has been tested on all 3 known boards.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Here is my Ack to take this via some other tree:
>
> Acked-by: Wolfram Sang <wsa@kernel.org>
Great, thank you.
> No need to send further versions of this series to the i2c-list, I'd
> think.
Ok I will drop the i2c-list from the Cc for further versions of this series.
Regards,
Hans
next prev parent reply other threads:[~2021-11-28 14:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 17:03 [PATCH v2 00/20] power-suppy/i2c/extcon: Fix charger setup on Xiaomi Mi Pad 2 and Lenovo Yogabook Hans de Goede
2021-11-14 17:03 ` [PATCH v2 01/20] power: supply: core: Refactor power_supply_set_input_current_limit_from_supplier() Hans de Goede
2021-11-14 17:03 ` [PATCH v2 02/20] power: supply: bq25890: Fix ADC continuous conversion setting when charging Hans de Goede
2021-11-14 17:03 ` [PATCH v2 03/20] power: supply: bq25890: Rename IILIM field to IINLIM Hans de Goede
2021-11-14 17:03 ` [PATCH v2 04/20] power: supply: bq25890: Reduce reported CONSTANT_CHARGE_CURRENT_MAX for low temperatures Hans de Goede
2021-11-16 9:43 ` Hans de Goede
2021-11-14 17:03 ` [PATCH v2 05/20] power: supply: bq25890: Add a bq25890_rw_init_data() helper Hans de Goede
2021-11-14 17:03 ` [PATCH v2 06/20] power: supply: bq25890: Add support to skip reset at probe() / remove() Hans de Goede
2021-11-14 17:03 ` [PATCH v2 07/20] power: supply: bq25890: Add support to read back the settings from the chip Hans de Goede
2021-11-14 17:03 ` [PATCH v2 08/20] power: supply: bq25890: Enable charging on boards where we skip reset Hans de Goede
2021-11-14 17:03 ` [PATCH v2 09/20] power: supply: bq25890: Drop dev->platform_data == NULL check Hans de Goede
2021-11-16 11:02 ` Andy Shevchenko
2021-11-14 17:03 ` [PATCH v2 10/20] power: supply: bq25890: Add bq25890_set_otg_cfg() helper Hans de Goede
2021-11-15 10:11 ` Yauhen Kharuzhy
2021-11-16 9:33 ` Hans de Goede
[not found] ` <CAKWEGV7WVsZK=890UG=t3dhqCuoD-6N44DPMzk-_8TSPBm4_Dg@mail.gmail.com>
2021-11-28 15:02 ` Hans de Goede
2021-11-28 19:46 ` Yauhen Kharuzhy
2021-11-14 17:03 ` [PATCH v2 11/20] power: supply: bq25890: Add support for registering the Vbus boost converter as a regulator Hans de Goede
2021-11-16 11:05 ` Andy Shevchenko
2021-11-14 17:03 ` [PATCH v2 12/20] power: supply: bq25890: On the bq25892 set the IINLIM based on external charger detection Hans de Goede
2021-11-14 17:03 ` [PATCH v2 13/20] power: supply: bq25890: Support higher charging voltages through Pump Express+ protocol Hans de Goede
2021-11-16 11:14 ` Andy Shevchenko
2021-11-16 11:40 ` Hans de Goede
2021-11-14 17:03 ` [PATCH v2 14/20] mfd: intel_soc_pmic_chtwc: Add intel_cht_wc_get_model() helper function Hans de Goede
2021-11-16 11:18 ` Andy Shevchenko
2021-11-16 11:43 ` Hans de Goede
2021-11-28 9:53 ` Hans de Goede
2021-11-14 17:03 ` [PATCH v2 15/20] i2c: cht-wc: Make charger i2c-client instantiation board/device-model specific Hans de Goede
2021-11-16 11:20 ` Andy Shevchenko
2021-11-16 11:44 ` Hans de Goede
2021-11-23 8:24 ` Wolfram Sang
2021-11-28 14:04 ` Hans de Goede [this message]
2021-11-14 17:03 ` [PATCH v2 16/20] extcon: intel-cht-wc: Use new intel_cht_wc_get_model() helper Hans de Goede
2021-11-17 6:47 ` Chanwoo Choi
2021-11-17 22:28 ` Hans de Goede
2021-11-14 17:03 ` [PATCH v2 17/20] extcon: intel-cht-wc: Support devs with Micro-B / USB-2 only Type-C connectors Hans de Goede
2021-11-16 11:28 ` Andy Shevchenko
2021-11-16 11:31 ` Andy Shevchenko
2021-11-16 11:32 ` Andy Shevchenko
2021-11-16 11:51 ` Hans de Goede
2021-11-14 17:03 ` [PATCH v2 18/20] extcon: intel-cht-wc: Refactor cht_wc_extcon_get_charger() Hans de Goede
2021-11-17 7:15 ` Chanwoo Choi
2021-11-17 22:30 ` Hans de Goede
2021-11-19 15:44 ` Chanwoo Choi
2021-11-28 14:17 ` Hans de Goede
2021-11-14 17:03 ` [PATCH v2 19/20] extcon: intel-cht-wc: Add support for registering a power_supply class-device Hans de Goede
2021-11-16 15:19 ` Andy Shevchenko
2021-11-14 17:03 ` [PATCH v2 20/20] extcon: intel-cht-wc: Report RID_A for ACA adapters Hans de Goede
2021-11-16 11:00 ` [PATCH v2 00/20] power-suppy/i2c/extcon: Fix charger setup on Xiaomi Mi Pad 2 and Lenovo Yogabook Andy Shevchenko
2021-11-16 11:05 ` Hans de Goede
2021-11-17 18:56 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af5c448d-0552-abb7-eaf3-8c95116d7733@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=ardb@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=jekhor@gmail.com \
--cc=kitakar@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sre@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).