Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
From: Joe Perches <joe@perches.com>
To: Arvind Sankar <nivedita@alum.mit.edu>, Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages
Date: Wed, 29 Apr 2020 11:47:48 -0700
Message-ID: <f74fe4ad56c0471f863ce550869391c8811f9893.camel@perches.com> (raw)
In-Reply-To: <20200429174120.1497212-5-nivedita@alum.mit.edu>

On Wed, 2020-04-29 at 13:41 -0400, Arvind Sankar wrote:
> Use pr_efi_err instead of bare efi_printk for error messages.

Perhaps it'd be better to rename pr_efi_err to eri_err
to it's clearer it's a typical efi_ logging function.

$ git grep -w --name-only pr_efi_err | \
  xargs sed -i 's/\bpr_efi_err\b/efi_err/g'

Looking at code for efi_printk -> efi_char16_printk,
it's somewhat difficult to see where the "output_string"
function pointer is set.  Any clue?

> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
>  drivers/firmware/efi/libstub/x86-stub.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
> index 677b5a1e0543..933205772d8c 100644
> --- a/drivers/firmware/efi/libstub/x86-stub.c
> +++ b/drivers/firmware/efi/libstub/x86-stub.c
> @@ -49,7 +49,7 @@ preserve_pci_rom_image(efi_pci_io_protocol_t *pci, struct pci_setup_rom **__rom)
>  	status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, size,
>  			     (void **)&rom);
>  	if (status != EFI_SUCCESS) {
> -		efi_printk("Failed to allocate memory for 'rom'\n");
> +		pr_efi_err("Failed to allocate memory for 'rom'\n");
>  		return status;
>  	}
>  
> @@ -65,7 +65,7 @@ preserve_pci_rom_image(efi_pci_io_protocol_t *pci, struct pci_setup_rom **__rom)
>  				PCI_VENDOR_ID, 1, &rom->vendor);
>  
>  	if (status != EFI_SUCCESS) {
> -		efi_printk("Failed to read rom->vendor\n");
> +		pr_efi_err("Failed to read rom->vendor\n");
>  		goto free_struct;
>  	}
>  
> @@ -73,7 +73,7 @@ preserve_pci_rom_image(efi_pci_io_protocol_t *pci, struct pci_setup_rom **__rom)
>  				PCI_DEVICE_ID, 1, &rom->devid);
>  
>  	if (status != EFI_SUCCESS) {
> -		efi_printk("Failed to read rom->devid\n");
> +		pr_efi_err("Failed to read rom->devid\n");
>  		goto free_struct;
>  	}
>  
> @@ -118,7 +118,7 @@ static void setup_efi_pci(struct boot_params *params)
>  				     (void **)&pci_handle);
>  
>  		if (status != EFI_SUCCESS) {
> -			efi_printk("Failed to allocate memory for 'pci_handle'\n");
> +			pr_efi_err("Failed to allocate memory for 'pci_handle'\n");
>  			return;
>  		}
>  
> @@ -172,7 +172,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params)
>  		return;
>  
>  	if (efi_table_attr(p, version) != 0x10000) {
> -		efi_printk("Unsupported properties proto version\n");
> +		pr_efi_err("Unsupported properties proto version\n");
>  		return;
>  	}
>  
> @@ -185,7 +185,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params)
>  				     size + sizeof(struct setup_data),
>  				     (void **)&new);
>  		if (status != EFI_SUCCESS) {
> -			efi_printk("Failed to allocate memory for 'properties'\n");
> +			pr_efi_err("Failed to allocate memory for 'properties'\n");
>  			return;
>  		}
>  
> @@ -372,7 +372,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
>  
>  	status = efi_bs_call(handle_protocol, handle, &proto, (void **)&image);
>  	if (status != EFI_SUCCESS) {
> -		efi_printk("Failed to get handle for LOADED_IMAGE_PROTOCOL\n");
> +		pr_efi_err("Failed to get handle for LOADED_IMAGE_PROTOCOL\n");
>  		efi_exit(handle, status);
>  	}
>  
> @@ -382,7 +382,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
>  	status = efi_allocate_pages(sizeof(struct boot_params),
>  				    (unsigned long *)&boot_params, ULONG_MAX);
>  	if (status != EFI_SUCCESS) {
> -		efi_printk("Failed to allocate lowmem for boot params\n");
> +		pr_efi_err("Failed to allocate lowmem for boot params\n");
>  		efi_exit(handle, status);
>  	}
>  
> @@ -749,7 +749,7 @@ unsigned long efi_main(efi_handle_t handle,
>  					     hdr->kernel_alignment,
>  					     LOAD_PHYSICAL_ADDR);
>  		if (status != EFI_SUCCESS) {
> -			efi_printk("efi_relocate_kernel() failed!\n");
> +			pr_efi_err("efi_relocate_kernel() failed!\n");
>  			goto fail;
>  		}
>  		/*
> @@ -786,7 +786,7 @@ unsigned long efi_main(efi_handle_t handle,
>  			efi_set_u64_split(size, &hdr->ramdisk_size,
>  					  &boot_params->ext_ramdisk_size);
>  		} else if (status != EFI_NOT_FOUND) {
> -			efi_printk("efi_load_initrd_dev_path() failed!\n");
> +			pr_efi_err("efi_load_initrd_dev_path() failed!\n");
>  			goto fail;
>  		}
>  	}
> @@ -813,13 +813,13 @@ unsigned long efi_main(efi_handle_t handle,
>  
>  	status = exit_boot(boot_params, handle);
>  	if (status != EFI_SUCCESS) {
> -		efi_printk("exit_boot() failed!\n");
> +		pr_efi_err("exit_boot() failed!\n");
>  		goto fail;
>  	}
>  
>  	return bzimage_addr;
>  fail:
> -	efi_printk("efi_main() failed!\n");
> +	pr_efi_err("efi_main() failed!\n");
>  
>  	efi_exit(handle, status);
>  }


  reply index

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 17:41 [PATCH 00/10] efi: some cleanups/refactoring for efi/next Arvind Sankar
2020-04-29 17:41 ` [PATCH 01/10] efi/x86: Use correct size for boot_params Arvind Sankar
2020-04-29 17:41 ` [PATCH 02/10] efi: Add a helper function to split 64-bit values Arvind Sankar
2020-04-29 23:51   ` kbuild test robot
2020-04-29 17:41 ` [PATCH 02/10] efi/libstub: " Arvind Sankar
2020-04-29 17:41 ` [PATCH 03/10] efi/x86: Use pr_efi_err for error messages Arvind Sankar
2020-04-29 18:47   ` Joe Perches [this message]
2020-04-29 18:49     ` Ard Biesheuvel
2020-04-29 18:57       ` Joe Perches
2020-04-29 18:59         ` Ard Biesheuvel
2020-04-29 19:47           ` Joe Perches
2020-04-29 19:48             ` Ard Biesheuvel
2020-04-29 21:43       ` Arvind Sankar
2020-04-29 21:45         ` Ard Biesheuvel
2020-04-29 21:51           ` Arvind Sankar
2020-04-29 21:53         ` Joe Perches
2020-04-29 21:55           ` Ard Biesheuvel
2020-04-29 22:20             ` Arvind Sankar
2020-04-30 15:14               ` Ard Biesheuvel
2020-04-29 17:41 ` [PATCH 04/10] efi/gop: " Arvind Sankar
2020-04-29 17:41 ` [PATCH 05/10] efi/tpm: " Arvind Sankar
2020-04-29 17:41 ` [PATCH 06/10] efi/x86: Move command-line initrd loading to efi_main Arvind Sankar
2020-04-29 17:41 ` [PATCH 07/10] efi/libstub: Unify initrd loading across architectures Arvind Sankar
2020-04-29 17:41 ` [PATCH 08/10] efi/x86: Drop soft_limit for x86 initrd loading Arvind Sankar
2020-04-29 19:05   ` Ard Biesheuvel
2020-04-29 21:33     ` Arvind Sankar
2020-04-29 17:41 ` [PATCH 09/10] efi/x86: Support builtin command line Arvind Sankar
2020-04-29 19:07   ` Ard Biesheuvel
2020-04-29 21:39     ` Arvind Sankar
2020-04-29 21:40       ` Ard Biesheuvel
2020-04-29 21:48         ` Arvind Sankar
2020-04-29 21:51           ` Ard Biesheuvel
2020-04-29 17:41 ` [PATCH 10/10] efi/libstub: Check return value of efi_parse_options Arvind Sankar
2020-04-30  4:31   ` kbuild test robot
2020-04-30 18:28 ` [PATCH v2 00/11] efi: some cleanups/refactoring for efi/next Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 01/11] efi/x86: Use correct size for boot_params Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 02/11] efi/libstub: Add a helper function to split 64-bit values Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 03/11] efi/libstub: Move pr_efi/pr_efi_err into efi namespace Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 04/11] efi/x86: Use efi_err for error messages Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 05/11] efi/gop: " Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 06/11] efi/tpm: " Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 07/11] efi/libstub: Upgrade ignored dtb= argument message to error Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 08/11] efi/x86: Move command-line initrd loading to efi_main Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 09/11] efi/libstub: Unify initrd loading across architectures Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 10/11] efi/x86: Support builtin command line Arvind Sankar
2020-04-30 18:28   ` [PATCH v2 11/11] efi/libstub: Check return value of efi_parse_options Arvind Sankar
2020-04-30 19:12   ` [PATCH 1/2] efi/libstub: efi_info/efi_err message neatening Joe Perches
2020-04-30 19:12     ` [PATCH 2/2] efi/libstub: Correct comment typos Joe Perches
2020-04-30 19:30       ` Ard Biesheuvel
2020-05-04 18:29         ` [trivial PATCH] efi/libstub: Reduce efi_printk object size Joe Perches
2020-05-05  7:50           ` Ard Biesheuvel
2020-05-05  8:01             ` Joe Perches
2020-04-30 19:29     ` [PATCH 1/2] efi/libstub: efi_info/efi_err message neatening Ard Biesheuvel
2020-04-30 19:38       ` Joe Perches
2020-04-30 20:40       ` Arvind Sankar
2020-04-30 20:42         ` Ard Biesheuvel
2020-05-04  8:17   ` [PATCH v2 00/11] efi: some cleanups/refactoring for efi/next Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f74fe4ad56c0471f863ce550869391c8811f9893.camel@perches.com \
    --to=joe@perches.com \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nivedita@alum.mit.edu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git