From: chao@kernel.org (Chao Yu) Subject: [PATCH v2 2/2] staging: erofs: complete POSIX ACL support Date: Tue, 29 Jan 2019 00:41:55 +0800 Message-ID: <1eed1e6b-f95e-aa8e-c3e7-e9870401ee23@kernel.org> (raw) In-Reply-To: <f1fd2c69-0c5b-c655-3712-48169e87fff8@huawei.com> Hi Dan and Xiang, On 2019-1-28 21:48, Gao Xiang wrote: > Hi Dan, > > On 2019/1/28 21:33, Dan Carpenter wrote: >> Hopefully, regular kmalloc() is enough. >> >> Do really need the erofs_kmalloc() function? Regular kmalloc() has >> fault injection already. Have you tried to use it? Yes, I think we'd better to use erofs_kmalloc(). :) Actually, fault injection in erofs_kmalloc only affect erofs module, we can expect that the range of fault can be limited in erofs code, rather than whole kernel, so the test point can be aimed at more accurately. > > The fault injection subsystem was introduced in the initial upstreamed > EROFS version, which is taken from f2fs by Chao Yu. > > Fault injection is important to test fs.. However, I have no more idea > about the future plan of this feature...Follow f2fs or use the general > fault injection... I guess following f2fs is not bad. Thanks, > > There already exists erofs_kmalloc, thus I think it's both ok to use > erofs_kmalloc or kmalloc for this patch at least. > > Chao, any idea about this? > > Thanks, > Gao Xiang >
next prev parent reply index Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-25 16:10 [PATCH v2 1/2] staging: erofs: use xattr_prefix to wrap up Gao Xiang 2019-01-25 16:10 ` [PATCH v2 2/2] staging: erofs: complete POSIX ACL support Gao Xiang 2019-01-26 2:48 ` Chao Yu 2019-01-26 3:06 ` Gao Xiang 2019-01-28 13:33 ` Dan Carpenter 2019-01-28 13:48 ` Gao Xiang 2019-01-28 14:28 ` Dan Carpenter 2019-01-28 15:04 ` Gao Xiang 2019-01-28 16:41 ` Chao Yu [this message] 2019-01-28 18:30 ` Dan Carpenter 2019-01-29 8:03 ` Gao Xiang 2019-02-03 2:52 ` Chao Yu 2019-02-15 2:10 ` Chao Yu 2019-02-15 7:36 ` Dan Carpenter 2019-02-15 9:31 ` Chao Yu 2019-01-26 2:08 ` [PATCH v2 1/2] staging: erofs: use xattr_prefix to wrap up Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1eed1e6b-f95e-aa8e-c3e7-e9870401ee23@kernel.org \ --to=chao@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-EROFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-erofs/0 linux-erofs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-erofs linux-erofs/ https://lore.kernel.org/linux-erofs \ linux-erofs@lists.ozlabs.org linux-erofs@ozlabs.org public-inbox-index linux-erofs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.ozlabs.lists.linux-erofs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git