Linux-EROFS Archive on lore.kernel.org
 help / color / Atom feed
From: yuchao0@huawei.com (Chao Yu)
Subject: [PATCH v2 2/2] staging: erofs: complete POSIX ACL support
Date: Fri, 15 Feb 2019 17:31:13 +0800
Message-ID: <388add9e-8643-b08f-2eec-9742c5411cc0@huawei.com> (raw)
In-Reply-To: <20190215073644.GD2326@kadam>

On 2019/2/15 15:36, Dan Carpenter wrote:
> On Fri, Feb 15, 2019@10:10:34AM +0800, Chao Yu wrote:
>> Hi Dan,
>>
>> Any suggestion?
>>
> 
> I won't NAK whatever you decide.  But my opinion is that you should
> just use normal kernel memory allocators even though it means you have
> to use two different fault injection frameworks.

Thanks for the suggestion.

There is only one injection type in erofs injection framework, I don't want
to remove all framework codes with kmalloc type, so I think we can do this
step by step:
a. use erofs_kamloc to keep all codes consistent.
b. add at least one erofs private injection type.
c. remove erofs_kmalloc and related type.

> 
> Over time it would be good to improve and expand the standard kernel
> error injection frameworks to cover more types.

Agreed.

Thanks,

> 
> regards,
> dan carpenter
> 
> 
> 

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 16:10 [PATCH v2 1/2] staging: erofs: use xattr_prefix to wrap up gaoxiang25
2019-01-25 16:10 ` [PATCH v2 2/2] staging: erofs: complete POSIX ACL support gaoxiang25
2019-01-26  2:48   ` yuchao0
2019-01-26  3:06     ` hsiangkao
2019-01-28 13:33     ` dan.carpenter
2019-01-28 13:48       ` gaoxiang25
2019-01-28 14:28         ` dan.carpenter
2019-01-28 15:04           ` hsiangkao
2019-01-28 16:41         ` chao
2019-01-28 18:30           ` dan.carpenter
2019-01-29  8:03             ` gaoxiang25
2019-02-03  2:52             ` yuchao0
2019-02-15  2:10               ` yuchao0
2019-02-15  7:36                 ` dan.carpenter
2019-02-15  9:31                   ` yuchao0 [this message]
2019-01-26  2:08 ` [PATCH v2 1/2] staging: erofs: use xattr_prefix to wrap up yuchao0

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=388add9e-8643-b08f-2eec-9742c5411cc0@huawei.com \
    --to=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EROFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-erofs/0 linux-erofs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-erofs linux-erofs/ https://lore.kernel.org/linux-erofs \
		linux-erofs@lists.ozlabs.org linux-erofs@ozlabs.org
	public-inbox-index linux-erofs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linux-erofs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git