From: Gao Xiang <hsiangkao@redhat.com>
To: Huang Jianan <huangjianan@oppo.com>, Chao Yu <yuchao0@huawei.com>
Cc: guoweichao@oppo.com, linux-erofs@lists.ozlabs.org,
zhangshiming@oppo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] erofs: avoiding using generic_block_bmap
Date: Wed, 9 Dec 2020 10:44:15 +0800 [thread overview]
Message-ID: <20201209024415.GA33948@xiangao.remote.csb> (raw)
In-Reply-To: <c71fe6a9-06ba-3871-6e0b-104f58df1df7@oppo.com>
Hi Jianan and Chao,
On Wed, Dec 09, 2020 at 10:34:54AM +0800, Huang Jianan wrote:
>
> 在 2020/12/8 21:11, Huang Jianan 写道:
...
> > -
> > static sector_t erofs_bmap(struct address_space *mapping, sector_t block)
> > {
> > struct inode *inode = mapping->host;
> > + struct erofs_map_blocks map = {
> > + .m_la = blknr_to_addr(iblock),
>
> Sorry for my mistake, it should be:
>
> .m_la = blknr_to_addr(block),
>
Sigh, since my ro_fsstress doesn't cover bmap interface... I mean do we need
to add some testcase for this? (But it needs to be fixed anyway, plus this patch
looks good to me....)
Hi Chao,
could you kindly leave some free slot for this patch and
erofs: force inplace I/O under low memory scenario
https://lore.kernel.org/r/20201208054600.16302-1-hsiangkao@aol.com
Since I'd like to merge these all for 5.11-rc1 (so we could have more time to
test until the next LTS version), since 5.10 is a LTS version, I tend to not
introduce any big modification (so in the past months, "erofs: force inplace
I/O under low memory scenario" never upstreamed at all.)
Thanks,
Gao Xiang
next prev parent reply other threads:[~2020-12-09 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 13:11 [PATCH v3] erofs: avoiding using generic_block_bmap Huang Jianan
2020-12-09 2:34 ` Huang Jianan
2020-12-09 2:44 ` Gao Xiang [this message]
2020-12-09 2:56 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209024415.GA33948@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=guoweichao@oppo.com \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).