From: Chao Yu <yuchao0@huawei.com>
To: Gao Xiang <hsiangkao@redhat.com>, Huang Jianan <huangjianan@oppo.com>
Cc: guoweichao@oppo.com, linux-erofs@lists.ozlabs.org,
zhangshiming@oppo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] erofs: avoiding using generic_block_bmap
Date: Wed, 9 Dec 2020 10:56:20 +0800 [thread overview]
Message-ID: <fd9d991d-c048-500f-ca52-f186c42974b1@huawei.com> (raw)
In-Reply-To: <20201209024415.GA33948@xiangao.remote.csb>
On 2020/12/9 10:44, Gao Xiang wrote:
> Hi Jianan and Chao,
>
> On Wed, Dec 09, 2020 at 10:34:54AM +0800, Huang Jianan wrote:
>>
>> 在 2020/12/8 21:11, Huang Jianan 写道:
>
> ...
>
>>> -
>>> static sector_t erofs_bmap(struct address_space *mapping, sector_t block)
>>> {
>>> struct inode *inode = mapping->host;
>>> + struct erofs_map_blocks map = {
>>> + .m_la = blknr_to_addr(iblock),
>>
>> Sorry for my mistake, it should be:
>>
>> .m_la = blknr_to_addr(block),
>>
>
> Sigh, since my ro_fsstress doesn't cover bmap interface... I mean do we need
> to add some testcase for this? (But it needs to be fixed anyway, plus this patch
> looks good to me....)
>
> Hi Chao,
> could you kindly leave some free slot for this patch and
>
> erofs: force inplace I/O under low memory scenario
> https://lore.kernel.org/r/20201208054600.16302-1-hsiangkao@aol.com
Will review soon. :)
Thanks,
>
> Since I'd like to merge these all for 5.11-rc1 (so we could have more time to
> test until the next LTS version), since 5.10 is a LTS version, I tend to not
> introduce any big modification (so in the past months, "erofs: force inplace
> I/O under low memory scenario" never upstreamed at all.)
>
> Thanks,
> Gao Xiang
>
>
> .
>
prev parent reply other threads:[~2020-12-09 2:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 13:11 [PATCH v3] erofs: avoiding using generic_block_bmap Huang Jianan
2020-12-09 2:34 ` Huang Jianan
2020-12-09 2:44 ` Gao Xiang
2020-12-09 2:56 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9d991d-c048-500f-ca52-f186c42974b1@huawei.com \
--to=yuchao0@huawei.com \
--cc=guoweichao@oppo.com \
--cc=hsiangkao@redhat.com \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).