From: Gao Xiang <hsiangkao@redhat.com>
To: Hu Weiwen <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 4/7] erofs-utils: tests: fix distcheck
Date: Fri, 22 Jan 2021 08:16:05 +0800 [thread overview]
Message-ID: <20210122001605.GC2996701@xiangao.remote.csb> (raw)
In-Reply-To: <20210121163715.10660-5-sehuww@mail.scut.edu.cn>
Hi Weiwen,
On Fri, Jan 22, 2021 at 12:37:12AM +0800, Hu Weiwen wrote:
> To get required files to final .tar.gz distribution:
> * Any header files should goes into _SOURCES.
should we use noinst_HEADERS instead? do you have some reference
link (I mean document) for this? what's the impact of this,
just dictcheck? I'm not familiar with that...
> * check scripts should goes into dist_check_SCRIPTS.
> * 001.out will trigger a GNU make implicit rule, rename it to 001-out
How about also renaming $tmp.out to $tmp.stdout?
Also, 'since experimental-tests' has't merged into dev, do you mind
me folding these bugfix patches (I mean except for "[PATCH 5/7] and
[PATCH 7/7]") into the original patches, and add your contribution
description & SOB(Signed-off-by:) to the commit message? That would
make the whole commit history much cleaner... If you agree that, I
will resend the testcase patchset later with your fixes and new
patches and wait for Guifu to review if he has extra free slots.
Note that, only dev & master branches have stable commit ids.
experimental-xxx could be rebased frequently.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2021-01-22 0:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 16:37 [PATCH 0/7] Setup tests Hu Weiwen
2021-01-21 16:37 ` [PATCH 1/7] erofs-utils: tests: fix when lz4 is not enabled Hu Weiwen
2021-01-22 0:21 ` Gao Xiang
2021-01-21 16:37 ` [PATCH 2/7] erofs-utils: tests: fix on out-of-tree build Hu Weiwen
2021-01-22 0:19 ` Gao Xiang
2021-01-21 16:37 ` [PATCH 3/7] erofs-utils: tests: fix memory leakage in fssum Hu Weiwen
2021-01-21 23:45 ` Gao Xiang
2021-01-21 16:37 ` [PATCH 4/7] erofs-utils: tests: fix distcheck Hu Weiwen
2021-01-22 0:16 ` Gao Xiang [this message]
2021-01-22 1:09 ` 胡玮文
2021-01-21 16:37 ` [PATCH 5/7] erofs-utils: tests: check battach on full buffer block Hu Weiwen
2021-01-21 16:41 ` [PATCH 6/7] erofs-utils: tests: fix fuse build order Hu Weiwen
2021-01-21 16:42 ` [PATCH 7/7] erofs-utils: tests: enable GitHub Actions Hu Weiwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122001605.GC2996701@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=sehuww@mail.scut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).