linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] erofs-utils: remove duplicate __func__ print
@ 2021-04-20 11:52 Huang Jianan via Linux-erofs
  2021-04-21  9:00 ` Gao Xiang
  0 siblings, 1 reply; 2+ messages in thread
From: Huang Jianan via Linux-erofs @ 2021-04-20 11:52 UTC (permalink / raw)
  To: linux-erofs; +Cc: zhangshiming

__func__ has been printed in the macro definition of erofs_err.

Signed-off-by: Huang Jianan <huangjianan@oppo.com>
---
 lib/inode.c | 4 ++--
 lib/xattr.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/inode.c b/lib/inode.c
index 40189fe..b964b98 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -956,8 +956,8 @@ struct erofs_inode *erofs_mkfs_build_tree(struct erofs_inode *dir)
 
 	_dir = opendir(dir->i_srcpath);
 	if (!_dir) {
-		erofs_err("%s, failed to opendir at %s: %s",
-			  __func__, dir->i_srcpath, erofs_strerror(errno));
+		erofs_err("failed to opendir at %s: %s",
+			  dir->i_srcpath, erofs_strerror(errno));
 		return ERR_PTR(-errno);
 	}
 
diff --git a/lib/xattr.c b/lib/xattr.c
index 8b7bcb1..a7677b9 100644
--- a/lib/xattr.c
+++ b/lib/xattr.c
@@ -446,8 +446,8 @@ static int erofs_count_all_xattrs_from_path(const char *path)
 
 	_dir = opendir(path);
 	if (!_dir) {
-		erofs_err("%s, failed to opendir at %s: %s",
-			  __func__, path, erofs_strerror(errno));
+		erofs_err("failed to opendir at %s: %s",
+			  path, erofs_strerror(errno));
 		return -errno;
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] erofs-utils: remove duplicate __func__ print
  2021-04-20 11:52 [PATCH] erofs-utils: remove duplicate __func__ print Huang Jianan via Linux-erofs
@ 2021-04-21  9:00 ` Gao Xiang
  0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2021-04-21  9:00 UTC (permalink / raw)
  To: Huang Jianan; +Cc: zhangshiming, linux-erofs

On Tue, Apr 20, 2021 at 07:52:37PM +0800, Huang Jianan via Linux-erofs wrote:
> __func__ has been printed in the macro definition of erofs_err.
> 
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>

Reviewed-by: Gao Xiang <xiang@kernel.org>

Thanks,
Gao Xiang

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-21  9:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 11:52 [PATCH] erofs-utils: remove duplicate __func__ print Huang Jianan via Linux-erofs
2021-04-21  9:00 ` Gao Xiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).