From: Gao Xiang <xiang@kernel.org> To: linux-erofs@lists.ozlabs.org, Li Guifu <bluce.liguifu@huawei.com> Cc: Gao Xiang <xiang@kernel.org> Subject: [PATCH v2 2/3] erofs-utils: warn out experimental big pcluster Date: Tue, 27 Apr 2021 10:49:59 +0800 [thread overview] Message-ID: <20210427024959.10885-1-xiang@kernel.org> (raw) In-Reply-To: <20210427023722.7996-2-xiang@kernel.org> It's still an experimental feature for now. Also set the default logging level to 2 in order to print warn messages. Signed-off-by: Gao Xiang <xiang@kernel.org> --- v2: - use erofs_warn() and set default dbglevel to 2. lib/compress.c | 2 ++ lib/config.c | 2 +- man/mkfs.erofs.1 | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/compress.c b/lib/compress.c index 654286d3f33e..b8bb89e7ae9d 100644 --- a/lib/compress.c +++ b/lib/compress.c @@ -619,6 +619,8 @@ int z_erofs_compress_init(struct erofs_buffer_head *sb_bh) mapheader.h_advise |= Z_EROFS_ADVISE_BIG_PCLUSTER_1; if (!cfg.c_legacy_compress) mapheader.h_advise |= Z_EROFS_ADVISE_BIG_PCLUSTER_2; + + erofs_warn("EXPERIMENTAL big pcluster feature in use. Use at your own risk!"); } mapheader.h_algorithmtype = algorithmtype[1] << 4 | algorithmtype[0]; diff --git a/lib/config.c b/lib/config.c index d733cc366794..bc0afa284807 100644 --- a/lib/config.c +++ b/lib/config.c @@ -17,7 +17,7 @@ void erofs_init_configure(void) { memset(&cfg, 0, sizeof(cfg)); - cfg.c_dbg_lvl = 0; + cfg.c_dbg_lvl = 2; cfg.c_version = PACKAGE_VERSION; cfg.c_dry_run = false; cfg.c_compr_level_master = -1; diff --git a/man/mkfs.erofs.1 b/man/mkfs.erofs.1 index 254c3ec4de41..2520b6a08974 100644 --- a/man/mkfs.erofs.1 +++ b/man/mkfs.erofs.1 @@ -25,7 +25,8 @@ Set an algorithm for file compression, which can be set with an optional compression level separated by a comma. .TP .BI "\-d " # -Specify the level of debugging messages. The default is 0. +Specify the level of debugging messages. The default is 2, which shows basic +warning messages. .TP .BI "\-x " # Specify the upper limit of an xattr which is still inlined. The default is 2. -- 2.20.1
next prev parent reply other threads:[~2021-04-27 2:50 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-27 2:37 [PATCH 1/3] erofs-utils: sync up with in-kernel erofs_fs.h Gao Xiang 2021-04-27 2:37 ` [PATCH 2/3] erofs-utils: warn out experimental big pcluster Gao Xiang 2021-04-27 2:49 ` Gao Xiang [this message] 2021-04-27 2:37 ` [PATCH 3/3] erofs-utils: man: add missing -C option for " Gao Xiang 2021-04-30 16:14 ` [PATCH 1/3] erofs-utils: sync up with in-kernel erofs_fs.h Li GuiFu via Linux-erofs
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210427024959.10885-1-xiang@kernel.org \ --to=xiang@kernel.org \ --cc=bluce.liguifu@huawei.com \ --cc=linux-erofs@lists.ozlabs.org \ --subject='Re: [PATCH v2 2/3] erofs-utils: warn out experimental big pcluster' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).