* [PATCH] erofs: get rid of the leftover PAGE_SIZE in dir.c
@ 2022-06-19 15:09 Gao Xiang
2022-07-22 6:10 ` JeffleXu
0 siblings, 1 reply; 2+ messages in thread
From: Gao Xiang @ 2022-06-19 15:09 UTC (permalink / raw)
To: Chao Yu, linux-erofs; +Cc: Gao Xiang, linux-kernel
Convert the last hardcoded PAGE_SIZEs of uncompressed cases.
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
fs/erofs/dir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/erofs/dir.c b/fs/erofs/dir.c
index 18e59821c597..723f5223a4fa 100644
--- a/fs/erofs/dir.c
+++ b/fs/erofs/dir.c
@@ -90,7 +90,7 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
nameoff = le16_to_cpu(de->nameoff);
if (nameoff < sizeof(struct erofs_dirent) ||
- nameoff >= PAGE_SIZE) {
+ nameoff >= EROFS_BLKSIZ) {
erofs_err(dir->i_sb,
"invalid de[0].nameoff %u @ nid %llu",
nameoff, EROFS_I(dir)->nid);
@@ -99,7 +99,7 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
}
maxsize = min_t(unsigned int,
- dirsize - ctx->pos + ofs, PAGE_SIZE);
+ dirsize - ctx->pos + ofs, EROFS_BLKSIZ);
/* search dirents at the arbitrary position */
if (initial) {
--
2.24.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] erofs: get rid of the leftover PAGE_SIZE in dir.c
2022-06-19 15:09 [PATCH] erofs: get rid of the leftover PAGE_SIZE in dir.c Gao Xiang
@ 2022-07-22 6:10 ` JeffleXu
0 siblings, 0 replies; 2+ messages in thread
From: JeffleXu @ 2022-07-22 6:10 UTC (permalink / raw)
To: Gao Xiang, Chao Yu, linux-erofs; +Cc: linux-kernel
On 6/19/22 11:09 PM, Gao Xiang wrote:
> Convert the last hardcoded PAGE_SIZEs of uncompressed cases.
>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/dir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/erofs/dir.c b/fs/erofs/dir.c
> index 18e59821c597..723f5223a4fa 100644
> --- a/fs/erofs/dir.c
> +++ b/fs/erofs/dir.c
> @@ -90,7 +90,7 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
>
> nameoff = le16_to_cpu(de->nameoff);
> if (nameoff < sizeof(struct erofs_dirent) ||
> - nameoff >= PAGE_SIZE) {
> + nameoff >= EROFS_BLKSIZ) {
> erofs_err(dir->i_sb,
> "invalid de[0].nameoff %u @ nid %llu",
> nameoff, EROFS_I(dir)->nid);
> @@ -99,7 +99,7 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
> }
>
> maxsize = min_t(unsigned int,
> - dirsize - ctx->pos + ofs, PAGE_SIZE);
> + dirsize - ctx->pos + ofs, EROFS_BLKSIZ);
>
> /* search dirents at the arbitrary position */
> if (initial) {
LGTM.
Reviewed-by: Jeffle Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jeffle
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-22 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-19 15:09 [PATCH] erofs: get rid of the leftover PAGE_SIZE in dir.c Gao Xiang
2022-07-22 6:10 ` JeffleXu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).