From: Jia Zhu <zhujia.zj@bytedance.com>
To: JeffleXu <jefflexu@linux.alibaba.com>,
linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org
Cc: linux-fsdevel@vger.kernel.org, huyue2@coolpad.com,
linux-kernel@vger.kernel.org, yinxin.x@bytedance.com
Subject: Re: [External] Re: [PATCH V2 4/5] erofs: remove duplicated unregister_cookie
Date: Tue, 13 Sep 2022 12:52:41 +0800 [thread overview]
Message-ID: <27143c70-906e-a575-ef58-ac9f3c5ab080@bytedance.com> (raw)
In-Reply-To: <8a239157-de28-44ae-edef-336092c34a15@linux.alibaba.com>
在 2022/9/9 18:28, JeffleXu 写道:
>
>
> On 9/9/22 5:55 PM, JeffleXu wrote:
>>
>>
>> On 9/2/22 6:53 PM, Jia Zhu wrote:
>>> In erofs umount scenario, erofs_fscache_unregister_cookie() is called
>>> twice in kill_sb() and put_super().
>>>
>>> It works for original semantics, cause 'ctx' will be set to NULL in
>>> put_super() and will not be unregister again in kill_sb().
>>> However, in shared domain scenario, we use refcount to maintain the
>>> lifecycle of cookie. Unregister the cookie twice will cause it to be
>>> released early.
>
> Sorry, why can't we also set sbi->s_fscache to NULL after decrementing
> the refcount in shared domain mode, to avoid the refcount being
> decremented twice?
>
In below case:
1. mount -t erofs none -o fsid=bootstrap.img -o device=blob.img -o
domain_id=1 mnt
2. mount -t erofs none -o fsid=bootstrap.img -o device=blob.img -o
domain_id=1 mnt2
3. Procedure 2 will fail since we can't mount erofs with the same sysfs
entry.
4. Mount()'s error handling path will step into put_super().
5. Domain's refcnt will be decremented even if it has not yet
been incremented.
>>>
>>> For the above reasons, this patch removes duplicate unregister_cookie
>>> and move fscache_unregister_* before shotdown_super() to prevent busy
>>> inode(ctx->inode) when umount.
>>>
>>> Signed-off-by: Jia Zhu <zhujia.zj@bytedance.com>
>>> ---
>>> fs/erofs/super.c | 16 ++++++++--------
>>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
>>> index 69de1731f454..667a78f0ee70 100644
>>> --- a/fs/erofs/super.c
>>> +++ b/fs/erofs/super.c
>>> @@ -919,19 +919,20 @@ static void erofs_kill_sb(struct super_block *sb)
>>> kill_litter_super(sb);
>>> return;
>>> }
>>> - if (erofs_is_fscache_mode(sb))
>>> - generic_shutdown_super(sb);
>>> - else
>>> - kill_block_super(sb);
>>> -
>>> sbi = EROFS_SB(sb);
>>> if (!sbi)
>>> return;
>>>
>>> + if (erofs_is_fscache_mode(sb)) {
>>> + erofs_fscache_unregister_cookie(&sbi->s_fscache);
>>> + erofs_fscache_unregister_fs(sb);
>>> + generic_shutdown_super(sb);
>>
>> Generally we can't do clean ups before generic_shutdown_super(), since
>> generic_shutdown_super() may trigger IO, e.g. in sync_filesystem(),
>> though it's not the case for erofs (read-only).
>>
>> How about embedding erofs_fscache_unregister_cookie() into
>> erofs_fscache_unregister_fs(), and thus we can check domain_id in
>> erofs_fscache_unregister_fs()?
>>
>>> + } else {
>>> + kill_block_super(sb);
>>> + }
>>> +
>>> erofs_free_dev_context(sbi->devs);
>>> fs_put_dax(sbi->dax_dev, NULL);
>>> - erofs_fscache_unregister_cookie(&sbi->s_fscache);
>>> - erofs_fscache_unregister_fs(sb);
>>> kfree(sbi->opt.fsid);
>>> kfree(sbi->opt.domain_id);
>>> kfree(sbi);
>>> @@ -951,7 +952,6 @@ static void erofs_put_super(struct super_block *sb)
>>> iput(sbi->managed_cache);
>>> sbi->managed_cache = NULL;
>>> #endif
>>> - erofs_fscache_unregister_cookie(&sbi->s_fscache);
>>> }
>>>
>>> struct file_system_type erofs_fs_type = {
>>
>
next prev parent reply other threads:[~2022-09-13 4:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 10:53 [PATCH V2 0/5] Introduce erofs shared domain Jia Zhu
2022-09-02 10:53 ` [PATCH V2 1/5] erofs: add 'domain_id' mount option for on-demand read sementics Jia Zhu
2022-09-02 10:53 ` [PATCH V2 2/5] erofs: introduce fscache-based domain Jia Zhu
2022-09-09 8:42 ` JeffleXu
2022-09-13 4:31 ` [External] " Jia Zhu
2022-09-13 6:34 ` JeffleXu
2022-09-14 3:02 ` JeffleXu
2022-09-14 3:15 ` [External] " Jia Zhu
2022-09-02 10:53 ` [PATCH V2 3/5] erofs: add 'domain_id' prefix when register sysfs Jia Zhu
2022-09-09 9:23 ` JeffleXu
2022-09-09 9:26 ` JeffleXu
2022-09-13 4:35 ` [External] " Jia Zhu
2022-09-02 10:53 ` [PATCH V2 4/5] erofs: remove duplicated unregister_cookie Jia Zhu
2022-09-09 9:55 ` JeffleXu
2022-09-09 10:28 ` JeffleXu
2022-09-13 4:52 ` Jia Zhu [this message]
2022-09-13 4:37 ` [External] " Jia Zhu
2022-09-02 10:53 ` [PATCH V2 5/5] erofs: support fscache based shared domain Jia Zhu
2022-09-13 6:27 ` JeffleXu
2022-09-13 12:59 ` [External] " Jia Zhu
2022-09-08 6:49 ` [PATCH V2 0/5] Introduce erofs " Jia Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27143c70-906e-a575-ef58-ac9f3c5ab080@bytedance.com \
--to=zhujia.zj@bytedance.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).