From: Jia Zhu <zhujia.zj@bytedance.com>
To: JeffleXu <jefflexu@linux.alibaba.com>,
linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org
Cc: linux-fsdevel@vger.kernel.org, huyue2@coolpad.com,
linux-kernel@vger.kernel.org, yinxin.x@bytedance.com
Subject: Re: [External] Re: [PATCH V2 2/5] erofs: introduce fscache-based domain
Date: Wed, 14 Sep 2022 11:15:39 +0800 [thread overview]
Message-ID: <5f8b9a15-ec53-127b-63c3-b32005b35e05@bytedance.com> (raw)
In-Reply-To: <56b0a8c1-94ce-3219-6b43-d91d2e0e85b5@linux.alibaba.com>
在 2022/9/14 11:02, JeffleXu 写道:
>
>
> On 9/2/22 6:53 PM, Jia Zhu wrote:
>
>> int erofs_fscache_register_cookie(struct super_block *sb,
>> struct erofs_fscache **fscache,
>> char *name, bool need_inode)
>> @@ -495,7 +581,8 @@ int erofs_fscache_register_fs(struct super_block *sb)
>> char *name;
>> int ret = 0;
>>
>> - name = kasprintf(GFP_KERNEL, "erofs,%s", sbi->opt.fsid);
>> + name = kasprintf(GFP_KERNEL, "erofs,%s",
>> + sbi->domain ? sbi->domain->domain_id : sbi->opt.fsid);
>> if (!name)
>> return -ENOMEM;
>>
>
> What if domain_id and fsid has the same value?
>
> How about the format "erofs,<domain_id>,<fsid>"? While in the
> non-share-domain mode, is the format like "erofs,,<fsid>" or the default
> "erofs,<fsid>"?
>
Thanks for pointing this out. I'll revise it.
>
next prev parent reply other threads:[~2022-09-14 3:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 10:53 [PATCH V2 0/5] Introduce erofs shared domain Jia Zhu
2022-09-02 10:53 ` [PATCH V2 1/5] erofs: add 'domain_id' mount option for on-demand read sementics Jia Zhu
2022-09-02 10:53 ` [PATCH V2 2/5] erofs: introduce fscache-based domain Jia Zhu
2022-09-09 8:42 ` JeffleXu
2022-09-13 4:31 ` [External] " Jia Zhu
2022-09-13 6:34 ` JeffleXu
2022-09-14 3:02 ` JeffleXu
2022-09-14 3:15 ` Jia Zhu [this message]
2022-09-02 10:53 ` [PATCH V2 3/5] erofs: add 'domain_id' prefix when register sysfs Jia Zhu
2022-09-09 9:23 ` JeffleXu
2022-09-09 9:26 ` JeffleXu
2022-09-13 4:35 ` [External] " Jia Zhu
2022-09-02 10:53 ` [PATCH V2 4/5] erofs: remove duplicated unregister_cookie Jia Zhu
2022-09-09 9:55 ` JeffleXu
2022-09-09 10:28 ` JeffleXu
2022-09-13 4:52 ` [External] " Jia Zhu
2022-09-13 4:37 ` Jia Zhu
2022-09-02 10:53 ` [PATCH V2 5/5] erofs: support fscache based shared domain Jia Zhu
2022-09-13 6:27 ` JeffleXu
2022-09-13 12:59 ` [External] " Jia Zhu
2022-09-08 6:49 ` [PATCH V2 0/5] Introduce erofs " Jia Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8b9a15-ec53-127b-63c3-b32005b35e05@bytedance.com \
--to=zhujia.zj@bytedance.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).