From: Maksym Planeta <mplaneta@os.inf.tu-dresden.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, Song Liu <song@kernel.org>,
Zhou Wang <wangzhou1@hisilicon.com>,
linux-crypto@vger.kernel.org, Gao Xiang <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: Remove WQ_CPU_INTENSIVE flag from unbound wq's
Date: Thu, 13 Feb 2020 17:19:01 +0100 [thread overview]
Message-ID: <82715589-8b59-5cfd-a32f-1e57871327fe@os.inf.tu-dresden.de> (raw)
In-Reply-To: <20200213153645.GA11313@redhat.com>
On 13/02/2020 16:36, Mike Snitzer wrote:
> On Thu, Feb 13 2020 at 9:18am -0500,
> Maksym Planeta <mplaneta@os.inf.tu-dresden.de> wrote:
>
>> The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for
>> unbound wq. I remove this flag from places where unbound queue is
>> allocated. This is supposed to improve code readability.
>>
>> 1. https://www.kernel.org/doc/html/latest/core-api/workqueue.html#flags
>>
>> Signed-off-by: Maksym Planeta <mplaneta@os.inf.tu-dresden.de>
>
> What the Documentation says aside, have you cross referenced with the
> code? And/or have you done benchmarks to verify no changes?
>
It seems so from the code. Although, I'm not 100% confident. I did not
run benchmarks, instead I relied that on the assumption that
documentation is correct.
> Thanks,
> Mike
>
--
Regards,
Maksym Planeta
next prev parent reply other threads:[~2020-02-13 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:18 [PATCH] Remove WQ_CPU_INTENSIVE flag from unbound wq's Maksym Planeta
2020-02-13 15:36 ` Mike Snitzer
2020-02-13 16:19 ` Maksym Planeta [this message]
2020-02-13 23:42 ` Song Liu
2020-02-14 1:39 ` [PATCH] " Gao Xiang
2020-02-14 3:47 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82715589-8b59-5cfd-a32f-1e57871327fe@os.inf.tu-dresden.de \
--to=mplaneta@os.inf.tu-dresden.de \
--cc=agk@redhat.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).