linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Huang Jianan <jnhuang95@gmail.com>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 5/5] erofs-utils: fix print style
Date: Fri, 3 Sep 2021 11:18:14 +0800	[thread overview]
Message-ID: <YTGT9shnxqLP6Iul@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <20210831165116.16575-6-jnhuang95@gmail.com>

On Wed, Sep 01, 2021 at 12:51:16AM +0800, Huang Jianan wrote:
> From: Huang Jianan <huangjianan@oppo.com>
> 
> Fix warning "quoted string split across lines".
> 
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang

> ---
>  lib/inode.c | 3 +--
>  lib/io.c    | 3 +--
>  lib/zmap.c  | 3 +--
>  3 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/inode.c b/lib/inode.c
> index f001016..76f5fb3 100644
> --- a/lib/inode.c
> +++ b/lib/inode.c
> @@ -741,8 +741,7 @@ int erofs_droid_inode_fsconfig(struct erofs_inode *inode,
>  			  cfg.target_out_path,
>  			  &uid, &gid, &mode, &inode->capabilities);
>  
> -	erofs_dbg("/%s -> mode = 0x%x, uid = 0x%x, gid = 0x%x, "
> -		  "capabilities = 0x%" PRIx64 "\n",
> +	erofs_dbg("/%s -> mode = 0x%x, uid = 0x%x, gid = 0x%x, capabilities = 0x%" PRIx64 "\n",
>  		  fspath, mode, uid, gid, inode->capabilities);
>  
>  	if (decorated)
> diff --git a/lib/io.c b/lib/io.c
> index b053137..620cb9c 100644
> --- a/lib/io.c
> +++ b/lib/io.c
> @@ -242,8 +242,7 @@ int dev_read(void *buf, u64 offset, size_t len)
>  	}
>  	if (offset >= erofs_devsz || len > erofs_devsz ||
>  	    offset > erofs_devsz - len) {
> -		erofs_err("read posion[%" PRIu64 ", %zd] is too large beyond"
> -			  "the end of device(%" PRIu64 ").",
> +		erofs_err("read posion[%" PRIu64 ", %zd] is too large beyond the end of device(%" PRIu64 ").",
>  			  offset, len, erofs_devsz);
>  		return -EINVAL;
>  	}
> diff --git a/lib/zmap.c b/lib/zmap.c
> index 88da515..e4306ce 100644
> --- a/lib/zmap.c
> +++ b/lib/zmap.c
> @@ -57,8 +57,7 @@ static int z_erofs_fill_inode_lazy(struct erofs_inode *vi)
>  	if (vi->datalayout == EROFS_INODE_FLAT_COMPRESSION &&
>  	    !(vi->z_advise & Z_EROFS_ADVISE_BIG_PCLUSTER_1) ^
>  	    !(vi->z_advise & Z_EROFS_ADVISE_BIG_PCLUSTER_2)) {
> -		erofs_err(
> -"big pcluster head1/2 of compact indexes should be consistent for nid %llu",
> +		erofs_err("big pcluster head1/2 of compact indexes should be consistent for nid %llu",
>  			  vi->nid * 1ULL);
>  		return -EFSCORRUPTED;
>  	}
> -- 
> 2.25.1

  reply	other threads:[~2021-09-03  3:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 16:51 [PATCH 0/5] erofs-utils: fix checkpatch.pl complains Huang Jianan
2021-08-31 16:51 ` [PATCH 1/5] erofs-utils: remove filename in the file Huang Jianan
2021-09-03  3:09   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 2/5] erofs-utils: fix SPDX comment style Huang Jianan
2021-09-03  3:10   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 3/5] erofs-utils: fix general style problem Huang Jianan
2021-09-03  3:12   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 4/5] erofs-utils: remove unnecessary codes and comments Huang Jianan
2021-09-03  3:17   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 5/5] erofs-utils: fix print style Huang Jianan
2021-09-03  3:18   ` Gao Xiang [this message]
2021-09-03 13:40 ` [PATCH V2 0/6] erofs-utils: fix checkpatch.pl complains Huang Jianan
2021-09-03 13:40   ` [PATCH V2 1/6] erofs-utils: clean up file headers & footers Huang Jianan
2021-09-03 15:03     ` Gao Xiang
2021-09-03 13:40   ` [PATCH V2 2/6] erofs-utils: fix SPDX comment style Huang Jianan
2021-09-03 13:40   ` [PATCH V2 3/6] erofs-utils: fix general style problem Huang Jianan
2021-09-03 13:40   ` [PATCH V2 4/6] erofs-utils: remove unnecessary codes Huang Jianan
2021-09-03 15:10     ` Gao Xiang
2021-09-03 13:40   ` [PATCH V2 5/6] erofs-utils: fix print style Huang Jianan
2021-09-03 13:40   ` [PATCH V2 6/6] erofs-utils: add missing /* fallthrough */ Huang Jianan
2021-09-03 15:21     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YTGT9shnxqLP6Iul@B-P7TQMD6M-0146.local \
    --to=hsiangkao@linux.alibaba.com \
    --cc=jnhuang95@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --subject='Re: [PATCH 5/5] erofs-utils: fix print style' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).