From: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
To: tytso@mit.edu
Cc: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3] Updated locking documentation for transaction_t
Date: Thu, 15 Oct 2020 15:26:28 +0200 [thread overview]
Message-ID: <10cfbef1-994c-c604-f8a6-b1042fcc622f@tu-dortmund.de> (raw)
In-Reply-To: <20190408083500.66759-1-alexander.lochmann@tu-dortmund.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 147 bytes --]
Hi folks,
I've updated the lock documentation according to our finding for
transaction_t.
Does this patch look good to you?
Cheers,
Alex
[-- Attachment #1.1.2: transaction_t-doc.patch --]
[-- Type: text/x-patch, Size: 1446 bytes --]
commit 13ac907c45c5da7d691f6e10972de5e56e0072c6
Author: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Date: Thu Oct 15 15:24:52 2020 +0200
Updated locking documentation for transaction_t
We used LockDoc to derive locking rules for each member
of struct transaction_t.
Based on those results, we extended the existing documentation
by more members of struct transaction_t, and updated the existing
documentation.
Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 08f904943ab2..a11c78e4af4e 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -532,6 +532,7 @@ struct transaction_chp_stats_s {
* The transaction keeps track of all of the buffers modified by a
* running transaction, and all of the buffers committed but not yet
* flushed to home for finished transactions.
+ * (Locking Documentation improved by LockDoc)
*/
/*
@@ -650,12 +651,12 @@ struct transaction_s
unsigned long t_start;
/*
- * When commit was requested
+ * When commit was requested [journal_t.j_state_lock]
*/
unsigned long t_requested;
/*
- * Checkpointing stats [j_checkpoint_sem]
+ * Checkpointing stats [journal_t.j_list_lock]
*/
struct transaction_chp_stats_s t_chp_stats;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-15 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:35 [PATCH v3] Updated locking documentation for transaction_t Alexander Lochmann
2019-06-20 20:45 ` Alexander Lochmann
2020-10-15 13:26 ` Alexander Lochmann [this message]
2020-12-03 14:04 ` Theodore Y. Ts'o
2020-12-03 14:38 ` Alexander Lochmann
2020-12-03 20:39 ` Theodore Y. Ts'o
2020-10-15 13:56 ` [RFC] Fine-grained locking documentation for jbd2 data structures Alexander Lochmann
2021-02-05 15:31 ` Alexander Lochmann
2021-02-08 15:27 ` Jan Kara
2021-02-09 9:58 ` Alexander Lochmann
2021-02-09 12:00 ` Jan Kara
2021-02-09 13:47 ` Alexander Lochmann
2021-02-09 16:48 ` Jan Kara
2021-02-11 17:14 [PATCH v3] Updated locking documentation for transaction_t Alexander Lochmann
2021-03-17 20:58 ` Alexander Lochmann
2021-04-02 15:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10cfbef1-994c-c604-f8a6-b1042fcc622f@tu-dortmund.de \
--to=alexander.lochmann@tu-dortmund.de \
--cc=horst.schirmeier@tu-dortmund.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).