* [PATCH] jbd2: fix incorrect code style
@ 2020-07-18 12:57 Xianting Tian
2020-07-27 8:35 ` Jan Kara
2020-08-06 5:48 ` tytso
0 siblings, 2 replies; 3+ messages in thread
From: Xianting Tian @ 2020-07-18 12:57 UTC (permalink / raw)
To: tytso, jack; +Cc: linux-ext4, linux-kernel
Remove unnecessary blank.
Signed-off-by: Xianting Tian <xianting_tian@126.com>
---
fs/jbd2/journal.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index e494443..5eccf8c 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1285,7 +1285,7 @@ journal_t *jbd2_journal_init_inode(struct inode *inode)
* superblock as being NULL to prevent the journal destroy from writing
* back a bogus superblock.
*/
-static void journal_fail_superblock (journal_t *journal)
+static void journal_fail_superblock(journal_t *journal)
{
struct buffer_head *bh = journal->j_sb_buffer;
brelse(bh);
@@ -1815,7 +1815,7 @@ int jbd2_journal_destroy(journal_t *journal)
/**
- *int jbd2_journal_check_used_features () - Check if features specified are used.
+ *int jbd2_journal_check_used_features() - Check if features specified are used.
* @journal: Journal to check.
* @compat: bitmask of compatible features
* @ro: bitmask of features that force read-only mount
@@ -1825,7 +1825,7 @@ int jbd2_journal_destroy(journal_t *journal)
* features. Return true (non-zero) if it does.
**/
-int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
+int jbd2_journal_check_used_features(journal_t *journal, unsigned long compat,
unsigned long ro, unsigned long incompat)
{
journal_superblock_t *sb;
@@ -1860,7 +1860,7 @@ int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
* all of a given set of features on this journal. Return true
* (non-zero) if it can. */
-int jbd2_journal_check_available_features (journal_t *journal, unsigned long compat,
+int jbd2_journal_check_available_features(journal_t *journal, unsigned long compat,
unsigned long ro, unsigned long incompat)
{
if (!compat && !ro && !incompat)
@@ -1882,7 +1882,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
}
/**
- * int jbd2_journal_set_features () - Mark a given journal feature in the superblock
+ * int jbd2_journal_set_features() - Mark a given journal feature in the superblock
* @journal: Journal to act on.
* @compat: bitmask of compatible features
* @ro: bitmask of features that force read-only mount
@@ -1893,7 +1893,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
*
*/
-int jbd2_journal_set_features (journal_t *journal, unsigned long compat,
+int jbd2_journal_set_features(journal_t *journal, unsigned long compat,
unsigned long ro, unsigned long incompat)
{
#define INCOMPAT_FEATURE_ON(f) \
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: fix incorrect code style
2020-07-18 12:57 [PATCH] jbd2: fix incorrect code style Xianting Tian
@ 2020-07-27 8:35 ` Jan Kara
2020-08-06 5:48 ` tytso
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2020-07-27 8:35 UTC (permalink / raw)
To: Xianting Tian; +Cc: tytso, jack, linux-ext4, linux-kernel
On Sat 18-07-20 08:57:37, Xianting Tian wrote:
> Remove unnecessary blank.
>
> Signed-off-by: Xianting Tian <xianting_tian@126.com>
Looks fine. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/journal.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index e494443..5eccf8c 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1285,7 +1285,7 @@ journal_t *jbd2_journal_init_inode(struct inode *inode)
> * superblock as being NULL to prevent the journal destroy from writing
> * back a bogus superblock.
> */
> -static void journal_fail_superblock (journal_t *journal)
> +static void journal_fail_superblock(journal_t *journal)
> {
> struct buffer_head *bh = journal->j_sb_buffer;
> brelse(bh);
> @@ -1815,7 +1815,7 @@ int jbd2_journal_destroy(journal_t *journal)
>
>
> /**
> - *int jbd2_journal_check_used_features () - Check if features specified are used.
> + *int jbd2_journal_check_used_features() - Check if features specified are used.
> * @journal: Journal to check.
> * @compat: bitmask of compatible features
> * @ro: bitmask of features that force read-only mount
> @@ -1825,7 +1825,7 @@ int jbd2_journal_destroy(journal_t *journal)
> * features. Return true (non-zero) if it does.
> **/
>
> -int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_check_used_features(journal_t *journal, unsigned long compat,
> unsigned long ro, unsigned long incompat)
> {
> journal_superblock_t *sb;
> @@ -1860,7 +1860,7 @@ int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
> * all of a given set of features on this journal. Return true
> * (non-zero) if it can. */
>
> -int jbd2_journal_check_available_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_check_available_features(journal_t *journal, unsigned long compat,
> unsigned long ro, unsigned long incompat)
> {
> if (!compat && !ro && !incompat)
> @@ -1882,7 +1882,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
> }
>
> /**
> - * int jbd2_journal_set_features () - Mark a given journal feature in the superblock
> + * int jbd2_journal_set_features() - Mark a given journal feature in the superblock
> * @journal: Journal to act on.
> * @compat: bitmask of compatible features
> * @ro: bitmask of features that force read-only mount
> @@ -1893,7 +1893,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
> *
> */
>
> -int jbd2_journal_set_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_set_features(journal_t *journal, unsigned long compat,
> unsigned long ro, unsigned long incompat)
> {
> #define INCOMPAT_FEATURE_ON(f) \
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: fix incorrect code style
2020-07-18 12:57 [PATCH] jbd2: fix incorrect code style Xianting Tian
2020-07-27 8:35 ` Jan Kara
@ 2020-08-06 5:48 ` tytso
1 sibling, 0 replies; 3+ messages in thread
From: tytso @ 2020-08-06 5:48 UTC (permalink / raw)
To: Xianting Tian; +Cc: jack, linux-ext4, linux-kernel
On Sat, Jul 18, 2020 at 08:57:37AM -0400, Xianting Tian wrote:
> Remove unnecessary blank.
>
> Signed-off-by: Xianting Tian <xianting_tian@126.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-06 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18 12:57 [PATCH] jbd2: fix incorrect code style Xianting Tian
2020-07-27 8:35 ` Jan Kara
2020-08-06 5:48 ` tytso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).