* [PATCH] ext2: Adjust the comment of function ext2_alloc_branch
@ 2019-03-06 1:47 Shuning Zhang
2019-03-19 10:48 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Shuning Zhang @ 2019-03-06 1:47 UTC (permalink / raw)
To: linux-ext4
The name of argument is error in the header comment.
@num should be @indirect_blks.
At the same time, there was a lack of description of the two parameters
@blks and @goal.
This commit therefore fixes this header comment.
Signed-off-by: Shuning Zhang <sunny.s.zhang@oracle.com>
---
fs/ext2/inode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index e4bb938..3f404c3 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -451,7 +451,9 @@ static int ext2_alloc_blocks(struct inode *inode,
/**
* ext2_alloc_branch - allocate and set up a chain of blocks.
* @inode: owner
- * @num: depth of the chain (number of blocks to allocate)
+ * @indirect_blks: depth of the chain (number of blocks to allocate)
+ * @blks: number of allocated direct blocks
+ * @goal: preferred place for allocation
* @offsets: offsets (in the blocks) to store the pointers to next.
* @branch: place to store the chain in.
*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext2: Adjust the comment of function ext2_alloc_branch
2019-03-06 1:47 [PATCH] ext2: Adjust the comment of function ext2_alloc_branch Shuning Zhang
@ 2019-03-19 10:48 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-03-19 10:48 UTC (permalink / raw)
To: Shuning Zhang; +Cc: linux-ext4
On Wed 06-03-19 09:47:35, Shuning Zhang wrote:
> The name of argument is error in the header comment.
> @num should be @indirect_blks.
> At the same time, there was a lack of description of the two parameters
> @blks and @goal.
> This commit therefore fixes this header comment.
>
> Signed-off-by: Shuning Zhang <sunny.s.zhang@oracle.com>
Thanks. I've added the patch to my tree.
Honza
> ---
> fs/ext2/inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index e4bb938..3f404c3 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -451,7 +451,9 @@ static int ext2_alloc_blocks(struct inode *inode,
> /**
> * ext2_alloc_branch - allocate and set up a chain of blocks.
> * @inode: owner
> - * @num: depth of the chain (number of blocks to allocate)
> + * @indirect_blks: depth of the chain (number of blocks to allocate)
> + * @blks: number of allocated direct blocks
> + * @goal: preferred place for allocation
> * @offsets: offsets (in the blocks) to store the pointers to next.
> * @branch: place to store the chain in.
> *
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-19 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 1:47 [PATCH] ext2: Adjust the comment of function ext2_alloc_branch Shuning Zhang
2019-03-19 10:48 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).