Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] fs:ext4:remove unused including <linux/version.h>
       [not found] <201909041536282215333@zte.com.cn>
@ 2019-09-04 13:02 ` Theodore Y. Ts'o
  0 siblings, 0 replies; only message in thread
From: Theodore Y. Ts'o @ 2019-09-04 13:02 UTC (permalink / raw)
  To: zhao.hang1
  Cc: adilger.kernel, linux-ext4, linux-kernel, xue.zhihong, wang.yi59,
	jiang.xuexin

On Wed, Sep 04, 2019 at 03:36:28PM +0800, zhao.hang1@zte.com.cn wrote:
> fix compiler error in ext4.hfs/ext4/ext4.h:30:27: fatal error: linux/version.h: No such file or directorySigned-off-by: Zhao Hang <zhao.hang1@zte.com.cn> --- fs/ext4/ext4.h | 1 - 1 file changed, 1 deletion(-)diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.hindex 1cb6785..9baa4cf 100644--- a/fs/ext4/ext4.h+++ b/fs/ext4/ext4.h@@ -27,7 +27,6 @@ #include <linux/seqlock.h>  #include <linux/mutex.h>  #include <linux/timer.h> -#include <linux/version.h>  #include <linux/wait.h>  #include <linux/sched/signal.h>  #include <linux/blockgroup_lock.h> --  2.15.2

First of all, this patch is completely white space namaged.

Secondly, this is a problem in how you are building your kernel (or
ext4 as a module, if you are trying to build ext4 as some kind of out
of tree module or some such).  When you do a kernel build, the file
include/linux/version.h is automatically generated.  It will look
something like this.

% cat /build/ext4-64/usr/include/linux/version.h
#define LINUX_VERSION_CODE 327936
#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))

			      	       	     - Ted

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <201909041536282215333@zte.com.cn>
2019-09-04 13:02 ` [PATCH] fs:ext4:remove unused including <linux/version.h> Theodore Y. Ts'o

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org linux-ext4@archiver.kernel.org
	public-inbox-index linux-ext4


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/ public-inbox