* [PATCH] ext2: add missing brelse in ext2_new_blocks()
@ 2019-10-22 7:10 Chengguang Xu
2019-10-22 8:28 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2019-10-22 7:10 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, Chengguang Xu
There is a missing brelse of bitmap_bh in the
case of retry.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/ext2/balloc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 924c1c765306..e8eedad479a7 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -1313,6 +1313,7 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
if (free_blocks > 0) {
grp_target_blk = ((goal - le32_to_cpu(es->s_first_data_block)) %
EXT2_BLOCKS_PER_GROUP(sb));
+ brelse(bitmap_bh);
bitmap_bh = read_block_bitmap(sb, group_no);
if (!bitmap_bh)
goto io_error;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext2: add missing brelse in ext2_new_blocks()
2019-10-22 7:10 [PATCH] ext2: add missing brelse in ext2_new_blocks() Chengguang Xu
@ 2019-10-22 8:28 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-10-22 8:28 UTC (permalink / raw)
To: Chengguang Xu; +Cc: jack, linux-ext4
On Tue 22-10-19 15:10:45, Chengguang Xu wrote:
> There is a missing brelse of bitmap_bh in the
> case of retry.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Good catch but please add a comment explaining that 'bitmap_bh' may be
non-null because of retry. Thanks!
Honza
> ---
> fs/ext2/balloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index 924c1c765306..e8eedad479a7 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -1313,6 +1313,7 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
> if (free_blocks > 0) {
> grp_target_blk = ((goal - le32_to_cpu(es->s_first_data_block)) %
> EXT2_BLOCKS_PER_GROUP(sb));
> + brelse(bitmap_bh);
> bitmap_bh = read_block_bitmap(sb, group_no);
> if (!bitmap_bh)
> goto io_error;
> --
> 2.20.1
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-22 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 7:10 [PATCH] ext2: add missing brelse in ext2_new_blocks() Chengguang Xu
2019-10-22 8:28 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).