From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: Olof Johansson <olof@lixom.net>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] fs: ext4: remove unused variable warning in parse_options()
Date: Thu, 14 Nov 2019 17:59:40 -0500 [thread overview]
Message-ID: <20191114225940.GE4579@mit.edu> (raw)
In-Reply-To: <20191112162341.E3F334204C@d06av24.portsmouth.uk.ibm.com>
On Tue, Nov 12, 2019 at 09:53:39PM +0530, Ritesh Harjani wrote:
>
>
> On 11/11/19 7:55 AM, Olof Johansson wrote:
> > Commit c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for
> > dioread_nolock") removed the only user of 'sbi' outside of the ifdef,
> > so it caused a new warning:
> >
> > fs/ext4/super.c:2068:23: warning: unused variable 'sbi' [-Wunused-variable]
> >
> > Fixes: c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for dioread_nolock")
> > Signed-off-by: Olof Johansson <olof@lixom.net>
>
> hmm, I see that I had CONFIG_QUOTA enabled, so missed this.
> Thanks for the patch.
>
> You may add:
> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-11-14 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 2:25 [PATCH] fs: ext4: remove unused variable warning in parse_options() Olof Johansson
2019-11-12 16:23 ` Ritesh Harjani
2019-11-14 22:59 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114225940.GE4579@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).