* [ext4:pu 13/14] fs/ext4/namei.c:1424:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool
@ 2020-01-04 15:04 kbuild test robot
2020-01-04 15:04 ` [PATCH] ext4: fix boolreturn.cocci warnings kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-01-04 15:04 UTC (permalink / raw)
To: Daniel Rosenberg; +Cc: kbuild-all, linux-ext4, Theodore Ts'o
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git pu
head: 84df4cb550cf6bfd1d92585fb11736774d07cad5
commit: 50d710db6f001ce37e13efd62b09bd8c0fc593e8 [13/14] ext4: Hande casefolding with encryption
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> fs/ext4/namei.c:1424:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ext4: fix boolreturn.cocci warnings
2020-01-04 15:04 [ext4:pu 13/14] fs/ext4/namei.c:1424:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool kbuild test robot
@ 2020-01-04 15:04 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-01-04 15:04 UTC (permalink / raw)
To: Daniel Rosenberg; +Cc: kbuild-all, linux-ext4, Theodore Ts'o
From: kbuild test robot <lkp@intel.com>
fs/ext4/namei.c:1424:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 50d710db6f00 ("ext4: Hande casefolding with encryption")
CC: Daniel Rosenberg <drosen@google.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git pu
head: 84df4cb550cf6bfd1d92585fb11736774d07cad5
commit: 50d710db6f001ce37e13efd62b09bd8c0fc593e8 [13/14] ext4: Hande casefolding with encryption
namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1421,7 +1421,7 @@ static bool ext4_match(struct inode *par
if (hinfo.hash != EXT4_DIRENT_HASH(de) ||
hinfo.minor_hash !=
EXT4_DIRENT_MINOR_HASH(de))
- return 0;
+ return false;
}
return !ext4_ci_compare(parent, &cf, de->name,
de->name_len, true);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-04 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-04 15:04 [ext4:pu 13/14] fs/ext4/namei.c:1424:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool kbuild test robot
2020-01-04 15:04 ` [PATCH] ext4: fix boolreturn.cocci warnings kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).