* [PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c
@ 2020-09-11 11:40 Wang Hai
2020-09-14 8:35 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-09-11 11:40 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, linux-kernel
Fixes the following W=1 kernel build warning(s):
fs/ext2/balloc.c:203: warning: Excess function parameter 'rb_root' description in '__rsv_window_dump'
fs/ext2/balloc.c:294: warning: Excess function parameter 'rb_root' description in 'search_reserve_window'
fs/ext2/balloc.c:878: warning: Excess function parameter 'rsv' description in 'alloc_new_reservation'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
fs/ext2/balloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index fa9c951d3471..1f3f4326bf3c 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -189,7 +189,7 @@ static void group_adjust_blocks(struct super_block *sb, int group_no,
/**
* __rsv_window_dump() -- Dump the filesystem block allocation reservation map
- * @rb_root: root of per-filesystem reservation rb tree
+ * @root: root of per-filesystem reservation rb tree
* @verbose: verbose mode
* @fn: function which wishes to dump the reservation map
*
@@ -282,7 +282,7 @@ goal_in_my_reservation(struct ext2_reserve_window *rsv, ext2_grpblk_t grp_goal,
/**
* search_reserve_window()
- * @rb_root: root of reservation tree
+ * @root: root of reservation tree
* @goal: target allocation block
*
* Find the reserved window which includes the goal, or the previous one
@@ -859,7 +859,7 @@ static int find_next_reservable_window(
*
* failed: we failed to find a reservation window in this group
*
- * @rsv: the reservation
+ * @my_rsv: the reservation
*
* @grp_goal: The goal (group-relative). It is where the search for a
* free reservable space should start from.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c
2020-09-11 11:40 [PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c Wang Hai
@ 2020-09-14 8:35 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2020-09-14 8:35 UTC (permalink / raw)
To: Wang Hai; +Cc: jack, linux-ext4, linux-kernel
On Fri 11-09-20 19:40:36, Wang Hai wrote:
> Fixes the following W=1 kernel build warning(s):
>
> fs/ext2/balloc.c:203: warning: Excess function parameter 'rb_root' description in '__rsv_window_dump'
> fs/ext2/balloc.c:294: warning: Excess function parameter 'rb_root' description in 'search_reserve_window'
> fs/ext2/balloc.c:878: warning: Excess function parameter 'rsv' description in 'alloc_new_reservation'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Thanks. I've added the patch to my tree.
Honza
> ---
> fs/ext2/balloc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index fa9c951d3471..1f3f4326bf3c 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -189,7 +189,7 @@ static void group_adjust_blocks(struct super_block *sb, int group_no,
>
> /**
> * __rsv_window_dump() -- Dump the filesystem block allocation reservation map
> - * @rb_root: root of per-filesystem reservation rb tree
> + * @root: root of per-filesystem reservation rb tree
> * @verbose: verbose mode
> * @fn: function which wishes to dump the reservation map
> *
> @@ -282,7 +282,7 @@ goal_in_my_reservation(struct ext2_reserve_window *rsv, ext2_grpblk_t grp_goal,
>
> /**
> * search_reserve_window()
> - * @rb_root: root of reservation tree
> + * @root: root of reservation tree
> * @goal: target allocation block
> *
> * Find the reserved window which includes the goal, or the previous one
> @@ -859,7 +859,7 @@ static int find_next_reservable_window(
> *
> * failed: we failed to find a reservation window in this group
> *
> - * @rsv: the reservation
> + * @my_rsv: the reservation
> *
> * @grp_goal: The goal (group-relative). It is where the search for a
> * free reservable space should start from.
> --
> 2.17.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-14 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 11:40 [PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c Wang Hai
2020-09-14 8:35 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).